Dynamic Array of Structures, Loop problem!

[binteron]

I am new to C++ and working through SAMS C++ primer. one of the excercies involves creating a dynamic array of structures to catalogue car information. I have the following code almost working and I am sure that I am missing something really simple.

The program compiles and runs as expected, however on the first run through the loop, the "make" of the car is not stored in the array. All subsequent loops capture the input and display properly.

Any help or point in the right direction would be appreciated.

thanks.

//c++ primer ch 5 ex 6.
#include <iostream>
using namespace std;

struct car {

    char make[20];
    int year;

    
};
int c;
int t = 1;
    int main() {
            cout <<"How many cars would you like to catalogue? ";
            cin >>c;
            cin.get();

            car * catalogue = new car[c];
            car *ptr = &catalogue[0];

            for (int i = 0;i < c; ++i)
            {                 
                cout <<"Car# "<<t<<":\n";
                cout <<"Enter make of car: ";
                cin.getline(ptr[i].make,20);
                cout <<"Enter year of car: ";
                cin >> ptr[i].year;
                cin.get();
                cout <<"\n";            
            ++t;
            };
            delete [] catalogue;

            cout <<"Your catalogue of cars: \n";
            for (int i = 0; i < c;++i)
            { cout <<catalogue[i].year<<" "<<catalogue[i].make<<"\n";
            };

    }

[Salem]

> car *ptr = &catalogue[0];
What does this achieve?

You can do this cin.getline(catalogue[i].make,20); > delete [] catalogue;
You need to do this after you've finished printing the data, not before.

> however on the first run through the loop, the "make" of the car is not stored in the array
Maybe you typed a space after the input of how many cars
So the get() only got rid of the space, not the newline which would immediately satisfy the getline.

[binteron]

Hi Salem, Thanks for the quick reply. *ptr is something from a different book, it said pointer was best way to access dynamic arrays.

I have run the program many times and not entered a space after the number of cars, so that's a good thought, but not it. Also I had put a cin.get() after the input to see if there was something there causing the problem.

[binteron]

Well, I moved the delete [] catalogue line to the end of the program and now the thing runs perfectly.

Thanks Salem! I new it would be something simple and painfully obvious when you look at it.....duhhh.

best regards

[Salem]

> it said pointer was best way to access dynamic arrays.
It's the only way.

But both variables have the same type.

car * catalogue = new car[c];
            car *ptr = &catalogue[0];

All you've actually achieved is changing a 9-letter variable name (with some meaning) for a 3-letter variable name (with very little meaning). ptr[n] and catalogue[n] do exactly the same thing.

What you've also created is a dangling pointer problem. By having two variables pointing at the same memory you introduce the possibility of accessing ptr[n] long after you've done delete [ ] catalogue.

[binteron]

I see, so in essence i created an extra pointer, one that wasn't needed. I had wondered about that, I must have misinterpreted the first book i read. Thanks a bunch for taking the time to clear that up form me.

Cheers Salem.