## Featured Replies in this Discussion

- by Narue
- by Narue>Sorry. I didn't read your code carfully enough before I replied. Maybe you should run example code to see if it works before trying to correct it with an incorrect solution. Starting the inner loop at 0 instead of i + 1 will result in a lot of shuffling to get the same matrix that you started with, not a transposed matrix as the OP requested. So maybe you should also test your own code…

If it's a square matrix then you can do it with something like this:

`for (int i = 0; i < 4; i++) { for (int j = i + 1; j < 4; j++) { int save = matrix[i][j]; matrix[i][j] = matrix[j][i]; matrix[j][i] = save; } }`

If it's a non-square matrix then you're SOL.

Your program won't work. The reason is that when you write matrix*[j] = matrix[j] you've lost the contents of matrix[j] forever and you can't get it back to put in position [[j]. This will do it.*

```
for (int i = 0; i < 4; i++)
for (int j = 0; j < 4; j++)
{ save = matrix[i][j];
matrix[i][j] = matrix[j][i];
matrix[j][i] = save;
}
```

If it's a square matrix then you can do it with something like this:

`for (int i = 0; i < 4; i++) { for (int j = i + 1; j < 4; j++) { int save = matrix[i][j]; matrix[i][j] = matrix[j][i]; matrix[j][i] = save; } }`

If it's a non-square matrix then you're SOL.

Sorry. I didn't read your code carfully enough before I replied.

>Sorry. I didn't read your code carfully enough before I replied.

Maybe you should run example code to see if it works before trying to correct it with an incorrect solution. Starting the inner loop at 0 instead of i + 1 will result in a lot of shuffling to get the same matrix that you started with, not a transposed matrix as the OP requested. So maybe you should also test your own code before posting it. Especially if you're trying to correct someone and using it as an example.

On a purely stylistic point, I have two issues with your code. First, even though it's valid the way you did it, you should always put braces around a loop or if construct that has more than a one line body. This way you don't have to rely solely on indention to prove that your code is correct. You also avoid certain pitfalls.

Second, starting the statements of a block on the same line as the opening brace is a formatting nightmare. It makes code harder to read and harder to reformat so that it's easier to follow.

Something more like this (following your apparent brace indention style):

```
for (int i = 0; i < 4; i++)
{
for (int j = 0; j < 4; j++)
{
save = matrix[i][j];
matrix[i][j] = matrix[j][i];
matrix[j][i] = save;
}
}
```

You also failed to define save before using it, but I'll let you slide on that. ;)

// prog to mulltiply matrix

```
#include<stdio.h>
#include<conio.h>
void main()
{
int a[10][10],b[10][10],c[10][10],i,j,k,m,n,m1,n1;
clrscr();
printf("Enter array size ");
scanf("%d%d",&m,&n);
printf("Enter array size 2");
scanf("%d%d",&m1,&n1);
if(n!=m1)
{
printf("Wrong choice entered");
getch();
exit(0);
}
else
{
printf("Enter elements");
for(i=0;i<m;i++)
{
for(j=0;j<n;j++)
{
scanf("%d",&a[i][j]);
}
}
printf("Enter element 2");
for(i=0;i<m1;i++)
{
for(j=0;j<n1;j++)
{
scanf("%d",&b[i][j]);
}
}
for(i=0;i<m;i++)
{
for(j=0;j<n1;j++)
{
c[i][j]=0;
for(k=0;k<n;k++)
{
c[i][j]=c[i][j]+(a[i][k]*b[k][j]);
}
}
}
printf("REQUIRED MATRIX");
for(i=0;i<m;i++)
{
for(j=0;j<n1;j++)
{
printf("\n%d",c[i][j]);
}
printf("\n");
}
getch();
}
}
```

You only need to loop through less-than-half of the matrix since in each execution of the inner loop you're swapping two elements (and the main diagonal stays put). If you iterated through the whole matrix, you'd just put it back the way it started. Starting j at i+1 loops through the upper triangle of the square (or lower, depending on how you look at it), swapping elements with the opposite triangle.

The above code needs a small change. If you use the above code for transpose, you will end up getting the same matrix as before because, you are replacing rows and columns twice.

You need to do the replacement only once.

```
for ( i=0; i<3; i++)
{
for ( j=0; j<3; j++)
{
if(i>j)
{
temp = inputmatrix[i][j];
inputmatrix[i][j] = inputmatrix[j][i];
inputmatrix[j][i] = temp;
}
}
};
```