memory leak on BST destructor

[aaronmk2]

My program runs, but I am getting this message which I am fairly sure means that I have a memory leak and it is coming from my destructor.
Assignment2(779) malloc: *** error for object 0x100100120: pointer being freed was not allocated
I don't know what I am doing wrong. Since it is a binary search tree I figured while not empty go left if you can't go left go right, if you can't go right, delete. Any tips would be great.

BST::~BST()
{
	BinNodePtr parent = 0, temp = myRoot;
	while(!empty()){
		while(temp->left!='\0'){
			parent = temp;
			temp = temp->left;
		}
		 while (temp->right!='\0'){
			parent = temp;
			temp = temp->right;
		 }
			delete temp;
		}
}

[mrnutty]

Yea doesn't look like your destructing it properly. Try something like this :

BinarySearchTree::~BinarySearchTree(){
  _destroy(this._root);
}
void BinarySearchTree::_destroy(Node* root){
  if( isNull(root) ) return;
  else{
     _destroy(root.getLeft());
     _destroy(root.getRight());
      delete root;    
  }
}

[aaronmk2]

Thanks, my program no longer leaks memory. Do you have any ideas of what I could have done to my original destructor to make it work?

[mrnutty]

Thanks, my program no longer leaks memory. Do you have any ideas of what I could have done to my original destructor to make it work?

It looks like your trying to iteratively delete the nodes. Your algorithm does not transverse the entire tree, but it transverses all the way to the left, then maybe right,
and deletes that nodes, and exits. So to make your algorithm work, you would need to
modify how do the transversal, in which case, a recursive solution is easier to implement and understand.

[iopp]

malloc: *** error for object 0x100100120: incorrect checksum
*** set a breakpoint in malloc_error_break to debug
Abort

[iopp]

I come to this problem when I run a program,please someone help me!many thanks!