Output Problem

[gallantmon1]

Here's my code:

import java.awt.FlowLayout;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import javax.swing.JFrame;
import javax.swing.JButton;
import javax.swing.Icon;
import javax.swing.ImageIcon;
import javax.swing.JOptionPane;

public class DisplayGUI extends JFrame
{
	public static void main(String args[]) throws Exception
	{
	    ButtonFrame buttonFrame = new ButtonFrame();
	    buttonFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	    buttonFrame.setSize(275, 75);
	    buttonFrame.setVisible(true);

	}

    private JButton Fibonacci;
    private JButton Factorial;

    public DisplayGUI()
    {
        setLayout(new FlowLayout());

    	Factorial= new JButton("Factorial");
    	add(Factorial);
    	Fibonacci = new JButton("Fibonacci");
        add(Fibonacci);

    	ButtonHandler handler = new ButtonHandler();
    	Factorial.addActionListener(handler);
    	Fibonacci.addActionListener(handler);
    }

    private class ButtonHandler implements ActionListener
    {
        int a=0,ctr=0,rep=1,x,b=0;
		String strNum = JOptionPane.showInputDialog(null, "Input integer number: ", "Input", JOptionPane.QUESTION_MESSAGE);
      	int Num=Integer.parseInt(strNum);

        public void actionPerformed(ActionEvent event)
        {
			Object source = event.getSource();
			if(source == Factorial)
			{
				a=Num;
				ctr=Num;
				while (ctr>1)
				{
				    ctr--;
				    a=a*ctr;
				}
                JOptionPane.showMessageDialog(null, "Factorial of "+Num+": "+a+"\n", "Factorial", JOptionPane.INFORMATION_MESSAGE);
			}
			if(source == Fibonacci)
			{
				ctr=1;
				int n=0;
				int fib=1;
				if (Num==0)
				{
					JOptionPane.showMessageDialog(null, "0", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
				}
				else
				{
				    while (fib<Num)
				    {
				        if (ctr==1)
				        {
							JOptionPane.showMessageDialog(null, ""+fib+"", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
							a=fib;
						}
				        else if (ctr==2)
				        {
							JOptionPane.showMessageDialog(null, "1", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
							b=1;
						}
						else
						{
							fib = (Num-1)+(Num-2);
							for(int ctr=0;ctr<=10; ctr++);
							JOptionPane.showMessageDialog(null, ""+ctr+"", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
						}
					}
				}
        	}
		}
	}
}

My problem here is that when I try the fibonacci button, it shows the output one by one.

ex. input 15

1 then OK

1 then OK

2 then OK

and so forth...

What I need is to output the whole series in one dialog box like this...

1 1 2... and so forth...

Can anyone tell me what to do

[DangerDev]

use array to store the result, and at last show the result.

[gallantmon1]

How exactly can I do that?

[gallantmon1]

I edited the last else statement a bit like this:

fib = (Num-1)+(Num-2);
							for(int ctr=0; ctr<=10; ctr++);
							for(i=0; i<Num; i++)
							{
								fiboCount[i]=ctr;

							}
							String output = String.format(""+fiboCount[i]+"");
							JOptionPane.showMessageDialog(null, output);

but it still has the same result

[VernonDozier]

I tried to test out your code but was unable to because you have not posted the ButtonFrame class code:

public static void main(String args[]) throws Exception
	{
	    ButtonFrame buttonFrame = new ButtonFrame();
	    buttonFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	    buttonFrame.setSize(275, 75);
	    buttonFrame.setVisible(true);

	}

[gallantmon1]

The whole code is actually on my first post. The previous code I put is an edited version of only the last else statement in the original code in my first post.

[VernonDozier]

The whole code is actually on my first post. The previous code I put is an edited version of only the last else statement in the original code in my first post.

I'm looking through this entire thread. I don't see ButtonFrame class code anywhere, including the first post. In particular, I don't see the ButtonFrame() constructor. Did I miss it? Is it on a prior thread?

[gallantmon1]

You did miss it. It's actually the first part of my code

I put it here to save you the trouble

public class DisplayGUI extends JFrame
{
	public static void main(String args[]) throws Exception
	{
	    ButtonFrame buttonFrame = new ButtonFrame();
	    buttonFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	    buttonFrame.setSize(275, 75);
	    buttonFrame.setVisible(true);

	}

    private JButton Fibonacci;
    private JButton Factorial;

    public DisplayGUI()
    {
        setLayout(new FlowLayout());

    	Factorial= new JButton("Factorial");
    	add(Factorial);
    	Fibonacci = new JButton("Fibonacci");
        add(Fibonacci);

    	ButtonHandler handler = new ButtonHandler();
    	Factorial.addActionListener(handler);
    	Fibonacci.addActionListener(handler);
    }

I changed the ButtonFrame() constructor to DisplayGUI

[VernonDozier]

You did miss it. It's actually the first part of my code

I put it here to save you the trouble

public class DisplayGUI extends JFrame
{
	public static void main(String args[]) throws Exception
	{
	    ButtonFrame buttonFrame = new ButtonFrame();
	    buttonFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	    buttonFrame.setSize(275, 75);
	    buttonFrame.setVisible(true);

	}

    private JButton Fibonacci;
    private JButton Factorial;

    public DisplayGUI()
    {
        setLayout(new FlowLayout());

    	Factorial= new JButton("Factorial");
    	add(Factorial);
    	Fibonacci = new JButton("Fibonacci");
        add(Fibonacci);

    	ButtonHandler handler = new ButtonHandler();
    	Factorial.addActionListener(handler);
    	Fibonacci.addActionListener(handler);
    }

I changed the ButtonFrame() constructor to DisplayGUI

So then this line would have to change from this:

ButtonFrame buttonFrame = new ButtonFrame();

to this:

DisplayGUI buttonFrame = new DisplayGUI();

since there is no ButtonFrame class. Correct?

[gallantmon1]

Yes, forgot to change that part, my bad.

[stultuske]

or add it all to a single String object.
String number = "";

and every time you have found your new number:

number += " " + numberYouHaveJustFound;

[VernonDozier]

while (fib<Num)
				    {
				        if (ctr==1)
				        {
							JOptionPane.showMessageDialog(null, ""+fib+"", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
							a=fib;
						}
				        else if (ctr==2)
				        {
							JOptionPane.showMessageDialog(null, "1", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
							b=1;
						}
						else
						{
							fib = (Num-1)+(Num-2);
							for(int ctr=0;ctr<=10; ctr++);
							JOptionPane.showMessageDialog(null, ""+ctr+"", "Fibonacci", JOptionPane.INFORMATION_MESSAGE);
						}
					}

You're in an infinite loop here if ctr == 1 or ctr == 2. If either the "if" block or the "else if" block is executed, the ctr, fib, and Num variables will never change. Since they are the loop control variables, you have an infinite loop.

[gallantmon1]

Thanks for the replies. I finally finished the code.