Dynamic path Function calling Error?

[sarithak]

Hi frnds...

Here i am creating thumbnail image...the code is working fine...

The variables are not working calling funtion....if i give static path, its working fine...

incase of dynamic path it displays some errors,but image created..image with full black(no photo).......plz check the below code...

function createthumb($name,$filename,$new_w,$new_h){
	$system=explode('.',$name);
	if (preg_match('/jpg|jpeg/',$system[1])){
		$src_img=imagecreatefromjpeg($name);
	}
	if (preg_match('/png/',$system[1])){
		$src_img=imagecreatefrompng($name);
	}
		
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);
if ($old_x > $old_y) {
	$thumb_w=$new_w;
	$thumb_h=$old_y*($new_h/$old_x);
}
if ($old_x < $old_y) {
	$thumb_w=$old_x*($new_w/$old_y);
	$thumb_h=$new_h;
}
if ($old_x == $old_y) {
	$thumb_w=$new_w;
	$thumb_h=$new_h;
}
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);
	imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y); 
	
if (preg_match("/png/",$system[1]))
{
	imagepng($dst_img,$filename); 
} else {
	imagejpeg($dst_img,$filename); 
}
imagedestroy($dst_img); 
imagedestroy($src_img); 
}

$photo1=mysql_real_escape_string($_FILES['photo1']['name']);
$tphoto1=mysql_real_escape_string($_FILES['photo1']['tmp_name']);

$dir="../../chillzone/citybuzz/$category/$dirid";
if(!file_exists($dir))
mkdir($dir)or die("Filename all ready exits");
$dir1="$dir"."/"."$photo1" ; //working....
if($photo1!=""){move_uploaded_file($_FILES['photo1']['tmp_name'], $dir1);}

createthumb('img5.jpg','thumbs/img5.jpg',100,100);//working....

createthumb('$dir1','$dir/thumbs/$photo1',100,100);//Not working(problem here only)

It displays errors:

Notice: Undefined variable: src_img in C:\wamp\www\vvvv.com\admin\thumb.php on line 12

Warning: imagesx(): supplied argument is not a valid Image resource in C:\wamp\www\vvvv.com\admin\thumb.php on line 12

Notice: Undefined variable: src_img in C:\wamp\www\aaa.com\admin\thumb.php on line 13

Warning: imagesy(): supplied argument is not a valid Image resource in C:\wamp\www\vvvv.com\admin\thumb.php on line 13

Notice: Undefined variable: src_img in C:\wamp\www\aaa.com\admin\thumb.php on line 27

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in C:\wamp\www\vvvv.com\admin\thumb.php on line 27

Notice: Undefined variable: src_img in C:\wamp\www\aaa.com\admin\thumb.php on line 36

Warning: imagedestroy(): supplied argument is not a valid Image resource in C:\wamp\www\vvvv.com\admin\thumb.php on line 36

[phper]

Id write this line of code as

createthumb($dir1,$dir.'/thumbs/'.$photo1,100,100);

Give that a try.

[wilch]

well, if the problem is on line 48, the most sinister actors would be the 2 arguments '$dir1' AND '$dir/thumbs/$photo1'

- try outputting these strings before you call the function, and see what they contain.
e.g. echo "++$dir1++$dir/thumbs/$photo1++";

[wilch]

well, if the problem is on line 48, the most sinister actors would be the 2 arguments '$dir1' AND '$dir/thumbs/$photo1'

- try outputting these strings before you call the function, and see what they contain.
e.g. echo "++$dir1++$dir/thumbs/$photo1++";

[kylegetson]

Your issue is your using single quotes ' instead of double quotes " as a string with a variable in it.
on line 48 you have:

createthumb('$dir1','$dir/thumbs/$photo1',100,100);//Not working(problem here only)

Try:

createthumb("$dir1","$dir/thumbs/$photo1",100,100);//Not working(problem here only)

the problem is, that when you use single quotes '$myvar' will actually be the string $myvar instead of the variable myvar. PHP does not parse inside single quotes, only double quotes.

hope that helps.

[sarithak]

Hi friends...

Thanks 4 ur suggestions...
the total path taking correctly...But instead of creating thumbnail image..it creates blank thumbnail image....

But when the path giving statically it create correct thumbnail image...plz check the above code....

Thanks in advance...

Saritha K

[chyssa]

Thanks for sharing your ideas it can help me a lot...

[network18]

function createthumb() expect the first parameter to be image file name and i guess $filename is the directory path.
I think there is problem with you passing as $dir1, it seems to be made from $dir and some dir structure.Also what comes in $dirid is not been clear

[sarithak]

function createthumb() expect the first parameter to be image file name and i guess $filename is the directory path.
I think there is problem with you passing as $dir1, it seems to be made from $dir and some dir structure.Also what comes in $dirid is not been clear

hey ..

Thanks...

this is my code...

$dir="../../dir/sub/$category/$dirid";
if(!file_exists($dir))
mkdir($dir)or die("Filename all ready exits");
$tdir="../../dir/sub/$category/$dirid/thumbs";
if(!file_exists($tdir))
mkdir($tdir)or die("Filename all ready exits");
//$dir1="$dir"."/"."$photo1" ;
//$dir2="$dir"."/"."$photo2" ;
//$dir3="$dir"."/"."$photo3" ;
//$dir4="$dir"."/"."$photo4" ;

$dir1="$dir/$photo1" ;
$dir2="$dir/$photo2" ;
$dir3="$dir/$photo3" ;
$dir4="$dir/$photo4" ;

if($photo1!=""){move_uploaded_file($_FILES['photo1']['tmp_name'], $dir1);
createthumb("$dir1",'$dir/thumbs/$photo1',100,100);
}

It creates Blank thumnail image...no errors....

[network18]

did you noticed that you checking with image type against jpeg/jpg and png, check which format image you passing, when blank thumbnail gets created.

[sarithak]

did you noticed that you checking with image type against jpeg/jpg and png, check which format image you passing, when blank thumbnail gets created.

Hi...

here i m using same image for both static testing & dynamic...i.e JPEG.....