MySQL Update does not work

DARK_BYTE 0 Junior Poster in Training · 2010-01-03T20:58:27+00:00

I think its because of the ';' inside the query string or something

slr 0 Newbie Poster · 2010-01-03T21:01:34+00:00

Thanks for the reply.

Still the same error.

$query = 'UPDATE `table`.`admin` SET `password` = \''.$password.'\' WHERE `admin`.`id` = 1';

I even removed the LIMIT. It updated the table with the new dummy password though - strange!

DARK_BYTE 0 Junior Poster in Training · 2010-01-03T21:12:52+00:00

Maybe rewriting the query like this will solve the prblm:
$query="UPDATE admin SET password='$password' WHERE id='1'";

slr 0 Newbie Poster · 2010-01-03T21:23:50+00:00

No. The same error. I think its the actual line 18:

if(mysql_num_rows($result)==1)

JRM 107 Practically a Master Poster · 2010-01-03T21:51:34+00:00

You have boolean inside the argument.
try this:

var_dump($result); //check what is coming from the query,if anything

if(mysql_num_rows($result) = 1) ; //It's a value result , not boolean

slr 0 Newbie Poster · 2010-01-03T22:04:03+00:00

bool(true)
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /admin/newpass.php on line 20

Thats the error. Line 20

if(mysql_num_rows($result)==1)

If I change it to:

if(mysql_num_rows($result)=1) // note - only one equal sign =

It gives this error:

Fatal error: Can't use function return value in write context in /newpass.php on line 20

JRM 107 Practically a Master Poster · 2010-01-03T22:15:48+00:00

Sometimes you have to go with the flow...

$test = mysql_num_rows($result); //set to a variable
//test for the existence of $test. You only want know if it's there
If($test)
{
// code
}

slr 0 Newbie Poster · 2010-01-03T22:19:59+00:00

What do you mean? Sorry

JRM 107 Practically a Master Poster · 2010-01-03T22:31:07+00:00

I mean try the code that I posted!

Sometimes functions inside of statements don't play well together. Thus "go with the flow" and separate them.

slr 0 Newbie Poster · 2010-01-03T22:35:20+00:00

I get the same error on line 18: This is line 18 and the code

$action = mysql_num_rows($result);
		
			if($action)
			
			{	
				print '<script type="text/javascript">window.location="login.php</script>';
  
			} else {
				
				// Error, the password cannot be reset
				
				$err='Sorry the password has not been updated. Try again';
			}

JRM 107 Practically a Master Poster · 2010-01-03T23:32:32+00:00

I get the same error on line 18: This is line 18 and the code

$action = mysql_num_rows($result);
		
			if($action)
			
			{	
				print '<script type="text/javascript">window.location="login.php</script>';
  
			} else {
				
				// Error, the password cannot be reset
				
				$err='Sorry the password has not been updated. Try again';
			}

I think you need to go back and fix that query as others have mentioned.
The synatx does not look correct to me.
Also, it just occurred to me that you are doing an update not a select.
This function may work better.

$test = msql_affected_rows($result);

However, you should revisit that query syntax. Did you check it with PHPmyadmin? There's just too much gooblygock there, seems to me.

$query = 'UPDATE `table`.`admin` SET `password` = \''.$password.'\' WHERE `admin`.`id` = 1';

A gereic version might be:

$query =" UPDATE 'databaseName.tableName'  SET 'password' = ". $password.
"WHERE 'tableName.id' =1";

Are you sure that you only want to keep updating id =1 ???

slr 0 Newbie Poster · 2010-01-04T00:17:18+00:00

OK I changed the whole setup

login.php

<?
print "	
	<form action='changepass.php' method='GET'>
		<p>new password:
			<input type='password' name='password' size='20' />
		</p>
		<input type='submit' value='Change password' />
	</form>";
?>

changepass.php

<?
$password = $_GET['password'];
	
// Connect to MySQL

$con = mysql_connect("localhost","","");
if (!$con)
{
	die('Could not connect: ' . mysql_error());
}
mysql_select_db("", $con);

// Update the password.

mysql_query("UPDATE `admin` SET `password` = '". $password. "' WHERE `id` =1)");		

// Redirect

print '<script type="text/javascript">window.location="login.php";</script>';
?>

Now NOTHING gets updated in my database

slr 0 Newbie Poster · 2010-01-04T00:21:12+00:00

MySQL PHP code without the GET String (phpMyADMIN)

$sql = 'UPDATE `table`.`admin` SET `password` = \'test\' WHERE `admin`.`id` = 1 LIMIT 1;';

JRM 107 Practically a Master Poster · 2010-01-04T01:00:23+00:00

I asume that the query works to your satisfaction in PHPmyadmin?
Just a minor change should do it in the code:

$sql = "UPDATE `table`.`admin` SET `password` = ".$password."WHERE `admin`.`id` = 1 LIMIT 1;" ;

There were too many ticks in the sql. PHP need the quotes so that the password variable can be properly concatenated.

JRM 107 Practically a Master Poster · 2010-01-04T01:07:54+00:00

Forgot to mention the $_get IS NOT the way collect passwords! they are displayed in the URL.
Use the POST method on the form instead.
collect with $_POST()

sharikul 0 Newbie Poster · 2012-10-23T20:29:15+00:00

If anyone is finding themselves in this similar situation, try to wrap the variable names in double quotation marks. I was having a similar issue just today and wrapping my variable names within a MySQL query statement seems to have fixed it.

yewbhex 0 Newbie Poster · 2012-10-24T07:46:04+00:00

//this will update the password
$update=mysql_query("UPDATE table.admin SET password = '$password' WHERE admin.id ='$id'") or die("couldn't update");

//after these all u need to do is wirte these code b/c if not updated it will display couldn't update else it will go to the next code that is the code below
header("location:login.php");

MySQL Update does not work

Recommended Answers

All 17 Replies

MySQL Update does not work

Recommended Answers Collapse Answers

All 17 Replies

Recommended Answers