OK I'm making a script and I get this error and have no clue off have to fix heres the code all help is thanked:

import java.awt.*;
import java.util.*;
import java.util.List;
import java.util.logging.Level;
import javax.accessibility.*;
import javax.swing.*;

import org.rsbot.bot.Bot;
import org.rsbot.script.*;
import org.rsbot.script.wrappers.*;
import org.rsbot.accessors.*;
import org.rsbot.event.listeners.PaintListener;
import org.rsbot.event.listeners.ServerMessageListener;
import org.rsbot.event.events.ServerMessageEvent;
import org.rsbot.util.ScreenshotUtil;
import org.rsbot.script.wrappers.RSInterface;
import org.rsbot.script.wrappers.RSItem;
import org.rsbot.script.wrappers.RSItemTile;
import org.rsbot.script.wrappers.RSNPC;
import org.rsbot.script.wrappers.RSPlayer;
import org.rsbot.script.wrappers.RSTile;
import org.rsbot.script.wrappers.RSTilePath;
import org.rsbot.script.wrappers.RSObject;

@ScriptManifest(authors = { "Ubot" }, category = "Mining", name = "UbotsMiner", version = 1.00, description = "<html><head></head><body> Welcome to my first script! Please report all bugs & suggestions to Narutoguy312@hotmail.com.</body></html\n")  
public class UbotsMiner extends Script {


    //** Ints
    public int[] tinId = {11957,11958,11959};
    public int[] copperId = {11962,11960,11961};
    public int[] pickId = {1275,1265,15259,1267,1273,1271,1269};
    public int miningAnimation = 627;

    RSTile[] mineToBank = {new RSTile (3285,3371), new RSTile(3292,3383), new RSTile(3290,3400), new RSTile(3289,3416), new RSTile(3280,3428), new     RSTile(3266,3430), new RSTile(3254,3420) };

    RSTile[] bankToMine = {new RSTile(3255,3428), new RSTile(3270,3426), new RSTile(3284,3424), new RSTile(3288,3414), new RSTile(3290,3399), new      RSTile(3291,3383), new RSTile(3283,3367) };

    public boolean onStart(final Map<String, String> args) { 
        return true; 
    } 

    public int loop() { 
    if(isInventoryFull()) { 
    dropAllExcept(pickId);   
    return 600; 
    } 

    RSObject rock = getNearestObjectByID(tinId); 
    if(rock == null) { 
    return 500; 
    atObject(tinId, "Mine");  
    return 1100; 
    }

    public void onFinish()  { 
    log("Script completed. Thank you for using my script.");
    log("Please report any bugs to me at ********@hotmail.com.");
            } 

       }
}

Recommended Answers

All 3 Replies

OK I'm making a script and I get this error and have no clue off have to fix heres the code all help is thanked:

import java.awt.*;
import java.util.*;
import java.util.List;
import java.util.logging.Level;
import javax.accessibility.*;
import javax.swing.*;

import org.rsbot.bot.Bot;
import org.rsbot.script.*;
import org.rsbot.script.wrappers.*;
import org.rsbot.accessors.*;
import org.rsbot.event.listeners.PaintListener;
import org.rsbot.event.listeners.ServerMessageListener;
import org.rsbot.event.events.ServerMessageEvent;
import org.rsbot.util.ScreenshotUtil;
import org.rsbot.script.wrappers.RSInterface;
import org.rsbot.script.wrappers.RSItem;
import org.rsbot.script.wrappers.RSItemTile;
import org.rsbot.script.wrappers.RSNPC;
import org.rsbot.script.wrappers.RSPlayer;
import org.rsbot.script.wrappers.RSTile;
import org.rsbot.script.wrappers.RSTilePath;
import org.rsbot.script.wrappers.RSObject;

@ScriptManifest(authors = { "Ubot" }, category = "Mining", name = "UbotsMiner", version = 1.00, description = "<html><head></head><body> Welcome to my first script! Please report all bugs & suggestions to Narutoguy312@hotmail.com.</body></html\n")  
public class UbotsMiner extends Script {


    //** Ints
    public int[] tinId = {11957,11958,11959};
    public int[] copperId = {11962,11960,11961};
    public int[] pickId = {1275,1265,15259,1267,1273,1271,1269};
    public int miningAnimation = 627;

    RSTile[] mineToBank = {new RSTile (3285,3371), new RSTile(3292,3383), new RSTile(3290,3400), new RSTile(3289,3416), new RSTile(3280,3428), new     RSTile(3266,3430), new RSTile(3254,3420) };

    RSTile[] bankToMine = {new RSTile(3255,3428), new RSTile(3270,3426), new RSTile(3284,3424), new RSTile(3288,3414), new RSTile(3290,3399), new      RSTile(3291,3383), new RSTile(3283,3367) };

    public boolean onStart(final Map<String, String> args) { 
        return true; 
    } 

    public int loop() { 
    if(isInventoryFull()) { 
    dropAllExcept(pickId);   
    return 600; 
    } 

    RSObject rock = getNearestObjectByID(tinId); 
    if(rock == null) { 
    return 500; 
    atObject(tinId, "Mine");  
    return 1100; 
    }

    public void onFinish()  { 
    log("Script completed. Thank you for using my script.");
    log("Please report any bugs to me at ********@hotmail.com.");
            } 

       }
}

ok. i havent gone thru the entire of ur code but heres something that caught my eye. ur onFinish() method is inside ur loop() method.
so u might wanna check that out.

ok. i havent gone thru the entire of ur code but heres something that caught my eye. ur onFinish() method is inside ur loop() method.
so u might wanna check that out.

Well thanks but I'm new to Java and by looking at the code i thought with a } I stopped the loop but I quess i didin't can someone tell me how to end the loop?

look at the comment in the code

public int loop() { 
    if(isInventoryFull()) { 
    dropAllExcept(pickId);   
    return 600; 
    } 
 
    RSObject rock = getNearestObjectByID(tinId); 
    if(rock == null) { 
    return 500; 
// MAYBE U WERE MEANING TO END THIS IF BEFORE GOIN ANY FURTHR. so right before atObject(tinId, "Mine");  try inserting the close parenthesis }
}
    atObject(tinId, "Mine");  
    return 1100; 
    }
 
    public void onFinish()  { 
    log("Script completed. Thank you for using my script.");
    log("Please report any bugs to me at ********@hotmail.com.");
            } 
 
       }
}

so it could be the problem. im really sorry man i need to rush out so i cant stay any longer. I just thought id give u this hin b4 goin.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.