weird ascii character on cout and fout

[amishraa]

the char character for grade are coming up with weird ascii like characters instead of the letter grades. Please help!

//declaration

string first, last;
int prog1, prog2,prog3,prog4, prog5, test1, test2;
int totalpts, progavg, testavg, courseavg;
char grade;

//executables
totalpts = (prog1+prog2+prog3+prog4+prog5+test1+test2);
progavg = (prog1+prog2+prog3+prog4+prog5)/5;
testavg = (test1+test2)/2;
courseavg = (progavg+testavg)/2;

if (courseavg >=90 )grade=='A';
else if (courseavg <= 89 )grade=='B';
else if (courseavg <=79 )grade=='C';
else grade=='F';

cout<<left<<setw(20)<<"Student Name"<<setw(10)<<"Total"<<setw(10)<<"Program"<<setw(10)<<"Test"<<setw(10)<<"Course"<<setw(10)<<"Grade"<<endl;
cout<<right<<setw(26)<<"Points"<<setw(11)<<"Average"<<setw(10)<<"Average"<<setw(10)<<"Average"<<endl;

Instead of showing up the letter grades, everytime the program run, it will come up with new ascii like weird character. Any help would be much appreciated! Thanks

[restrictment]

a lot of uninitialized variables O.o

[amishraa]

a lot of uninitialized variables O.o

I even tried this
courseavg = (prog1+prog2+prog3+prog4+prog5+test1+test2)/7;

but.. still got weird characters for grade.
Everything else works just fine as far as it goes with showing up the right numbers except the grade letter!

[restrictment]

well..don't you need to ask the user to input numbers so the program can calculate the result? Right now it looks as though your just trying to add words..

[mrnutty]

hint :

int x = 0, y = 0;
int t = x + y;

is not the same as

int x, y;
int t = x + y

[amishraa]

well..don't you need to ask the user to input numbers so the program can calculate the result? Right now it looks as though your just trying to add words..

No. This is a fin fout. I have all the program and test score information saved on a notepad file where this program will be reading it from and will output the result on both screen and another output notepad file.
The program works just fine except for the grade letter.

[amishraa]

hint :

int x = 0, y = 0;
int t = x + y;

is not the same as

int x, y;
int t = x + y

I am not following you if you don't mind explaining where you see an error please.

[restrictment]

I am not following you if you don't mind explaining where you see an error please.

I think he just talking about initializing that variables. Anyway...could you include the resource file that you are using, so I can accurately test out the program? :)

As well, all of the code would be helpful, even the heading files. (yes I know that they are <iomanip>, <iostream>, <string>, etc. But it may help to just include them anyway.)

[amishraa]

I think he just talking about initializing that variables. Anyway...could you include the resource file that you are using, so I can accurately test out the program? :)

As well, all of the code would be helpful, even the heading files. (yes I know that they are <iomanip>, <iostream>, <string>, etc. But it may help to just include them anyway.)

#include<iostream>
#include<fstream>
#include<iomanip> 
using namespace std;

int main(){

    string first, last;
    int prog1, prog2,prog3,prog4, prog5, test1, test2;
    int totalpts, progavg, testavg, courseavg;
    char grade;

    ifstream fin;
    ofstream fout;

    fin.open("students.txt");
    fout.open("output.txt");

    if(!fin){
             cout<<"Input Failure"<<endl;
             system("pause");
             return 1;
             } //end of error check
    if(!fout){
              cout<<"Output Failure"<<endl;
              system("pause");
              return 1;
}

    cout<<"Press any key to read input and calculate the grades of all students"<<endl;

    cin.get(); //waits for the user to press any key 

    cout<<"1234567890123456789012345678901234567890123456789012345678901234567890"<<endl;
    cout<<"======================================================================"<<endl;          
    cout<<left<<setw(20)<<"Student Name"<<setw(10)<<"Total"<<setw(10)<<"Program"<<setw(10)<<"Test"<<setw(10)<<"Course"<<setw(10)<<"Grade"<<endl;
    cout<<right<<setw(26)<<"Points"<<setw(11)<<"Average"<<setw(10)<<"Average"<<setw(10)<<"Average"<<endl;
    cout<<"----------------------------------------------------------------------"<<endl;

    fout<<"======================================================================"<<endl;          
    fout<<left<<setw(20)<<"Student Name"<<setw(10)<<"Total"<<setw(10)<<"Program"<<setw(10)<<"Test"<<setw(10)<<"Course"<<setw(10)<<"Grade"<<endl;
    fout<<right<<setw(26)<<"Points"<<setw(11)<<"Average"<<setw(10)<<"Average"<<setw(10)<<"Average"<<endl;
    fout<<"----------------------------------------------------------------------"<<endl;                            

    while(fin){
    fin>>first>>last>>prog1>>prog2>>prog3>>prog4>>prog5>>test1>>test2;

    totalpts = (prog1+prog2+prog3+prog4+prog5+test1+test2);
    progavg = (prog1+prog2+prog3+prog4+prog5)/5;
    testavg = (test1+test2)/2;
    courseavg = (progavg+testavg)/2;

    if (courseavg >=90 )grade='A';
    else if (courseavg <= 89 )grade='B';
    else if (courseavg <=79 )grade='C';
    else grade='F';

    cout<<fixed<<showpoint<<setprecision(2);
    cout<<left<<setw(20)<<first+" "+last<<setw(10)<<totalpts<<setw(10)<<progavg<<setw(10)<<testavg<<setw(10)<<courseavg<<setw(10)<<grade<<endl;
    fout<<left<<setw(20)<<first+" "+last<<setw(10)<<totalpts<<setw(10)<<progavg<<setw(10)<<testavg<<setw(10)<<courseavg<<setw(10)<<grade<<endl;
    if(fin.peek()=='\n')fin.ignore();

    }//end of fin controlled while
    cout<<"======================================================================"<<endl;
    fout<<"======================================================================"<<endl;
    fin.close();
    fout.close(); 

    system("pause");
    return 0;
}//end of main

Ensure the following data is saved as a txt file to the same folder where the compiler file is located:

John Doe 95 89 94 88 98 92 90
Jack Black 67 77 72 88 86 89 85
Dan Snyder 88 65 78 88 86 85 93
Sarah Peets 94 78 89 98 93 81 87
David McGregor 76 86 93 91 75 90 76
John Anderson 89 92 95 66 58 84 90
Robert Blake 85 93 84 92 90 75 94

[amishraa]

like try changing Robert Blake's numbers to even lower values
65 93 64 92 60 65 94

then the course avg comes out 76 but the letter grade still shows B

so i'm sure == is used instead of = because we don't want to assign the grade to letters but simply state that it is equal to the letters.
Only problem is the letter are showing in weird characters.. and I can't for the sake of my life figure it out!! :P

[amishraa]

hmm.. it seems to work by putting in and statement.
if (courseavg >=90 )grade='A';
else if (courseavg >= 80 && courseavg <= 89)grade='B';
else if (courseavg >= 60 && courseavg <= 79)grade='C';
else grade='F';

but still I am little hesitant on using = instead of ==
:/