Member Avatar for quintoncoert

can someone please tell me what i am doing wrong here? My program does not print any output after the attempted bucket sort. It only prints before. It is almost as if it does not run to its end.

# include <iostream>
using std::cin;
using std::cout;
using std::endl;

# include <cmath>
using std::pow;

int determineLargest( int [], int );
int countThem( int );


int main()
{
	
	const int size = 10;
	int a[ size ] = { 12, 45, 23,78, 32, 1, 24, 58, 130, 9 };

	cout << "here begin the output\n"  << endl; 

	for ( int v = 0; v < size; v++ )
		cout << a[ v ] << " : ";

	cout << "\n" << endl;

	
	int largest;
	largest = determineLargest( a, size );
	
	int countDigit;
	countDigit = countThem( largest );	
	
	int b[ 10][ 10 ];

	//begin the radix sort
	
	for ( int y = 1; y <= countDigit; y++ )
	{
		//do thedistribution pass
		
		for ( int x = 0; x < size; x++ )
		{
			int value;
			int hold;
			double holdDivide;

			value = pow( 10.0, y );
			hold = a[ x ] % value;
			holdDivide = hold / ( value / 10 );			
			
			hold = floor( holdDivide );			
			
			b[ hold ][ x ];
		}

		//do the gathering pass
		
		int location;
		location = 0;

		for ( int r = 0; r < 10; r++ )
		{
			for ( int s = 0; s < size; s++ )
			{
				if ( b[ r ][ s ] > 0 )
				{
					a[ location ] = b[ r ][ s ];
					location = location + 1;
					b[ r ][ s ] = 0;
					
				}
			}
		}

		//end of distribution
		
	}	//end the while with the y

	//print the array
	cout << "here begin the output\n"  << endl; 

	for ( int v = 0; v < size; v++ )
		cout << a[ v ] << " : " << endl;

	return 0;
}

	

int countThem( int number2 )
{
	double multVal;
	int digits;
	int hold;
		
	multVal= 10;
	digits = 0;
	
	bool stillSmaller;
	stillSmaller = true;
	
	while ( stillSmaller == true )
	{
		hold = pow( multVal, digits);
		
		if ( hold > number2 )
			stillSmaller = false;
		else
			digits++;
	}
	
	return digits;	
}

int determineLargest( int c[], int size )
{
	int hold;
	hold = c[ 0 ];

	for ( int x = 1; x < size; x++ )
	{
		if ( c[ x ] > hold )
			hold = c[ x ];
	}

	return hold;
}
  • 2 Contributors
  • 4 Replies
  • 125 Views
  • 6 Hours Discussion Span
  • Latest Post Latest Post by quintoncoert

Recommended Answers

All 4 Replies

Member Avatar for Narue

>It is almost as if it does not run to its end.
That's exactly what's happening. Run it through your debugger and you'll probably die with an access violation.

Member Avatar for quintoncoert

Yes it does. At a simple assignment it gives an access violation( Segmentation fault ). Can you tell me what it means?

By the way. Are you not going to join the chess tournament? You once pointed out an important opening principle so I asume that you have some skill?

Member Avatar for Narue

>Can you tell me what it means?
It means you accessed memory outside of where you're supposed to. Check your indexes and make sure that they're always valid. I'd wager that they're not.

>Are you not going to join the chess tournament?
What chess tournament?

Member Avatar for quintoncoert

>Can you tell me what it means?
Do not worry about that. I just solved it. An array was not initialised. Re-assigning some of its values to another array caused errors. I do not really understand why that happens but for now it is fine.

>What chess tournament?
the one being arranged as we speak/write. Go to Geeks' Lounge. There are two chess threads. One is just ...chess... and the other one says ....chess tournament.... It is the second one. Chess Tournament.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.