Restrictions?

[shielaolid]

Hello there, can anyone help me?

i want to put a restrictions in my application form.
for example, "Please complete all the fields"

and here's my code:

<?php
		
		$posapp = $_POST['txtapplied']; 
		$fname = $_POST['txtfname']; 
		$mname = $_POST['txtmname']; 
		$lname = $_POST['txtlname']; 
		$month=$_POST['txtmonth'];
		$day=$_POST['txtday'];
		$year=$_POST['txtyear'];
		$age=$_POST['txtage'];
		$eadd=$_POST['txtemail'];
		$homenumber=$_POST['txthnum'];
		$cpnumber=$_POST['txtcpnumber'];
		$address=$_POST['txtaddress'];
		$religion=$_POST['txtreligion'];
		$birthplace=$_POST['txtbplace'];
		$height=$_POST['txtheight'];
		$weight=$_POST['txtweight'];
		$civilstatus=$_POST['txtcstatus'];
		$college=$_POST['txtcollege'];
		$course=$_POST['txtcourse'];
		$yeargrad=$_POST['txtyeargrad'];
		
		$db=mysql_connect('localhost','root','') or die ('Cannot connect to MYSQL!');
		@mysql_select_db('dbriomra') or die('Cannot connect to database');

		
		$query="INSERT INTO onlineapplication (positionapplied, firstname, middlename, lastname, month, day, year, age, emailaddress, homenumber, cellphone, address, religion, birthplace, height, weight, civilstatus, college, course, yeargrad) VALUES ('$posapp', '$fname', '$mname', '$lname', '$month', '$day', '$year', '$age', '$eadd', '$homenumber', '$cpnumber', '$address', '$religion', '$birthplace', '$height', '$weight', '$civilstatus', '$college', '$course', '$yeargrad')";

       
  //$result = mysql_query($query); 
  
  if(mysql_query($query))
        {
         header('Location: oapp_finished.php');
        }
        else
        {
         echo "<br> Problem Loading";
        }
     
       mysql_close($db);
?>

Thanks

[phorce]

You could..

if(!isset($_POST['txtapplied']))
{
    echo 'You have not completed this field';
}else{
  $posapp = $_POST['txtapplied']; 
}

Do it for all of them =)

[diafol]

I'd suggest you use client-side (js) validation - see jQuery validation for info (http://bassistance.de/jquery-plugins/jquery-plugin-validation/)

You will however have to have server-side validation.

Check to see all required fields are filled and are of the correct data type / witihin acceptable range etc.

A few ideas here: http://php.net/manual/en/filter.filters.validate.php

[shielaolid]

<?php
 
		$posapp = $_POST['txtapplied']; 
		$fname = $_POST['txtfname']; 
		$mname = $_POST['txtmname']; 
		$lname = $_POST['txtlname']; 
		$month=$_POST['txtmonth'];
		$day=$_POST['txtday'];
		$year=$_POST['txtyear'];
		$age=$_POST['txtage'];
		$eadd=$_POST['txtemail'];
		$homenumber=$_POST['txthnum'];
		$cpnumber=$_POST['txtcpnumber'];
		$address=$_POST['txtaddress'];
		$religion=$_POST['txtreligion'];
		$birthplace=$_POST['txtbplace'];
		$height=$_POST['txtheight'];
		$weight=$_POST['txtweight'];
		$civilstatus=$_POST['txtcstatus'];
		$college=$_POST['txtcollege'];
		$course=$_POST['txtcourse'];
		$yeargrad=$_POST['txtyeargrad'];
 
		$db=mysql_connect('localhost','root','') or die ('Cannot connect to MYSQL!');
		@mysql_select_db('dbriomra') or die('Cannot connect to database');
 
 
		$query="INSERT INTO onlineapplication (positionapplied, firstname, middlename, lastname, month, day, year, age, emailaddress, homenumber, cellphone, address, religion, birthplace, height, weight, civilstatus, college, course, yeargrad) VALUES ('$posapp', '$fname', '$mname', '$lname', '$month', '$day', '$year', '$age', '$eadd', '$homenumber', '$cpnumber', '$address', '$religion', '$birthplace', '$height', '$weight', '$civilstatus', '$college', '$course', '$yeargrad')";
 
 
  //$result = mysql_query($query); 
 
  if(mysql_query($query))
        {
         header('Location: oapp_finished.php');
        }
        else
        {
         echo "<br> Problem Loading";
        }
 
       mysql_close($db);

if(!isset($_POST['txtapplied']))
{
    echo 'You have not completed this field';
}else{
  $posapp = $_POST['txtapplied']; 
}
?>

like this?

[diafol]

like this?

No

You need to test before running any code not after. That's like lifting your petticoat after you've pissed.

[phorce]

Like this:

<?php
 
if(!isset($_POST['txtapplied']))
{
    echo 'You have not completed this field';
}else{
  $posapp = $_POST['txtapplied']; 
}

if(!isset($_POST['txtfname']))
{
  echo 'You have not entered your first name';
}else{
  $fname = $_POST['txtfname'];
}
// etc
		$mname = $_POST['txtmname']; 
		$lname = $_POST['txtlname']; 
		$month=$_POST['txtmonth'];
		$day=$_POST['txtday'];
		$year=$_POST['txtyear'];
		$age=$_POST['txtage'];
		$eadd=$_POST['txtemail'];
		$homenumber=$_POST['txthnum'];
		$cpnumber=$_POST['txtcpnumber'];
		$address=$_POST['txtaddress'];
		$religion=$_POST['txtreligion'];
		$birthplace=$_POST['txtbplace'];
		$height=$_POST['txtheight'];
		$weight=$_POST['txtweight'];
		$civilstatus=$_POST['txtcstatus'];
		$college=$_POST['txtcollege'];
		$course=$_POST['txtcourse'];
		$yeargrad=$_POST['txtyeargrad'];
 
		$db=mysql_connect('localhost','root','') or die ('Cannot connect to MYSQL!');
		@mysql_select_db('dbriomra') or die('Cannot connect to database');
 
 
		$query="INSERT INTO onlineapplication (positionapplied, firstname, middlename, lastname, month, day, year, age, emailaddress, homenumber, cellphone, address, religion, birthplace, height, weight, civilstatus, college, course, yeargrad) VALUES ('$posapp', '$fname', '$mname', '$lname', '$month', '$day', '$year', '$age', '$eadd', '$homenumber', '$cpnumber', '$address', '$religion', '$birthplace', '$height', '$weight', '$civilstatus', '$college', '$course', '$yeargrad')";
 
 
  //$result = mysql_query($query); 
 
  if(mysql_query($query))
        {
         header('Location: oapp_finished.php');
        }
        else
        {
         echo "<br> Problem Loading";
        }
 
       mysql_close($db);
?>

I'd also do further checks, this is just an example =)

[diafol]

A nice-looking PHP validation library here:

http://www.benjaminkeen.com/software/php_validation/

It may be overkill and I haven't tried it, but it resembles a js validation library that I used to use a while ago. May be worth a look - especially if you have a large number of fields to check. Creating a custom test for every single field is tiresome.

[shielaolid]

Phorce, i tried it, but it's not working, but it is still adding in the database even if its null.

[shielaolid]

A nice-looking PHP validation library here:

http://www.benjaminkeen.com/software/php_validation/

It may be overkill and I haven't tried it, but it resembles a js validation library that I used to use a while ago. May be worth a look - especially if you have a large number of fields to check. Creating a custom test for every single field is tiresome.

Well thanks ardav, i will check it :)

[mikulucky]

I think you would be better off using JQuery to check the form before you pass it to the PHP script. It is better design, easier coding and generally better all round.