find error

[Shikha_1]

 Following function implements a way to find all the indices of a given $needle in $haystack. There is at least one bug in the implementation. Find and fix the bug(s).
<?php
function findAllIndices($haystack, $needle) {
  $indices = array();
  while ($index = strpos($haystack, $needle)) $indices[] = $index;
  return $indices;
}

[Szabi Zsoldos]

I can see the errors, but this looks like it is for your homework.
Please be polite, and dont just paste the question.

[sujeet.rnc]

error in while loop...
there should be some condition so that first time some value can be given to index...

{
while (1)
{
if($index = strpos($haystack, $needle)) 
$indices[] = $index;

but it will result into infinite loop....so provide a condition according to ur problem...

[almostbob]

more effing homework, eye dee ten Tee errors

I D 10 T