Problem with reading newline and char

[Sh13]

I feel really stupid by asking such question

I have the following code

char choice;
 
while( ( choice = MenuChoice() ) != 'QUIT' )
   {
      PrintMenu();
      {
         switch (choice)
         {
        case STRING:
        case 's':
          checkInput(strings);
          break;

        case QUIT:
         break:

        default:
         break:
}
}
}



char MenuChoice(void)
{

char menuchoice;
printf("please enter:");
scanf("%c",&menuchoice;

scanf("%c", &newLine);

return menuchoice;

}

[Sh13]

When I enter 's' as an input it keeps repeating the please enter: enter until I put two 's' like ss.
Why is this happening?

[Ancient Dragon]

try fgets()

char  menuchoice[2];
printf("please enter:");
fgets(menushoice, sizeof(menuchoice), stdin);
return menuchoice[0];

[Sh13]

Thanks its much better. But when I put 4 for QUIT as mentioned in while statement, it will keep asking me for input/

[Ancient Dragon]

how is 'QUIT' defined ? Your compiler should have generated an error on that line.

[Sh13]

QUIT was defined as 3. Do I have to define as an character also like #define QUIT q

[Ancient Dragon]

if QUIT is defined like this: #define QUIT 3 Then while( ( choice = MenuChoice() ) != 'QUIT' ) will not work. You have to make two changes
1) QUIT should be defined as '3'
2) The while loop should be changed as shown below

#define QUIT   '3'
<snip>
while( ( choice = MenuChoice() ) != QUIT )

>>But when I put 4 for QUIT
You entered the wrong value -- should be 3 not 4

[Sh13]

Ok thanks. But what if user is entering character as an input, like

please enter: q

[Ancient Dragon]

Then redefine QUIT as 'q'

[Sh13]

Alright , thanks.