C# and SQL server 2008 DateTime

This is 22nd post and yet your code is not surrounded with BB code tags.

Can I see your source code and also table structure?

sqlstring = "INSERT INTO EmployeeDetails(EmployeeId,Title,FirstName,MiddleName,Surname,DOB,Age,Nationality,NINO,PicPath,HousePhoneNo,MobileNo,Email,Other,HouseName,Address1,Address2,City,County,PostCode,Country)" + 
                    "VALUES(" +
                    "'"+ this.txtEmployeeIdHidden.Text+"'," +
                    "'" + this.cmbEmployeeTitle.Text + "'," +
                    "'" + this.cmbEmployeeFirstName.Text + "'," +
                   "' ',' ',"+
                    this.dtpDOB.Value.Date.ToShortDateString() + 
                    "," + this.txtEmployeeAge.Text + "," +
                    "'" + this.txtEmployeeNationality.Text + "'," +
                    "'" + this.txtEmployeeNINO.Text + "'," +
                    "'" + filepath + "'," +
                    "'" + this.txtBxHousePhoneNo.Text + "'," +
                    "'" + this.txtBxMobile.Text + "'," +
                    "'" + this.txtBxEmail.Text + "'," +
                    "'" + this.txtBxOther.Text + "'," +  
                    "'" + this.txtBxHouseNum.Text + "'," +
                    "'" + this.txtBxAddress1.Text + "'," +
                    "'" + this.txtBxAddress2.Text + "'," +
                    "'" + this.txtBxCity.Text + "'," +
                    "'" + this.txtBxCounty.Text + "'," +
                    "'" + this.txtBxPostcode.Text + "'," +
                    "'" + this.txtBxCountry.Text + "'" +
                    ")";

Rest is working fine, however , DOB cannot be inserted the format for which is datetime as i mentioned earlier.

sorry about the code tags, hope this is fine now

thanks in advance

Sarah

Date must be surrounded by single quotes.

...,'"+   this.dtpDOB.Value.Date.ToShortDateString() + "'," .....

Thanks a lot , but when i tried, it came up with a message box saying
"The conversion of a varchar datatype to a datetime datatype resulted in an out-of-range value "

What should i do now?

Change the datatype of DOB to DateTime in a table EmployeeDetails.

it is DateTime already , but still doesnt work

Your table's columns 6th has DateTime datatype (its not a smalldatetime) - So,

Try this

...,'"+   this.dtpDOB.Value + "'," .....

Your table's columns 6th has DateTime datatype (its not a smalldatetime) - So,

Try this

...,'"+   this.dtpDOB.Value + "'," .....

I have tried this, but it does not work either and says error near '00' i believe it is taking time with it and when i use ToshortDateString() it comes up with the same error as before - the string conversion.

And it is datetime (small letters) i have double checked, i have tried DateTime but its not there

thanks for your help in advance

Did you change the datetimepicker's format? If so, know us the format.

PS: To test your application remove datetimepicker and use textbox (date format must be mm-dd-yyyy).

Please see thread http://www.daniweb.com/forums/thread191241.html as you are having the same issue. Use parameters when you build your query. Building queries with string values is dangerous because the user could potentially escape the input and write raw TSQL, in addition it hurts performance.

Do something like:

private void simpleButton1_Click(object sender, EventArgs e)
    {
      const string query = "Insert Into aTable (aString, aDateTime) Values (@aString, @aDateTime)";
      const string connStr = @"Data Source=apex2006sql;Initial Catalog=DB;Integrated Security=True;";
      using (SqlConnection conn = new SqlConnection(connStr))
      {
        conn.Open();
        using (SqlCommand cmd = new SqlCommand(query, conn))
        {
          string s1 = "abc123";
          DateTime dtNow = DateTime.Now;
          cmd.Parameters.Add(new SqlParameter(@"aString", SqlDbType.VarChar)).Value = s1;
          cmd.Parameters.Add(new SqlParameter(@"aDateTime", SqlDbType.DateTime)).Value = dtNow;
          cmd.ExecuteNonQuery();
        }
        conn.Close();
      }
    }

Thanks very much, your advice led me to the solution, i have tested it with one of my tables hopefully all will work now, thanks once again, however, the @ didnt work and i had to use '?' which i belive could be the case witl Oledb
please correct me if i am wrong, the problem might have been caused by oledb before, however, your advice of using parameters and solution solved the problem as i changed sql to oledb and used parameters.

http://groups.google.com/group/DotNetDevelopment/browse_thread/thread/e9436a2d5fa10426

i followed the above given link, and managed it fine,

Thanks once again

Yes OleDb can used ?Parameters and I believe ODBC uses ? without name and relies on the order which they appear. I try to stay away from those drivers as much as possible so i'm not sure.

Is there a specific reason you are using OleDb for SQL2008? I would highly recommend using a native driver.

For my previous project i used the connection class which used the oledb and i just used that class to just reuse the code and basically use the .udl so that it will be easier, not a parrticular reason behind using oledb instead of SQL , if i wud have know that this would have taken my time that i wud have spent this time on making a SQLConnection class. well will learn from mistakes :)

yes they are in particular order and i am not pretty sure whether this is good practice to use ?,?,? when you have so many parameters to pass, well in this short period of time i will have to do whatever i can, i am afraid, i dont knw how it cud be used professionally.

i dont knw much about drivers

thanks once again