Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: class destructor accessing another class instance while destructing

i am sorry, this:

SecClass :: SecClass( MainClass nMainClass )

was meant to be this:

SecClass :: SecClass( MainClass *nMainClass )

i already have the assigment constructor, as for the copy constuctor, not(because i don't need it). in the SecClass constructor it was meant to pass the address of the MainClass, so the SecClass can access MainClass object and functions

and as for the crash, i am very sure that it crashes when the SecClass tryes to access on member of the MainClass after calling the MainClass destructor, i used breakpoints to test this...

Edit: the real code is a lot more complex, this was just an example witch i used to express my problem easy

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
class destructor accessing another class instance while destructing

i know you cannot understand anything from the title and i am sorry but i don't know how to say it because it's a little complicated, so i won't give details of my problem, i hope you can understand from the code

classB.h:

#ifndef CLASSB_H
#define CLASSB_H

class MainClass;      // so we can declare a pointer of class B

class SecClass
{
public:
MainClass *m_MainClass;

SecClass( );
~SecClass( );
};

classB.cpp

#include "classB.h"
#include "classA.h"

//
// A
//

SecClass :: SecClass( MainClass nMainClass )
{
    m_MainClass = nMainClass;
}

SecClass :: ~SecClass( )
{
    m_MainClass->someFunct( );
}

classA.h:

#ifndef CLASSA_H
#define CLASSA_H

class SecClass;      // so we can declare a pointer of class B

class MainClass
{
public:
SecClass *m_SecClass;
int m_ID;

MainClass( );
~MainClass( );
bool Update( );
void someFunct( ) { }
};

#endif

classA.cpp

#include <iostream>
#include "classA.h"
#include "classB.h"

//
// A
//

MainClass :: MainClass( )
{
    m_SecClass = new SecClass( this );
}

MainClass :: ~MainClass( )
{
    delete m_SecClass;
}

bool MainClass :: Update( )
{
    // do stuff...
    
    if( ... )
        return true;

    return false;
}

void main( )
{
    MainClass *gMainClass = new MainClass( );
    
    while( gMainClass->Update( ) )
    {
        // main program loop
    }

    delete gMainClass;    // this will crash
}

so, i'll explain
MainClass creates a new instance of a SecClass
The SecClass creates a pointer to the main class( to access some funct/values )
when the main class destructor …

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
presentation of myself

hi, i am new to this forum so i made this post for presenting myself
oh, and for those who would say that i registered about 3 years ago, i must say that when i registere, i didn't intend to be active on forum, i registered only to put one question, witch is lame -_-( i hope you can forgive me ), now i am thinking to frequently visit this forum

so, i am 16 years old, i like programming( but i don't even think about learning other programming language than C++ :D ) and i am willful to learn as much as i can

i started programing by editting a source code downloaded from the inthernet because i wanted to know how exacty the program worked and to change commands name, making them shorter ( i know, i am lazy :D ) and i began to learn more and more by codding...

at last, i ended up learning online from some tutorials and a PDF document
now i have the basig knowladge of the most important aspects of c++, more specifically, object oriented programming.

in the near future i am willing to continue by learning how to develope a chat programm ( client/server ) through sockets.

thx for the patiance accorded and i am sorry for this long post

Say Hello!
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

man sry for disturbing...i have fount a readme file in the directory where is my program instaled that tells you how to compile it...
thx for all

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

dont rlly know...told ya i am noob in this thing

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

well this is the entire project:...

and thx again for your help :)

ghost.zip (1298.17 KB)
Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

he told me to post the whole program so he can try to compile it...welll the whole programe has 18MB

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

i have only edited the game.cpp(GhostOne/ghost/game.cpp) file and the game_base.cpp(GhostOne/ghost/game_base.cpp)

also this program its not made by me...i have only downloaded and tried to edit it

and thx for help by the way

i cannot post the file....
Invalid Post specified. If you followed a valid link, please notify the administrator
this is what tells me after i attach file ...i think thi file size its too big (18MB)

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

i found out how to compile in microsoft visual c++ expres edition but now i have another problem....i cannot compile/build any file becose gives me this error :


1>------ Build started: Project: ghost, Configuration: Debug Win32 ------
1>Embedding manifest...
1>mt.exe : general error c10100b1: Failed to load file "..\Debug\ghost.exe". The system cannot find the path specified.
1>Build log was saved at "file://c:\Dragos\Project\ghost\ghost\Debug\BuildLog.htm"
1>ghost - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
anyway....if i tri to compile the original game.cpp file gives me the same error...so i think my visual c++ misses 1 file
if that isnt the problem tell me what is and how to resolve it pls

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
Re: i am trying to compile an edited cpp file

yea i know in microsoft visual studio c++ expres eddition i may resolve my problems but i don't know how to compile in that program:D...please tell me how

Software Development c++
Member Avatar for dospy
dospy 51 Junior Poster in Training
i am trying to compile an edited cpp file

i have GHostOne advanced remote host bot last version but i have some problems edditting it.
when i try to compile game.cpp (edited by me) gives me a lot of errors that i cannot solv (compile.txt file)
anyway...i cannot even compile the originat cpp file cuz he gives me a lot of errors too....so i think its my C++ compiler problems
i use Dev C++ compiler
what should i do?


PS: someone told me that i shall tri to compile again after i updat my libraries...is he right?

Compiler: Default compiler

Executing  g++.exe...

g++.exe "C:\Dragos\GHostOne\ghost\game.cpp" -o "C:\Dragos\GHostOne\ghost\game.exe"    -I"C:\Dragos\Programe marpha\Dev C++\App\devcpp\lib\gcc\mingw32\3.4.2\include"  -I"C:\Dragos\Programe marpha\Dev C++\App\devcpp\include\c++\3.4.2\backward"  -I"C:\Dragos\Programe marpha\Dev C++\App\devcpp\include\c++\3.4.2\mingw32"  -I"C:\Dragos\Programe marpha\Dev C++\App\devcpp\include\c++\3.4.2"  -I"C:\Dragos\Programe marpha\Dev C++\App\devcpp\include"   -L"C:\Dragos\Programe marpha\Dev C++\App\devcpp\lib" 

In file included from C:\Dragos\GHostOne\ghost\/ghost.h:27,

                 from C:\Dragos\GHostOne\ghost\game.cpp:26:

C:\Dragos\GHostOne\ghost\/ms_stdint.h:33:2: #error "Use this header only with Microsoft Visual C++ compilers!"

In file included from C:\Dragos\GHostOne\ghost\/ghost.h:27,

                 from C:\Dragos\GHostOne\ghost\game.cpp:26:

C:\Dragos\GHostOne\ghost\/ms_stdint.h:69: error: conflicting declaration 'typedef char int8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:27: error: 'int8_t' has a previous declaration as `typedef signed char int8_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:69: error: declaration of `typedef char int8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:27: error: conflicts with previous declaration `typedef signed char int8_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:69: error: declaration of `typedef char int8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:27: error: conflicts with previous declaration `typedef signed char int8_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:71: error: conflicting declaration 'typedef long int int32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:31: error: 'int32_t' has a previous declaration as `typedef int int32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:71: error: declaration of `typedef long int int32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:31: error: conflicts with previous declaration `typedef int int32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:71: error: declaration of `typedef long int int32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:31: error: conflicts with previous declaration `typedef int int32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:75: error: conflicting declaration 'typedef long unsigned int uint32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:32: error: 'uint32_t' has a previous declaration as `typedef unsigned int uint32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:75: error: declaration of `typedef long unsigned int uint32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:32: error: conflicts with previous declaration `typedef unsigned int uint32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:75: error: declaration of `typedef long unsigned int uint32_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:32: error: conflicts with previous declaration `typedef unsigned int uint32_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:89: error: conflicting declaration 'typedef int8_t int_fast8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:50: error: 'int_fast8_t' has a previous declaration as `typedef char int_fast8_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:89: error: declaration of `typedef int8_t int_fast8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:50: error: conflicts with previous declaration `typedef char int_fast8_t'

C:\Dragos\GHostOne\ghost\/ms_stdint.h:89: error: declaration of `typedef int8_t int_fast8_t'

C:/Dragos/Programe marpha/Dev C++/App/devcpp/include/stdint.h:50: error: conflicts with previous declaration `typedef char int_fast8_t'



C:\Dragos\GHostOne\ghost\game.cpp:52:32: boost/filesystem.hpp: No such file or directory

C:\Dragos\GHostOne\ghost\game.cpp:53:27: boost/regex.hpp: No such file or directory

C:\Dragos\GHostOne\ghost\game.cpp:55: error: `boost' has not been declared

C:\Dragos\GHostOne\ghost\game.cpp:55: error: expected namespace-name before ';' token

C:\Dragos\GHostOne\ghost\game.cpp:55: error: `<type error>' is not a namespace



C:\Dragos\GHostOne\ghost\game.cpp: In member function `virtual bool CGame::Update(void*, void*)':

C:\Dragos\GHostOne\ghost\game.cpp:353: error: no matching function for call to `CLanguage::HasPlayedDotAGamesWithThisBot2(std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string)'

C:\Dragos\GHostOne\ghost\/language.h:118: note: candidates are: std::string CLanguage::HasPlayedDotAGamesWithThisBot2(std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string, std::string)



C:\Dragos\GHostOne\ghost\game.cpp:3137:30: warning: multi-character character constant

C:\Dragos\GHostOne\ghost\game.cpp: In member function `virtual void CGame::EventPlayerBotCommand(CGamePlayer*, std::string, std::string)':

C:\Dragos\GHostOne\ghost\game.cpp:3137: warning:
/*

   Copyright [2008] [Trevor Hogan]

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.

   CODE PORTED FROM THE ORIGINAL GHOST PROJECT: http://ghost.pwner.org/

*/

//#include "stdio.h"
//#include "stdlib.h"
#ifdef WIN32
#include "dirent.h"
#endif
#include "ghost.h"
#include "util.h"
#include "config.h"
#include "language.h"
#include "socket.h"
#include "ghostdb.h"
#include "bnet.h"
#include "map.h"
#include "packed.h"
#include "savegame.h"
#include "replay.h"
#include "gameplayer.h"
#include "gameprotocol.h"
#include "game_base.h"
#include "game.h"
#include "stats.h"
#include "statsdota.h"
#include "statsw3mmd.h"

#include <cmath>
#include <string.h>
#include <time.h>
#ifdef WIN32
#include <windows.h>
#endif

#include <boost/filesystem.hpp>
#include <boost/regex.hpp>

using namespace boost :: filesystem;

//
// sorting classes
//

class CGamePlayerSortAscByPing
{
public:
	bool operator( ) ( CGamePlayer *Player1, CGamePlayer *Player2 ) const
	{
		return Player1->GetPing( false ) < Player2->GetPing( false );
	}
};

class CGamePlayerSortDescByPing
{
public:
	bool operator( ) ( CGamePlayer *Player1, CGamePlayer *Player2 ) const
	{
		return Player1->GetPing( false ) > Player2->GetPing( false );
	}
};

//
// CGame
//

CGame :: CGame( CGHost *nGHost, CMap *nMap, CSaveGame *nSaveGame, uint16_t nHostPort, unsigned char nGameState, string nGameName, string nOwnerName, string nCreatorName, string nCreatorServer ) : CBaseGame( nGHost, nMap, nSaveGame, nHostPort, nGameState, nGameName, nOwnerName, nCreatorName, nCreatorServer )
{
	m_DBBanLast = NULL;
	m_DBGame = new CDBGame( 0, string( ), m_Map->GetMapPath( ), string( ), string( ), string( ), 0 );

	if( m_Map->GetMapType( ) == "w3mmd" )
		m_Stats = new CStatsW3MMD( this, m_Map->GetMapStatsW3MMDCategory( ) );
	else if( m_Map->GetMapType( ) == "dota" )
		m_Stats = new CStatsDOTA( this );
	else
		m_Stats = NULL;

	m_CallableGameAdd = NULL;

	m_GameOverTime = 0;
	m_GameLoadedTime = 0;
	m_Server = nCreatorServer;
}

CGame :: ~CGame( )
{
	if( m_CallableGameAdd && m_CallableGameAdd->GetReady( ) )
	{
		if( m_CallableGameAdd->GetResult( ) > 0 )
		{
			CONSOLE_Print( "[GAME: " + m_GameName + "] saving player/stats data to database" );

			// store the CDBGamePlayers in the database

			for( vector<CDBGamePlayer *> :: iterator i = m_DBGamePlayers.begin( ); i != m_DBGamePlayers.end( ); i++ )
				m_GHost->m_Callables.push_back( m_GHost->m_DB->ThreadedGamePlayerAdd( m_CallableGameAdd->GetResult( ), (*i)->GetName( ), (*i)->GetIP( ), (*i)->GetSpoofed( ), (*i)->GetSpoofedRealm( ), (*i)->GetReserved( ), (*i)->GetLoadingTime( ), (*i)->GetLeft( ), (*i)->GetLeftReason( ), (*i)->GetTeam( ), (*i)->GetColour( ) ) );

			// store the stats in the database

			if( m_Stats )
			{
				m_Stats->Save( m_GHost, m_GHost->m_DB, m_CallableGameAdd->GetResult( ) );
				if (m_GHost->DBType == "mysql")
				if (m_GHost->m_UpdateDotaScoreAfterGame)
				{
					string formula = m_GHost->m_ScoreFormula;
					string mingames = m_GHost->m_ScoreMinGames;
					m_PairedCalculateScores.push_back( PairedCalculateScores( m_OwnerName, m_GHost->m_DB->ThreadedCalculateScores( formula, mingames ) ) );
				}
				else
				{
#ifdef WIN32
					if (m_GHost->m_UpdateDotaEloAfterGame)
						if (m_GHost->DBType == "mysql") 
						{
							system("update_dota_elo.exe");
						}
#endif
				}
			}
		}
		else
			CONSOLE_Print( "[GAME: " + m_GameName + "] unable to save player/stats data to database" );

		m_GHost->m_DB->RecoverCallable( m_CallableGameAdd );
		delete m_CallableGameAdd;
		m_CallableGameAdd = NULL;
	}

	for( vector<PairedBanCheck> :: iterator i = m_PairedBanChecks.begin( ); i != m_PairedBanChecks.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedBanAdd> :: iterator i = m_PairedBanAdds.begin( ); i != m_PairedBanAdds.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedRanks> :: iterator i = m_PairedRanks.begin( ); i != m_PairedRanks.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedCalculateScores> :: iterator i = m_PairedCalculateScores.begin( ); i != m_PairedCalculateScores.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedSafeAdd> :: iterator i = m_PairedSafeAdds.begin( ); i != m_PairedSafeAdds.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedSafeRemove> :: iterator i = m_PairedSafeRemoves.begin( ); i != m_PairedSafeRemoves.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedGPSCheck> :: iterator i = m_PairedGPSChecks.begin( ); i != m_PairedGPSChecks.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<PairedDPSCheck> :: iterator i = m_PairedDPSChecks.begin( ); i != m_PairedDPSChecks.end( ); i++ )
		m_GHost->m_Callables.push_back( i->second );

	for( vector<CDBBan *> :: iterator i = m_DBBans.begin( ); i != m_DBBans.end( ); i++ )
		delete *i;

	delete m_DBGame;

	for( vector<CDBGamePlayer *> :: iterator i = m_DBGamePlayers.begin( ); i != m_DBGamePlayers.end( ); i++ )
		delete *i;

	delete m_Stats;

	// it's a "bad thing" if m_CallableGameAdd is non NULL here
	// it means the game is being deleted after m_CallableGameAdd was created (the first step to saving the game data) but before the associated thread terminated
	// rather than failing horribly we choose to allow the thread to complete in the orphaned callables list but step 2 will never be completed
	// so this will create a game entry in the database without any gameplayers and/or DotA stats

	if( m_CallableGameAdd )
	{
		CONSOLE_Print( "[GAME: " + m_GameName + "] game is being deleted before all game data was saved, game data has been lost" );
		m_GHost->m_Callables.push_back( m_CallableGameAdd );
	}
}

bool CGame :: Update( void *fd, void *send_fd )
{
	// show score of 
	if (m_ShowScoreOf!="")
	{
//		CONSOLE_Print( "[GAME: " + m_GameName + "] checking score for "+ m_ShowScoreOf );		
		m_PairedDPSChecks.push_back( PairedDPSCheck( "%", m_GHost->m_DB->ThreadedDotAPlayerSummaryCheck( m_ShowScoreOf, m_GHost->m_ScoreFormula, m_GHost->m_ScoreMinGames ) ) );
		m_ShowScoreOf=string();
	}
	
	// update callables

	for( vector<PairedBanCheck> :: iterator i = m_PairedBanChecks.begin( ); i != m_PairedBanChecks.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			CDBBan *Ban = i->second->GetResult( );

			if( Ban )
				SendAllChat( m_GHost->m_Language->UserWasBannedOnByBecause( i->second->GetServer( ), i->second->GetUser( ), Ban->GetDate( ), Ban->GetAdmin( ), Ban->GetReason( ) ) );
			else
				SendAllChat( m_GHost->m_Language->UserIsNotBanned( i->second->GetServer( ), i->second->GetUser( ) ) );

			m_GHost->m_DB->RecoverCallable( i->second );
			delete i->second;
			i = m_PairedBanChecks.erase( i );
		}
		else
			i++;
	}

	for( vector<PairedBanAdd> :: iterator i = m_PairedBanAdds.begin( ); i != m_PairedBanAdds.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			if( i->second->GetResult( ) )
			{
				for( vector<CBNET *> :: iterator j = m_GHost->m_BNETs.begin( ); j != m_GHost->m_BNETs.end( ); j++ )
				{
					if( (*j)->GetServer( ) == i->second->GetServer( ) )
						(*j)->AddBan( i->second->GetUser( ), i->second->GetIP( ), i->second->GetGameName( ), i->second->GetAdmin( ), i->second->GetReason( ) );
				}

//				SendAllChat( m_GHost->m_Language->PlayerWasBannedByPlayer( i->second->GetServer( ), i->second->GetUser( ), i->first ) );
			}

			m_GHost->m_DB->RecoverCallable( i->second );
			delete i->second;
			i = m_PairedBanAdds.erase( i );
		}
		else
			i++;
	}

	for( vector<PairedRanks> :: iterator i = m_PairedRanks.begin( ); i != m_PairedRanks.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			string Scores = i->second->GetResult();
			if (Scores.length()>160)
				Scores = Scores.substr(0,160);
			SendAllChat(Scores);

			m_GHost->m_DB->RecoverCallable( i->second );
			delete i->second;
			i = m_PairedRanks.erase( i );
		}
		else
			i++;
	}

	for( vector<PairedCalculateScores> :: iterator i = m_PairedCalculateScores.begin( ); i != m_PairedCalculateScores.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			bool ok = i->second->GetResult();
			if (ok)
				SendAllChat("Scores have been calculated");

			m_GHost->m_DB->RecoverCallable( i->second );
			delete i->second;
			i = m_PairedCalculateScores.erase( i );
		}
		else
			i++;
	}

	for( vector<PairedSafeAdd> :: iterator i = m_PairedSafeAdds.begin( ); i != m_PairedSafeAdds.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			if( i->second->GetResult( ) )
			{
				for( vector<CBNET *> :: iterator j = m_GHost->m_BNETs.begin( ); j != m_GHost->m_BNETs.end( ); j++ )
				{
					if( (*j)->GetServer( ) == i->second->GetServer( ) )
						(*j)->AddSafe( i->second->GetUser( ));
				}
				SendAllChat(m_GHost->m_Language->AddedPlayerToTheSafeList(i->second->GetUser( )));
			} else
				SendAllChat("Cannot add"+i->second->GetUser( )+" to safelist.Close the database.");

			m_GHost->m_DB->RecoverCallable( i->second );
			delete i->second;
			i = m_PairedSafeAdds.erase( i );
		}
		else
			i++;
	}

	for( vector<PairedSafeRemove> :: iterator i = m_PairedSafeRemoves.begin( ); i != m_PairedSafeRemoves.end( ); )
	{
		if( i->second->GetReady( ) )
		{
			if( i->second->GetResult( ) )
			{
				for( vector<CBNET *> :: iterator j = m_GHost->m_BNETs.begin( ); j != m_GHost->m_BNETs.end( ); j++ )
				{
					if( (*j)->GetServer( ) == i->second->GetServer( ) )
						(*j)->RemoveSafe( i->second->GetUser( )
Software Development c++