HELLP me FIX this CODE.. IF-ELSE

Question

0

#include <iostream>
using namespace std;
int main ()
{
    int R,G,Y;
    int r,g,y;
    int a;

    cout<<"enter your input"<<endl;
    cin>>a;

    if (a==R||r)
    {
        cout<<"please stop"<<endl;
    }
    else 
        if (a==G||g)
        {
        cout<<"you can go"<<endl;
        }

        else if (a==Y||y)
        {
        cout<<"prepare to stop"<<endl;
        }
        else 
        cout<<"Out of range"<<endl;

return 0;
}

c++

Edited 4 Years Ago by Reverend Jim: Fixed formatting

5

Contributors

5

Replies

6

Views

7 Years

Discussion Span

7 Years Ago

Last Post by renovat0

This Question has been Answered

c++

wildgoose 420 · Answer 1 · 2009-08-09T10:08:18+00:00

else if (a==Y||y)

What exactly are you trying to do?
else if (a == 1 ) ???

You really need more description of what you're trying to do!

R,G,Y, r,g,y aren't even initialized!

jesseb07 64 · Answer 2 · 2009-08-09T10:12:08+00:00

your boolean logic is ill-formed inside of your if statements, instead of

if(a==R||r)
//etc.

it should be

if((a == R) || (a == r))
//etc.

how your first logic reads is "if a equals R or if r".
how I think you wanted your logic to read is "if a equals R or if a equals r"

but yes, as wildgoose has mentioned also: r, R, g, G, y, Y will all be the compiler default value of int, they are uninitialized thus making them unsafe for comparisons.

hope that's helpful

~J

Salem 5,138 · Answer 3 · 2009-08-09T11:40:34+00:00

if ( ReadBeforePosting() == true && PostHasCodeTags() == true ) {
  // reward OP with answers
} else {
  MoreCluesOnHowToDoBetterNextTime();
}

JameB 66 · Answer 4 · 2009-08-09T11:44:13+00:00

In C++, if you compare something like R WITHOUT any quotes, it interprets it as a variable. So, I assume that the user will enter R or r. If so, you need to check like

if (input == 'R')
{
}

or like this

if (input == "stop")
{
}

Double quotes are usually used for more than one characters but it doesn't really matter.... Also, read the post that says your boolean logic is incorrect.

renovat0 · Answer 5 · 2009-08-09T11:54:59+00:00

your boolean logic is ill-formed inside of your if statements, instead of
if(a==R||r)
//etc.
it should be
if((a == R) || (a == r))
//etc.
how your first logic reads is "if a equals R or if r".
how I think you wanted your logic to read is "if a equals R or if a equals r"

but yes, as wildgoose has mentioned also: r, R, g, G, y, Y will all be the compiler default value of int, they are uninitialized thus making them unsafe for comparisons.

hope that's helpful

~J

Thank you so much..
:D