Member Avatar for muthu1802

I got an error in ths code...
cannot implicitly convert type string to string[]....

public string[] SelectTable(String pSqlstmt)
        {
            string[] sTable;
            string str;
            if(pSqlstmt.Contains("from"))
            {
                int strlen=pSqlstmt.Length;
                int strindfrom = pSqlstmt.IndexOf("from");
                if (pSqlstmt.Contains("where"))
                {
                    int strindwhere = pSqlstmt.IndexOf("where");
                    sTable = pSqlstmt.Substring(strindfrom, strindwhere);
                 }
                else
                {
                    sTable = pSqlstmt.Substring(strindfrom, strlen);
                    
                }
                
            }
            return sTable;
        }
Edited by kvprajapati because: Added [code] tags. For easy readability, always wrap programming code within posts in [code] (code blocks).
  • 2 Contributors
  • 1 Reply
  • 181 Views
  • 6 Hours Discussion Span
  • Latest Post Latest Post by apegram
Member Avatar for apegram

Consider this modification of your code.

public string[] SelectTable(String pSqlstmt)
        {
            string str = null; // you declared this variable before but did not use it
            if (pSqlstmt.Contains("from"))
            {
                int strlen = pSqlstmt.Length;
                int strindfrom = pSqlstmt.IndexOf("from");
                if (pSqlstmt.Contains("where"))
                {
                    int strindwhere = pSqlstmt.IndexOf("where");
                    str = pSqlstmt.Substring(strindfrom, strindwhere);
                }
                else
                {
                    str = pSqlstmt.Substring(strindfrom, strlen);
                }
            }

            if (!string.IsNullOrEmpty(str))
                return new string[] { str };

            return null;
        }

On that note, you have no else clause for the statement if (pSqlstmt.Contains("from")) , so your function may return nothing useful. I assume you're prepared for that.

Edited by apegram because: n/a
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.