Hey there! I'm new to c++ and programming in general and have a quick question to why the program below works. I had most of it completed but for hours i couldn't figure out why every time i tried to enter input for the "make" member of my dynamic structure array it would just skip over it in the program. I added the cin.get(); right before the getline(cin, carArray[i].make); and all of a sudden it worked. I guess I wanna know why the getline() was dependent on the cin.get() being present.
Any help would be greatly appreciates cause that was frustrating as hell!

#include <iostream>
#include <cstdlib>
#include <cstring>
#include <string>
using namespace std;

struct car {
    string make;
    int yearBuilt;

int main()
    cout << "How many cars would you like to catalog?" << " ";
    int numCars;
    cin >> numCars;

    car * carArray = new car[numCars];

    for (int i = 0; i < numCars; i++)
        cout << "Car " << ++i << " : ";
        cout << "\nPlease enter the make: ";
        getline(cin, carArray[i].make);
        cout << "Please enter year built: ";
        cin >> carArray[i].yearBuilt;

    cout << "\n\nHere is your Collection:  \n\n";

    for (int j = 0; j < numCars; j++)
        cout << carArray[j].yearBuilt << " " << carArray[j].make << "\n";


Edited by mike_2000_17: Fixed formatting

6 Years
Discussion Span
Last Post by Nicco

you need cin.get or cin.ignore before getline, because if there are any characters in the stream when getline is called, getline will just grab those characters instead of what you intend it to receive. If you have not entered any characters before hand into the cin stream, you wouldn't need to call cin.get or cin.ignore, but when you entered how many cars you wanted to catalog, it threw those characters into the stream.

Edited by LevyDee: n/a


Simpler version of your problem:

#include <iostream>
int main(){
 using namespace std;
 int a = 0;
 string str;
 cin >> a;
 getline(cin,str); //skipped??

the problem is when you use cin to read in a number, there is a newline that gets
stuck in the buffer, because cin disregards whitespaces and newlines. Thus that
newline is read into the string, and does not read in the user input. So to solve
this problem, you need to read the buffer to discard the newline. There are many
solutions to this. One ways is the way you found it, using cin.get. Others uses
cin.ignore and such.


Ok that makes sense. Thanks guys, now I can sleep tonight!

This article has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.