copying contents of a text file to another text file

[iwanttolearnc]

good day and a happy new year to you folks. im trying to copy the contents of one text file to another text file but i cant seem to get it right. written below is the code im using but it does not seem to work. any help please?

#include <stdio.h>
#include <conio.h>
#include <string.h>

int main (void){
    
    static const char filename[] = "file.txt";
    static const char file2name[] = "file2.txt";    
    FILE *read = fopen ( filename, "r" );
    FILE *write;
    
    char line [128];
    
    if ( read != NULL ){ 
         while ( fgets ( line, sizeof line, read ) != NULL ){
               write = fopen (file2name , "w");
               fprintf (write , line);
               fprintf (write , "\n");
               fclose (write);
               }
         fclose ( read );
         }
             
    else{
         perror ( filename ); /* why didn't the file open? */
      }
      
    getch();
    return 0;
}

[gerard4143]

Line 19...Why are you closing write here?

actually line 16...Why are you opening write here?

Try looking at the code below

#include <stdio.h>
#include <stdlib.h>

#define BSIZE 24

int main()
{
	char ch[BSIZE];
	FILE *fout;
	FILE *fin;

	if (!(fin = fopen("testfile", "r")))
	{
		fputs("could not open testfile!\n", stderr);
		exit(EXIT_FAILURE);
	}

	if (!(fout = fopen("testout", "w")))
	{
		fputs("could not open testout!\n", stderr);
		exit(EXIT_FAILURE);
	}

	while (fwrite(ch, sizeof(char), fread(ch, sizeof(char), BSIZE, fin), fout))
	{
	}

	fclose(fout);
	fclose(fin);
	return 0;
}

[iwanttolearnc]

thank you so much for taking the time to reply to my post. it turns out that i have to perform checking with the opened file first, process that data and then print to another file. ive tried applying your suggestions but it seems i cant quite get the hang of it. i get a problem regarding floats, once i print them to the file they get trash values appended. something like "àÿ" ”\Ãwp Á "

written below is the code that generates random numbers and writes it to a text file (with the trash values).

#include <stdio.h>
#include <stdlib.h>
 
#define BSIZE 24

float rand_FloatRange(float a, float b);
 
int main()
{
	char ch[BSIZE];
	char out[BSIZE];
	char newl[] = "\n";
	float randf;
	FILE *fout;
	int times;
 
	if (!(fout = fopen("testout.txt", "w")))
	{
		fputs("could not open testout!\n", stderr);
		exit(EXIT_FAILURE);
	}
 
    for (times = 0; times < BSIZE; times++){
        randf = rand_FloatRange(0.0 , 1.0);
        sprintf (out , "%f" , randf);
        fwrite  (out, sizeof(char), sizeof(out), fout);
        fwrite  ("\n" , sizeof(char) , sizeof(char) , fout);
    }   
 
	fclose(fout);
	return 0;
}

float rand_FloatRange(float a, float b)
{
return ((b-a)*((float)rand()/RAND_MAX))+a;
}

[vinayakgarg]

Hello Happy New Year
the reason why you are getting junk is that size of out is 24 and in the

int fwrite( const void *buffer, size_t size, size_t count, FILE *stream );

you are inserting 24 in 2nd arg which should be 8 in your case.

As a result 16 bytes of out are printed in file after '\0' which are junk.

So you must use strlen() function to insert correct size.

Correct code is

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define BSIZE 24

float rand_FloatRange(float a, float b);

int main()
{
	char ch[BSIZE];
	char out[BSIZE];
	char newl[] = "\n";
	float randf;
	FILE *fout;
	int times;

	if (!(fout = fopen("testout.txt", "w")))
	{
		fputs("could not open testout!\n", stderr);
		exit(EXIT_FAILURE);
	}

    for (times = 0; times < BSIZE; times++){
        randf = rand_FloatRange(0.0 , 1.0);
        sprintf (out , "%f" , randf);
        fwrite  (out, strlen(out), 1, fout);
        fwrite  ("\n" , sizeof(char) , 1, fout);
    }

	fclose(fout);
	return 0;
}

float rand_FloatRange(float a, float b)
{
return ((b-a)*((float)rand()/RAND_MAX))+a;
}

Vinayak

[iwanttolearnc]

happy new year to you too vinayak! thank you very much for replying and you are absolutely correct!

mr. gerard4143, thank you very much too!