Hello ladies and gents,

I'm trying to reverse a string when one is entered with cin.getline, so when typing for example: testing

My output should become: gnitset

Ive written this piece of code and it works but, because the string has a certain length and not the whole length of the string is neccesarly being used the part wich is not used is also being shown in my output?

How do I get rid of this?

int main()
{
	char tekst[20];

	cout<< "Put in a line of text! ";

	cin.getline(tekst, 20);

	cout<< "Reverse the string now!" <<endl;

	for (int i=0; i<sizeof tekst; i++)
		cout<< tekst [sizeof tekst-i-1];
 
	cout<<endl;
	return 0;
}

Allready tried a search on this topic, came up with four possibilities and none really was sufficient for my problem, so thanks for the help in advance ;)

Don't use the physical size of the string as your limit, use the logical size. The physical size is the size of the array while the logical size is determined by where the terminating null character is:

#include <algorithm>
#include <cstring>
#include <iostream>

using namespace std;

void sreverse(char *s)
{
  size_t begin = 0;
  size_t end = strlen(s) - 1;

  while (begin < end)
    swap(s[begin++], s[end--]);
}

int main()
{
  char s[20];

  cout<<"Enter a string: ";
  if (cin.getline(s, sizeof s)) {
    sreverse(s);
    cout<< s <<endl;
  }
}

Or alternatively, straight printing as you were doing:

#include <cstring>
#include <iostream>

using namespace std;

int main()
{
  char s[20];

  cout<<"Enter a string: ";
  if (cin.getline(s, sizeof s)) {
    for (size_t i = strlen(s) - 1; i != 0; i--)
      cout<< s[i];
    cout<< s[0] <<endl;
  }
}

Narue, I see in your example you use #include <algorithm>
I never heard of this library? I did a google search for algorithm.h and can't seem to find a listing of functions?

>I never heard of this library?
It's a handy header. Among the functions that it gives you is swap, which saves everyone from that XOR abomination that your code displayed. *shudder* At least it wasn't undefined behavior the way you wrote it. Most people try to palm off the one-liner version:

a ^= b ^= a ^= b;

Thank you very much ladies :)

Narue, ever tought of becoming a teacher, I'm certain you'd be great at it ;)

I was actually thinking that it probably did cover the swap function() which is why I did a google search for it. When I couldn't come up with a list of functions it included, I figured I'd just ask you directly. I'm going to recede back into my PHP world just about now :)

>Narue, ever tought of becoming a teacher
Yes, but if it's anything like the "tutoring" I do with the programmers working under me, I would be fired in an instant for verbal abuse. ;) It's not that I'm really that bad, it's just that people are too touchy these days.

ROFLMAO, oh those employees are so touchy these days :mrgreen:

Before I forget, thanks for the links Dani :)

This question has already been answered. Start a new discussion instead.