Problem with the built-in apply function

[wotthe2000]

Hi, i'm having some trouble using the built-in apply function. I want to take a string in an external definition then apply definitions on it which are in a class.

The code I have is:

global msgstr

def create_message(message, msgstr):
    if msgstr[0:3].upper() == 'CMD':
	return apply(message, (msgstr))
    elif msgstr[0:3].upper() == 'RSP':
	return apply(message, (msgstr))
    elif msgstr[0:3].upper() == 'IND':
	return apply(message, (msgstr))
    elif msgstr[0:3].upper() not in 'CMDRSPIND':
	print "Miscellaneous message has been found with details", msgstr
    else:
	pass


class message(object):

    def __init__(self, msgstr):
	self.msgstr = msgstr

    def getdetails(self):
	print "Type: ", msgstr[0:3]
	print "Date Stamp: ", msgstr[9:11],"/",msgstr[7:9],"/",msgstr[3:7]

I'm taking in a string, for example CMD20090114:1 which I want to apply the function getdetails on. I input:
teststr="CMD20090114:1"
m=create_message(message, teststr)
m.getdetails()
It returns an error saying global name 'msgstr' is not defined
Can someone tell me where I'm going wrong.
Thanks

[Gribouillis]

Here is how you could write this

def create_message(message, msgstr):
    if msgstr[0:3].upper() == 'CMD':
	return message(msgstr)
    elif msgstr[0:3].upper() == 'RSP':
	return message(msgstr)
    elif msgstr[0:3].upper() == 'IND':
	return message(msgstr)
    elif msgstr[0:3].upper() not in 'CMDRSPIND':
	print "Miscellaneous message has been found with details", msgstr
    else:
	pass


class message(object):

    def __init__(self, msgstr):
	self.msgstr = msgstr

    def getdetails(self):
        msgstr = self.msgstr
	print "Type: ", msgstr[0:3]
	print "Date Stamp: ", msgstr[9:11],"/",msgstr[7:9],"/",msgstr[3:7]

In the method getdetails , you don't need to access a 'global' msgstr, you need to access the member msgstr of your message instance self. Also note that you never need the apply function. It's an old fashioned python syntax. Instead of apply(func, args) you can write func(*args) , where args is a tuple or a list. If it's an explicit tuple like in apply(func, (1, 2, 3)) , you can just write func(1, 2, 3) .

[Stefano Mtangoo]

I haven't checked much, but I run error too. One thing, I see "message" in many places and don't know if it is class or variable
Anyway, my IDE complained of mixed indentation and here is corrected version

global msgstr

def create_message(message, msgstr):
    if msgstr[0:3].upper() == 'CMD':
        return apply(message, (msgstr))
    elif msgstr[0:3].upper() == 'RSP':
        return apply(message, (msgstr))
    elif msgstr[0:3].upper() == 'IND':
        return apply(message, (msgstr))
    elif msgstr[0:3].upper() not in 'CMDRSPIND':
        print "Miscellaneous message has been found with details", msgstr
    else:
        pass


class message(object):

    def __init__(self, msgstr):
        self.msgstr = msgstr

    def getdetails(self):
        print "Type: ", msgstr[0:3]
        print "Date Stamp: ", msgstr[9:11],"/",msgstr[7:9],"/",msgstr[3:7]

teststr="CMD20090114:1"
m=create_message(message, teststr)
m.getdetails()

[wotthe2000]

Thanks for the help guys, all working now!