Is the following code correct:

char * cmd="ls -l"; /* Unix command used for listing */
	char * spCmd;	 
	spCmd = strtok(cmd , " ");/* it divides the cmd in to tokens */
	execvp(spCmd[0] , spCmd);

output of this code to execute command that is written in cmd ?

Recommended Answers

All 9 Replies

char * cmd="ls -l";

This should be:

char cmd[] = "ls -l";

Are there any good solution :?:

>Are there any good solution
Yes, Dave's solution is a good one. Your code will fail because string literals can't be modified, and strtok modifies the string you pass to it. Changing cmd to an array fixes the problem.

Just in case you didn't catch it, remove the parts in red and add the parts in blue.

THank U Dave and Narue

What about


if I do so the output will be like :
Segmentation fault
any suggestions?plz

The following code works fine ,but once it reaches the last line it will not be printed why ?? any suggestions are appreciated thankx dave

char *all;
	char *res[80];
	int i=0;
	all = "ls -l";
	res[i]= strtok(all," ");
	while (res[i] != NULL){
		res[++i]= strtok(NULL," ");
 --->	   printf("Done\n");          <-- this is not executed why ??


><-- this is not executed why ??

$ man execvp

That should tell you pretty quickly what happens when execvp is called.

Thankx Narue

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.