Member Avatar for sasikrishnasamy 
Hi,
    I would like to know which closing and which if statement is more advisable and why below mentioned conditions.



Condition1:
      while(iterator.hasNext())
            {
            roDetailsVO = (RODetailsVO) iterator.next();
               callableStatement = connection.prepareCall("{call testpac.test(?,?)}");
                callableStatement.setInt(1, roDetailsVO.getInboxHdrId());
                callableStatement.setInt(2, roDetailsVO.getUserId());     
                                 callableStatement.close();
                               }
      OR

Condition2:
    while(iterator.hasNext())
            {
            roDetailsVO = (RODetailsVO) iterator.next();
               callableStatement = connection.prepareCall("{call testpac.test(?,?)}");
                callableStatement.setInt(1, roDetailsVO.getInboxHdrId());
                callableStatement.setInt(2, roDetailsVO.getUserId());     
                               }
      callableStatement.close();   // closing commonly

Condition 3 
    if(count==0)
       System.out.println(“count value is zero ”);     

Condition 4 
   if(count==0){
             System.out.println(“count value is zero ”); 
    }

Kindly share some idea about this.

Thanks,

  • 2 Contributors
  • 1 Reply
  • 138 Views
  • 1 Week Discussion Span
  • Latest Post Latest Post by aruru49

Dani AI

Generated

Short answer: which closing is "right" depends on where the statement is created. If a new CallableStatement is created inside each loop iteration, it must be closed inside that iteration. If you create one statement and reuse it for all iterations, close it once after the loop. is correct about using braces for clarity, but the advice to always close once outside the loop (as implied) can cause resource leaks if the statement is re-created each time.

Use try-with-resources (Java 7+) or finally blocks to guarantee closes. Reusing a single prepared/callable statement is usually faster (fewer round trips and server-side allocations), but only when the same SQL is executed repeatedly and the driver supports reuse. Creating a statement per iteration and closing it each time adds overhead.

Example (reuse a single statement safely):

try (CallableStatement stmt = conn.prepareCall("{call mypkg.proc(?,?)}")) {
    for (Item it : items) {
        stmt.setInt(1, it.getId());
        stmt.setInt(2, it.getUser());
        stmt.execute();
        stmt.clearParameters();
    }
}

Example (create and close per iteration):

for (Item it : items) {
    try (CallableStatement stmt = conn.prepareCall("{call mypkg.proc(?,?)}")) {
        stmt.setInt(1, it.getId());
        stmt.setInt(2, it.getUser());
        stmt.execute();
    }
}

Practical notes: always handle SQLException, avoid System.out for production (use a logger), prefer if with braces for any body you might extend later, and avoid == for boxed types (use .equals or unbox carefully). Quick checklist: close what you open, prefer try-with-resources, reuse statements when beneficial, and always use braces for maintainability.

Member Avatar for aruru49

Condition 2 and condition 4 is more appropriate.
condition 2 is because, it reduces few steps in execution. This will also increase performance.
condition 4 is because, it helps in readability, used in debugging.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.