SQL query prob.

Question

fifarulez 0 Light Poster

12 Years Ago

I can't seem to get my register page working with a password.

This is the query I executed:

CREATE TABLE dbUsers (
         id INT(10) NOT NULL AUTO_INCREMENT PRIMARY KEY,
         username VARCHAR(16) unique,
         password CHAR(16),
         email VARCHAR(25)
       );

It only registers if there is no password filled..

php

2 Contributors
29 Replies
184 Views
8 Hours Discussion Span
Latest Post 12 Years Ago Latest Post by fifarulez

All 29 Replies

stoopkid 6 Junior Poster in Training

12 Years Ago

If you're planning on storing md5 data as your password, you need to set your varchar to a higher integer. Pretty sure md5 are 30+ character strings, so change it to varchar(40) and you should be safe.

stoopkid 6 Junior Poster in Training

12 Years Ago

Post the code for your form processing

stoopkid 6 Junior Poster in Training

12 Years Ago

Try:

if(isset($_POST['username'])) {
$username = mysql_real_escape_string($_POST['username']);
} else {
echo "No username detected<br>";
}

if(isset($_POST['password'])) {
$password = mysql_real_escape_string($_POST['password']);
} else {
echo "No password detected<br>";
}

if(isset($_POST['email'])) {
$email = mysql_real_escape_string($_POST['email']);
} else {
echo "No email detected";
}

$q = "INSERT INTO `dbusers` SET `username` = '$username', `password` = '$password', `email` = '$email'";

stoopkid 6 Junior Poster in Training

12 Years Ago

The above script will check to see if the $_POST data is filled, otherwise it'll return an error. I also added the escape string function to prevent SQL injection, and try to never use raw $_POST data in your SQL queries.

stoopkid 6 Junior Poster in Training

12 Years Ago

Replace

// Fields are clear, add user to database
// Setup query
$q = "INSERT INTO `dbusers` (`username`,`password`,`email`) "
."VALUES ('".$_POST["username"]."', "
."PASSWORD('".$_POST["password"]."'), "
."'".$_POST["email"]."')";

With the script I wrote and see if that works.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

fifarulez 0 Light Poster · Answer 1 · 2011-09-06T06:28:32+00:00

I tried changing:

password CHAR(16),

to

password VARCHAR(16),

but it still won't register with a password.. does this have something to do with md5?

fifarulez 0 Light Poster · Answer 2 · 2011-09-06T06:36:55+00:00

Oh okay, some people set it to 255 I think but even with md5 on..

I cannot register if I have a password filled in..look
http://fifarulez.dyndns.org/hacks4all.wapzan.com/registration/register.php

Try anything just to test.. and you'll see..

Thanks for the quick reply though

fifarulez 0 Light Poster · Answer 3 · 2011-09-06T06:42:30+00:00

<?php
     
    // dbConfig.php is a file that contains your
    // database connection information.
    include ("dbConfig.php");
     
     
    //Input vaildation and the dbase code
    $op = isset($_GET['op']) ? $_GET['op'] : '';
    if ($op == 'reg')
    {
    $bInputFlag = false;
    foreach ( $_POST as $field )
    {
    if ($field == "")
    {
    $bInputFlag = false;
    }
    else
    {
    $bInputFlag = true;
    }
    }
    // If we had problems with the input, exit with error
    if ($bInputFlag == false)
    {
    die( "Problem with your registration info. "
    ."Please go back and try again.");
    }
     
    // Fields are clear, add user to database
    // Setup query
    $q = "INSERT INTO `dbusers` (`username`,`password`,`email`) "
    ."VALUES ('".$_POST["username"]."', "
    ."PASSWORD('".$_POST["password"]."'), "
    ."'".$_POST["email"]."')";
    // Run query
    $r = mysql_query($q);
     
    // Make sure query inserted user successfully
    if ( !mysql_insert_id() )
    {
    die("Error: User not added to database.");
    }
    else
    {
    // Redirect to thank you page.
    Header("Location: register.php?op=thanks");
    }
    } // end if
     
     
    //The thank you page
    $op = isset($_GET['op']) ? $_GET['op'] : '';
    if ($op == 'thanks')
    {
    echo "<h2> Thanks for registering!</h2> ";
    }
     
    //The web form for input ability
    else
    {
    echo "<form action=\"?op=reg\" method=\"POST\"> \n";
    echo "Username: <input name=\"username\" MAXLENGTH=\"16\"> <br /> \n";
    echo "Password: <input type=\"password\" name=\"password\" MAXLENGTH=\"16\"> <br /> \n";
    echo "Email Address: <input name=\"email\" MAXLENGTH=\"25\"> <br /> \n";
    echo "<input type=\"submit\"> \n";
    echo "</form> \n";
    }
    // EOF
    ?>

fifarulez 0 Light Poster · Answer 4 · 2011-09-06T06:50:21+00:00

Or maybe it's just this that you wanted

// Fields are clear, add user to database
// Setup query
$q = "INSERT INTO `dbusers` (`username`,`password`,`email`) "
."VALUES ('".$_POST["username"]."', "
."PASSWORD('".$_POST["password"]."'), "
."'".$_POST["email"]."')";
// Run query
$r = mysql_query($q);

Sorry, im really a newbie to this.

fifarulez 0 Light Poster · Answer 5 · 2011-09-06T06:56:31+00:00

Is there another way to set this?
Like post username, pass and email with one line? or something?

thanks

fifarulez 0 Light Poster · Answer 6 · 2011-09-06T07:13:24+00:00

Oh okay, thank you very much!

Where do I exactly insert the code?

fifarulez 0 Light Poster · Answer 7 · 2011-09-06T07:22:59+00:00

fifarulez 0 Light Poster

12 Years Ago

Wow.... it works perfectly.

stoopkid 6 Junior Poster in Training · Answer 8 · 2011-09-06T07:24:11+00:00

Glad I could help, please mark the thread as SOLVED if you could.

fifarulez 0 Light Poster · Answer 9 · 2011-09-06T07:24:24+00:00

Last thing!!!

For the login.php, it says that the information is wrong.

Is it the same lines I gotta change?

stoopkid 6 Junior Poster in Training · Answer 10 · 2011-09-06T07:27:57+00:00

Here is a basic login script I use:

'login.php'

<?php 

include('config.php');

 if(isset($_POST['username'])) {
 	$username = mysql_real_escape_string($_POST['username']);
 }
 
 if(isset($_POST['password'])) {
 	$password = mysql_real_escape_string($_POST['password']);
 }
 
 $password = md5($password);
 
$sql = "Select COUNT(*) from `users` where username = '$username' AND password = '$password'";

$result=mysql_query($sql);



//check that at least one row was returned



$rowCheck = mysql_result($result, 0);

if($rowCheck > 0) {


	$_SESSION['username'] = $username;

header ("Location: index.php");

  //we will redirect the user to another page where we will make sure they're logged in

  } else {
  //if nothing is returned by the query, unsuccessful login code goes here...

  echo 'Incorrect login name or password. Please try again.<br>';

  echo "$username - $password";

  } 

?>

fifarulez 0 Light Poster · Answer 11 · 2011-09-06T07:32:01+00:00

fifarulez 0 Light Poster

12 Years Ago

My passwords aren't in md5 though.

stoopkid 6 Junior Poster in Training · Answer 12 · 2011-09-06T07:33:52+00:00

take out the line that says $password = md5($password);

fifarulez 0 Light Poster · Answer 13 · 2011-09-06T07:39:33+00:00

Uhm....alright but I'm still having some problems
http://fifarulez.dyndns.org/hacks4all.wapzan.com/registration/login.php

which are

( ! ) Notice: Undefined variable: username in C:\wamp\www\hacks4all.wapzan.com\registration\login.php on line 14
( ! ) Notice: Undefined variable: password in C:\wamp\www\hacks4all.wapzan.com\registration\login.php on line 14

stoopkid 6 Junior Poster in Training · Answer 14 · 2011-09-06T07:44:30+00:00

You need to add a form for people to login through. All you have now is a register form, but no login form.

Set the login forms action to login.php to process the form data.

fifarulez 0 Light Poster · Answer 15 · 2011-09-06T07:59:43+00:00

I now have:

<?php
    session_start();
    // dBase file
    include "dbConfig.php";
     
    {
    //If all went right the Web form appears and users can log in
    echo "<form action=\"?op=login\" method=\"POST\">";
    echo "Username: <input name=\"username\" size=\"15\"><br />";
    echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
    echo "<input type=\"submit\" value=\"Login\">";
    echo "</form>";
    }
    ?>

I don't know how to redirect the information to the actual logger..

stoopkid 6 Junior Poster in Training · Answer 16 · 2011-09-06T08:07:42+00:00

First, put the session_start(); at the top of your dbconfig.php file, that way you won't have to reference it on every page.

<?php
    // dBase file
    include "dbConfig.php";
     
    {
    //If all went right the Web form appears and users can log in
    echo "<form action=\"login.php\" method=\"POST\">";
    echo "Username: <input name=\"username\" size=\"15\"><br />";
    echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
    echo "<input type=\"submit\" value=\"Login\">";
    echo "</form>";
    }
    ?>

fifarulez 0 Light Poster · Answer 17 · 2011-09-06T08:13:56+00:00

fifarulez 0 Light Poster

12 Years Ago

Done

fifarulez 0 Light Poster · Answer 18 · 2011-09-06T08:24:09+00:00

It looks like I can now login and logout, but there's one last thing.

Why do I get a notice?

( ! ) Notice: Undefined variable: username in C:\wamp\www\hacks4all.wapzan.com\registration\login.php on line 14

I can still login and log out.

stoopkid 6 Junior Poster in Training · Answer 19 · 2011-09-06T08:30:32+00:00

stoopkid 6 Junior Poster in Training

12 Years Ago

post your login.php code

fifarulez 0 Light Poster · Answer 20 · 2011-09-06T08:32:54+00:00

<?php
    // dBase file
    include "dbConfig.php";
     
    if(isset($_POST['username'])) {
    $username = mysql_real_escape_string($_POST['username']);
    }
     
    if(isset($_POST['password'])) {
    $password = mysql_real_escape_string($_POST['password']);
    }
     
     
    $sql = "Select COUNT(*) from `dbusers` where username = '$username' AND password = '$password'";
     
    $result=mysql_query($sql);
     
     
     
    //check that at least one row was returned
     
     
     
    $rowCheck = mysql_result($result, 0);
     
    if($rowCheck > 0) {
     
     
    $_SESSION['username'] = $username;
     
    header ("Location: index.php");
     
    //we will redirect the user to another page where we will make sure they're logged in
     
    } else {
    //if nothing is returned by the query, unsuccessful login code goes here...
     
    echo 'Incorrect login name or password. Please try again.<br>';
     
    echo "$username - $password";
     
    }
    {
    //If all went right the Web form appears and users can log in
    echo "<form action=\"?op=login\" method=\"POST\">";
    echo "Username: <input name=\"username\" size=\"15\"><br />";
    echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
    echo "<input type=\"submit\" value=\"Login\">";
    echo "</form>";
    }
    ?>

stoopkid 6 Junior Poster in Training · Answer 21 · 2011-09-06T08:36:49+00:00

Replace it with this:

<?php
    // dBase file
    include "dbConfig.php";
  if(isset($_POST['submit'])) { //if the login button is pushed
    if(isset($_POST['username'])) {
    $username = mysql_real_escape_string($_POST['username']);
    }
     
    if(isset($_POST['password'])) {
    $password = mysql_real_escape_string($_POST['password']);
    }
     
     
    $sql = "Select COUNT(*) from `dbusers` where username = '$username' AND password = '$password'";
     
    $result=mysql_query($sql);
     
     
     
    //check that at least one row was returned
     
     
     
    $rowCheck = mysql_result($result, 0);
     
    if($rowCheck > 0) {
     
     
    $_SESSION['username'] = $username;
     
    header ("Location: index.php");
     
    //we will redirect the user to another page where we will make sure they're logged in
     
    } else {
    //if nothing is returned by the query, unsuccessful login code goes here...
     
    echo 'Incorrect login name or password. Please try again.<br>';
     
    echo "$username - $password";
     
    }
    {
  } else { //show login form 
    //If all went right the Web form appears and users can log in
    echo "<form action=\"?op=login\" method=\"POST\">";
    echo "Username: <input name=\"username\" size=\"15\"><br />";
    echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
    echo "<input type=\"submit\" name=\"submit\" value=\"Login\">";
    echo "</form>";
    }
 }
    ?>

fifarulez 0 Light Poster · Answer 22 · 2011-09-06T08:41:48+00:00

( ! ) Parse error: syntax error, unexpected T_ELSE in C:\wamp\www\hacks4all.wapzan.com\registration\login.php on line 44

stoopkid 6 Junior Poster in Training · Answer 23 · 2011-09-06T08:44:32+00:00

All better

<?php
    // dBase file
    include "dbConfig.php";
    if(isset($_POST['submit'])) { //if the login button is pushed
    if(isset($_POST['username'])) {
    $username = mysql_real_escape_string($_POST['username']);
    }
     
    if(isset($_POST['password'])) {
    $password = mysql_real_escape_string($_POST['password']);
    }
     
     
    $sql = "Select COUNT(*) from `dbusers` where username = '$username' AND password = '$password'";
     
    $result=mysql_query($sql);
     
     
     
    //check that at least one row was returned
     
     
     
    $rowCheck = mysql_result($result, 0);
     
    if($rowCheck > 0) {
     
     
    $_SESSION['username'] = $username;
     
    header ("Location: index.php");
     
    //we will redirect the user to another page where we will make sure they're logged in
     
    } else {
    //if nothing is returned by the query, unsuccessful login code goes here...
     
    echo 'Incorrect login name or password. Please try again.<br>';
     
    echo "$username - $password";
     
    }
    
    } else { //show login form
    //If all went right the Web form appears and users can log in
    echo "<form action=\"?op=login\" method=\"POST\">";
    echo "Username: <input name=\"username\" size=\"15\"><br />";
    echo "Password: <input type=\"password\" name=\"password\" size=\"8\"><br />";
    echo "<input type=\"submit\" name=\"submit\" value=\"Login\">";
    echo "</form>";
    }
    
    ?>

fifarulez 0 Light Poster · Answer 24 · 2011-09-06T08:47:02+00:00

Oh great!! Thank you very much!!!!! a million times!!!

Solved! :D

SQL query prob.

Recommended Answers Collapse Answers

All 29 Replies

Recommended Answers