0

This is the type of feed which I'm pulling data from...

<item> 
      <title>This is a title</title>  
      <description>Description.</description>  
      <link>Link</link>  
      <media:content width="60" height="50" url="http://www.someurl.com"/>  
      <media:content width="150" height="80" url="http://www.someurl.com"/> 
    </item>  
    <item> 
      <title>This is a title</title>  
      <description>Description.</description>  
      <link>Link</link>  
    </item>  
    <item> 
      <title>This is a title</title>  
      <description>Description.</description>  
      <link>Link</link>  
      <media:content width="60" height="50" url="http://www.someurl.com"/>  
    </item>

Here's how I do it...

<?php
$xml="$_GET['url']"; //link to RSS Feed
$xmlDoc = new DOMDocument();
$xmlDoc->load($xml);

for ($i=0; $i<=10; $i++)
  {
  $x=$xmlDoc->getElementsByTagName('item');
  $item_title=$x->item($i)->getElementsByTagName('title')
  ->item(0)->childNodes->item(0)->nodeValue;
  $item_link=$x->item($i)->getElementsByTagName('link')
  ->item(0)->childNodes->item(0)->nodeValue;
  $item_desc=$x->item($i)->getElementsByTagName('description')
  ->item(0)->childNodes->item(0)->nodeValue;

  $x = $xmlDoc->getElementsByTagNameNS("http://search.yahoo.com/mrss/", "content");
  
  $image = $x->item($i)->getAttribute('url');
  echo "<img src='$image'/>";
  echo ("<p><a href='" . $item_link
  . "'>" . $item_title . "</a>");
  echo ("<br />");
  echo ($item_desc . "</p>");
  }

?>

As you can see, some of the child nodes of each <item> element often occur twice, only once or not at all I.E <media:content> in this example.

This means that although the title, description and link will be printed but when there isn't an image under a particular <item> node then it would just print the next image which is supposed to be printed with a different title and description - hope that makes sense.

What I am intending to do is to be able to recognize when there isn't a <media:content> element then just print the title/description/link but not the image because it belongs to the next <item> down. And if there are two, only print one and move on. I really need some help with this as I've become frustrated trying to solve this issue!

Edited by asif49: n/a

3
Contributors
17
Replies
19
Views
5 Years
Discussion Span
Last Post by asif49
0

Hi,

Are there anymore codes above <item></item>? Can you give me the live url, so that I can take a look.

-1

Sort of, but since I gained no reply I thought I'd word the question better here. Thanks for pointing it out for absolutely no reason though. Cheers.

Votes + Comments
He was pointing out your violaltion of the rules. Cheers.
0

ok since I don't feel lazy today, here is a simple RSS parser I just wrote for anyone who needs it. The source code is heavily commented already that I don't even see the needs of explaining anything right now.

<?php
## Some pretty basic RSS parser
### some Announcement from me
## Written by PoorBoy from http://veedeoo.com/forum or Veedeoo from http://daniweb.com
## Date Created : January 18, 2012
## end of my tiny announcement

## type in your xml file location or rss feed
$xml ='http://feeds.bbci.co.uk/news/england/london/rss.xml';
## remove @ to debug
$xml = @simplexml_load_file($xml); 
 foreach($xml as $items)
 ## disecting the xml as items
{
## we are only interested on the <item> and its children
$item = $items->item;
foreach($item as $news){
## parse title
$title = $news->title;
## parse description
$description = $news->description;
## parse news link
$news_link = $news->link;
## parse publication date
$pub_date = $news->pubDate;
## this is standards in all xml and rss parsing
$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_attrs = $c_thumb->thumbnail[0]->attributes();
## we only want the url for this purpose
$thumb = $t_attrs['url'];
## echo everything
echo $title."<br/>";
echo "<img src='".$thumb."'/> </br>";
echo "Description: ".$description."<br/>";
echo "Link: ".$news_link."<br/>";
echo "Publication Date: ".$pub_date."<br/><br/>";

}
}
  ?>

HINT: Do not double post your question in the future.. That's a bad practice..

Edited by veedeoo: n/a

0

Solution works really nicely as far as I can tell! Forgive me for being a novice but how can I limit it so it only gets a pre-determined amount of <item>'s elements

0

Hi, that's pretty easy... This is how you stop foreach loop iteration at any given point, assuming that the item within the loop is greater than 0.


On the codes above, find

$xml = @simplexml_load_file($xml);

just below it add;

$somecount = 0;
$limit = 10;

scroll down the page and find;

echo "Publication Date: ".$pub_date."<br/><br/>";

Just below it, add;

if (++$somecount >=$limit) break;

You must define your limit as integer like this $limit = 10; common mistakes even experts would do it like this $limit = "10"; which is a string..

Edited by veedeoo: n/a

1

You are very much welcome. Good thing it all worked out for you..

Votes + Comments
Offered great and thorough help, and even answered subsequent questions. Great Member!
0

Actually, one final thing... this is the most vital thing in what I'm trying to achieve.

At the moment, as you said, we can set a start and limit as start = 0; and limit = 10;

Can we go a step further and say start = 10; and limit = 20; so we only access from the 10th <item> element onwards.

Much much much thanks in advance!

Edited by asif49: n/a

1

Yes, you are correct.. You can always control the start and the stop. To achieved this, we need to assign another variable. Just like in basic mathematics where we invent another constant or variable Z , so that we can solve for the X and Y. Something like this Z = X+Y , Y = Z- X , X = Z - Y respectively. Can we apply those simple transpositions? Yes..

He we go. Remember our codes in the previous page? We can upgrade it to this

<?php
## Some pretty basic RSS parser
### some Announcement from me
## Written by PoorBoy from http://veedeoo.com/forum or Veedeoo from http://daniwed.com
## Date Created : January 18, 2012
## end of my tiny announcement

## type in your xml file location or rss feed
$xml ='http://feeds.bbci.co.uk/news/england/london/rss.xml';
## remove @ to debug
$xml = @simplexml_load_file($xml); 
$somecount = 0;
$base = 10;
$limit = 5;
 foreach($xml as $items)
 ## disecting the xml as items
{

## we are only interested on the <item> and its children
$item = $items->item;
foreach($item as $news){
## parse title
$title = $news->title;
## parse description
$description = $news->description;
## parse news link
$news_link = $news->link;
## parse publication date
$pub_date = $news->pubDate;
## this is standards in all xml and rss parsing
$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_attrs = $c_thumb->thumbnail[0]->attributes();
## we only want the url for this purpose
$thumb = $t_attrs['url'];
## echo everything
++$somecount;
if ($somecount >= $base) { 
##comment the somecount below
echo $somecount."<br/>" ;
echo $title."<br/>";
echo "<img src='".$thumb."'/> </br>";
echo "Description: ".$description."<br/>";
echo "Link: ".$news_link."<br/>";
echo "Publication Date: ".$pub_date."<br/><br/>";

}
## we need to add the limit and the base
## none of the two could be equal to zero
if ($somecount >=$limit + $base) break;


}
}
  ?>

If you run the script above, you will notice that it will only display from your base count and terminated by your limit..

Edited by veedeoo: n/a

0

You're a lifesaver. It worked! Wished I had a teacher who was as good with explaining things as you. I don't want you to feel like I keep pressing you for more and more information but there is a certain error I'm getting here.. it says

"Call to a member function attributes() on a non-object in getRSS.php" which specifies that the error is at the following line:

$c_thumb = $news->children('http://search.yahoo.com/mrss/');
$t_attrs = $c_thumb->thumbnail[1]->attributes();
$thumb = $t_attrs['url'];

it looks like this is because some <item> elements contain only one thumbnail but we are trying to get the second <media:thumbnail> element's attribute above. I've tried to correct it using the following:

if ($c_thumb->thumbnail[1]->attributes() != null) {
$t_attrs = $c_thumb->thumbnail[1]->attributes();
} else {
$t_attrs = $c_thumb->thumbnail[0]->attributes();
}

but it doesn't seem to work. Any ideas here?

0

Hi this may work. I just don't have the time to test it locally. It should work..

$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_one = $c_thumb->thumbnail[0]->attributes();
## try to grab the second thumbnail of the article
$t_two = $c_thumb->thumbnail[1]->attributes();
## url of the first thumb
$thumb_one = $t_one['url'];
## url of the second thumb
$thumb_two = $t_two['url'];
## set condition if
## we cannot use !=null, becuase simpleXML views the file as xml file
if($thumb_two != ""){
$thumb = $thumb_two;

else{
$thumb = $thumb_one;
}

or this may work also

$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_one = $c_thumb->thumbnail[0]->attributes();
## try to grab the second thumbnail of the article
$t_two = $c_thumb->thumbnail[1]->attributes();
## url of the first thumb
$thumb_one = $t_one['url'];
## url of the second thumb
$thumb_two = $t_two['url'];
## set condition if
## we can use !=null, if simpleXML can return NULL as value for not found attributes
if($thumb_two != null){
$thumb = $thumb_two;

else{
$thumb = $thumb_one;
}

Edited by veedeoo: n/a

0

Here is the corrected codes for the above

$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_one = $c_thumb->thumbnail[0]->attributes();
## try to grab the second thumbnail of the article
$t_two = $c_thumb->thumbnail[1]->attributes();
## url of the first thumb
$thumb_one = $t_one['url'];
## url of the second thumb
$thumb_two = $t_two['url'];
## set condition if
## we cannot use !=null, becuase simpleXML views the file as xml file
if($thumb_two != ""){
$thumb = $thumb_two;
}
else{
$thumb = $thumb_one;
}

for the second codes

$c_thumb = $news->children('http://search.yahoo.com/mrss/');
## try to grab the first thumbnail of the article
$t_one = $c_thumb->thumbnail[0]->attributes();
## try to grab the second thumbnail of the article
$t_two = $c_thumb->thumbnail[1]->attributes();
## url of the first thumb
$thumb_one = $t_one['url'];
## url of the second thumb
$thumb_two = $t_two['url'];
## set condition if
## we can use !=null, if simpleXML can return NULL as value for not found attributes
if($thumb_two != null){
$thumb = $thumb_two;
}
else{
$thumb = $thumb_one;
}

Make sure to test which one of the codes above works for you.. Double check and make sure you are displaying the second thumb "image info"..

Edited by veedeoo: n/a

0

The worst expected thing happened, both of the methods failed :(

The error seems to be at this point:

$t_one = $c_thumb->thumbnail[0]->attributes(); 
$t_two = $c_thumb->thumbnail[1]->attributes();

It works until it encounters an object where there is only one <media:thumbnail> element. I think it's because in that case, the second line above which tries to access the second element simply isn't there so it sends an error and stops doing anything else

0

To test if the attributes ..

$t_one = $c_thumb->thumbnail[0]->attributes();
$t_two = $c_thumb->thumbnail[1]->attributes();

exist, then you will have to use bool like this

$t_one =(bool)( $c_thumb->thumbnail[0]->attributes());
$t_two = (bool)($c_thumb->thumbnail[1]->attributes());

If the attributes ever exist on the xml file, then the script should return 1.. Based on this response, you can use it to switch your thumbnails or whatever you want to access.

Comment the if statement and trigger the (bool) and then echo out the "$t_one".. This should give you something like this on your page

1
1
1
1
1
1
1
1

10
and so forth... For none existing attributes it should return zero (0)..

That's all you have to do.. It is true or false..

IMPORTANT! Once you use the "$t_one" for boolean, you will have to assign another variable for your thumb like

if($t_one == 1){
$t_one_is_true = $c_thumb->thumbnail[0]->attributes();
$thumb_one = $t_one_is_true['url'];

}

Once the script has been tested several times, I strongly suggest for you to rewrite in condensed form, or you can just leave like that.

Edited by veedeoo: n/a

0

It still results a lot of 1's and then when there is a 0 it just displays that error so a lot of 1's are seen then there is just the error.

I've tried to follow your brief and don't think I made any mistakes but here it is anyway,

<?php

$xml ='http://feeds.bbci.co.uk/news/england/london/rss.xml';
$xml = @simplexml_load_file($xml); 

foreach($xml as $items)
{
$item = $items->item;
foreach($item as $news){
$c_thumb = $news->children('http://search.yahoo.com/mrss/');
$t_one =(bool)( $c_thumb->thumbnail[0]->attributes());
$t_two = (bool)($c_thumb->thumbnail[1]->attributes()); /*<<<<ERROR OCCURS HERE when there is only one element in feed*/

if ($t_two == 1) {
$t_two_is_true = $c_thumb->thumbnail[1]->attributes();
$thumb = $t_two_is_true['url'];
} else {
$t_one_is_true = $c_thumb->thumbnail[0]->attributes();
$thumb = $t_one_is_true['url'];
}

echo $thumb . "<br>";

}
}
?>

Edited by asif49: n/a

This topic has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.