problem in inserting data in php

[svmkotla]

hi ,i am new to php i have problem with my code . problem is when ever a page is loded

<?php

if(isset($_POST['submit']));

{
$conn=mysql_connect("localhost","root","vamshi");
if(!$conn)
{
die("couldn't Connected : " .mysql_error());
}

mysql_select_db("ninepixel",$conn);

$sql="insert into  empattendence (name,daydate,choice) values('$_POST[name]',now(),'$_POST[choice]')";

if(mysql_query($sql,$conn))

{
echo("Your Data Has been Submitted");
}

else{

echo("Please Enter All the Fields");

}
mysql_close($conn);

}

?>

or refreshing it inserting a blank row in table,i want to insert data after filled the fields and click the button it has to insert pls help me

[amith_ami]

hi...
pls remove the ";" this from

if(isset($_POST['submit']));

and try it again.....

[cmps]

As amiyar posted is correct, but here is a better way to write your code ;)

<?php

if(isset($_POST['submit'])){
    $conn=mysql_connect("localhost","root","vamshi") or die(mysql_error());
    mysql_select_db("ninepixel",$conn) or die(mysql_error());
    $sql="INSERT into  empattendence (name,daydate,choice) VALUES('$_POST[name]',now(),'$_POST[choice]')";

    if(mysql_query($sql,$conn)){
        echo("Your Data Has been Submitted");
    }else{
        echo("Please Enter All the Fields");
    }
    mysql_close($conn);
}

?>

[svmkotla]

thanks for ur code and help

[Webville312]

Please mark this post as solved ... if your code is finally working

[anandatheerthan]

its better to use PDO instead of old mysql_connect(),mysql_query() methods are these are deprecated in latest php versions. You will also have better security against attacks.