Member Avatar for Munki87

I'm currently creating a text based adventure game using python.
One of the features in the game is that when you enter a room an enemy attacks you and takes off some of your health.
I have an If loop to control if there is an item that you need present, and to print out a statement and take some damage off your health. The statement is printed out, but the health doesn't change.
Anyone any ideas?

I've attached the file as a .txt so you just need to save it as .py
Maybe you all knew this anyway :p

#Python Game - Jack Monk - 0700046
#
                                                #here are the inital variables
rooms = [[3,'n','n',1],[2,0,'n','n'],[5,3,1,'n'],[4,'n',0,2],['n','n',3,5],[7,4,2,6],[8,5,'n','n'],['n','n',5,8],['n',7,6,'n']]
                                                #room lists containing lists - each list is a N, E, S, W format that says wether or not there is that option in the room
location = 0                                    #this variable gives the player a starting location.
heroHealth = 200                                #players starting health
inventory = ["Toothbrush"]                      #player inventory
roomInv = [["Gold Bar"],["Gold Bar","Goblin Shield"],["Snake Whacker"],[],["Gold Bar","Gold Coin","Ruby"],[],["Fire Shield"],["Devil Slayer Sword"],[]]
roomhintlist = [["A hint already? Ha! Go West before you go north!"],["Don't get tempted by the gold - pick up the shield"],["The whacker will help you if you go north!"],["Shields are good against this enemy"],["Make sure you have a weapon before going west"],["This guy is tough, if you're still alive, i would go south."],["The shield in this room can stop FIRE"],["Pickup the weapon"],["You have either won or died, so no hint for you!"]]
roomdescription = [["Welcome to Hell, The only way out is to kill The Devil!"],["You see gold around you, and a small shield over on the wall"],["There appears to be a large club lying on the floor"],["Watch Out! There appears to be a small Goblin, entering the room has caused him to be angered."],["Theres Treasure all over the place....So much gold..."],["Uh oh! You have entered the Snake Eaters lair."],["You are deep in the depths of hell now. A red glistening shield is clinging onto a skeleton."],["You are very deep into hells underworld. Hanging on the wall you can see a huge sword. Etched on the side it says 'DIABLO'."],["You have entered Satans Sanctomb. If only there was a way to kill the Devil."]]
win = 0
validMainMenuOptions = ['1','2','3','4','0']
roomMonsters = [[],[],[],["Fire Goblin"],[],["Snake Eater"],[],[],["The Devil"]]

    
def monster():                                  #this function checks the players location, and checks for items in bag.
    if location == 3:
        if "Goblin Shield" not in inventory:
            print """
                    The enraged Goblin hits you
                    and you take 50 damage.
                    """
            healthChange = heroHealth - 50
            return(healthChange)
            print "Your health is now",healthChange
        else:
            print """
                    The Shield deflects a hit
                    from the angry Goblin.
                    """
    if location == 5:                           #if the item is not in the bag, the NPC does some damage.
        if "Snake Whacker" not in inventory:
            print """
                    Snake Eater throws a snake
                    at you, and causes you 100
                    damage.
                    """
            healthChange = heroHealth - 100
            return(healthChange)
        else:
            print """
                    You batter the snake eater
                    with your snake whacker.
                    """
    if location == 8:
        if "Devil Slayer Sword" and "Fire Shield" not in inventory:
            print """
                    The Devil hurls a flaming
                    ball of fire at you.
                    It does 100 damage to you.
                    """
            healthChange = heroHealth - 100
            return(healthChange)
        else:
            print """
                    You slash the Devil with
                    your Devil Sword, killing
                    him instantly.
                    """                         #if you have the items required, and are in room 8, then you win.
            win = 1
        return(win)
                
    else:
        healthChange = heroHealth
    

    
def offerDirections():                          #this function prints the possible options that are available depending on the room
    print "Possible Moves:"                     #if a room in the rooms list can only go north, then this function will only show north as an options
    print "---------------------"
    
    if rooms[location][0] != "n":
        print "North [0]"
    if rooms[location][1] != "n":
        print "East  [1]"
    if rooms[location][2] != "n":
        print "South [2]"
    if rooms[location][3] != "n":
        print "West  [3]"
    print "---------------------"


def playerInputDirection():
    print                                               #this function asks player where they would like to go and captures their input.
    print 'Which way do you wish to go?'
    selection = int(raw_input())
    return (selection)

def movement():
    offerDirections()
    locationUpdater = playerInputDirection()            #here the input direction is given a 
    currentLocation = rooms[location][locationUpdater]
    return (currentLocation)

def pickup():
    if roomInv[location] != []:                         #this function allows the players to pick up and item on the rooms floor.
        print "--------AREA---------"
        for index,item in enumerate(roomInv[location]):
            print index,item
        pickupitem = int(raw_input("What do you want to Pick Up? "))
        itemToRemove = roomInv[location][pickupitem]
        roomInv[location].remove(itemToRemove)
        inventory.append(itemToRemove)
        print "Items now on floor:-"
        print roomInv[location]
    else:
        print "There is nothing on the floor"
        nothingOnFloor = raw_input()

def putdown():
    if inventory != []:                                 #this function allows the player to put items down.
        print "------INVENTORY------"
        for index,item in enumerate(inventory):         #this part numbers the list(list) and prints out the number then the item
            print index,item
        putdownitem = int(raw_input("What do you want to Put Down? "))
        itemToRemove = inventory[putdownitem]
        inventory.remove(itemToRemove)
        roomInv[location].append(itemToRemove)
        print "Items now on floor:-"
        print roomInv[location]
    else:
        print "You have nothing in your hands to drop!"
        nothingInHands = raw_input()

def roomhint():                                         #this function looks for the location and prints the corresponding hint
    print "--------HINT---------"
    print roomhintlist[location]
    pressEnter = raw_input("Press Enter to Continue..")
    
def quitgame():
    print "--------EXIT---------"                       #this function allows the user to quit the game.
    exitgame = raw_input("Are you sure you want to quit the game? Y/N..")
    if exitgame == "Y" or exitgame == "y":
        print "Thank you for playing."
        exit()

print """   WELCOME TO HELL ESCAPE!
            You where brushing your teeth
            getting ready for bed, when
            suddenly the bathroom raised
            high in the air!
            You are dropping into Hell!
            How are you ever going to
            get out!
            With just you Toothbrush in
            your hand, you must find a way
            to escape hell, and get back
            to bed!
        """

while not win == 1 and heroHealth !=0:               #This is the main body of the program.
    print "Current Health    :",heroHealth
    print "Current Location  :","Room",location
    print "Items in Room",location,"  :",roomInv[location]
    print "Items in Inventory:",inventory
    print roomdescription[location]
    monster()
    print ("---------------------")
    print ("--------MENU---------")
    print ("---------------------")
    options = ["Move","Pick Up Object","Put Down Object","Hint","Quit"]
    for index, item in enumerate(options):
        print index, item
    optionSelected = raw_input("What would you like to do? ")
    while optionSelected not in validMainMenuOptions:
        optionSelected = raw_input("invalid input, please choose a correct number")
    optionSelected = int(optionSelected)
    if optionSelected == 0:
        location = movement()
    if optionSelected == 1:
        pickup()
    if optionSelected == 2:
        putdown()
    if optionSelected == 3:
        roomhint()
    if optionSelected == 4:
        quitgame()
print "----------------GAME OVER----------------"
  • 2 Contributors
  • 1 Reply
  • 87 Views
  • 1 Day Discussion Span
  • Latest Post Latest Post by jrcagle
Member Avatar for jrcagle

You really want to make your character a class object. That's what object-oriented coding is all about.

Then, you can simply subtract the damage from self.health and all will work fine.

Jeff

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.