Hi,I want to write a program that calculate the increment and new salary of employee based on the average of three evaluation points.(using pass by reference/pass by value). I've done the coding but the output is wrong. I think there's a mistake on the call function.

``````#include<stdio.h>
float get_increment(float *a);
float get_new_salary(float  *salary);
float ave,percent,ns;

int main()
{
float i,j,total=0,ave,sum;
{
for(i=0;i<3;i++)
{
scanf("%f",&j);

total+=j;
printf("%.2f\n",total);
}
ave=total/3.00;
}
printf("%.2f\n",ave);
get_increment(&ave);
printf("The increment percentage is %.2f.\n",percent);
get_new_salary(&percent);
printf("The new salary is %.2f\n",sum);
}

float get_increment(float *a)

{
float percent;

if(ave>=2.00&&ave<=2.99)
{
percent=0.02;
}
else if(ave>=3.00&&ave<=3.99)
{
percent=0.04;
}
else if(ave>=4.00&&ave<=5.00)
{
percent=0.06;
}
return percent;
}

float get_new_salary(float *salary)

{
float ns,total,percent,pay,sum;

scanf("%f",&pay);
ns=pay*percent;
sum=ns+pay;

return sum;

}
``````

## All 3 Replies

[boilerplate_help_info]

``````Posting requests for help must be well thought out if you want help quickly and correctly.  Your post did not meet the criteria for quality help. You may get some posts, but are they going to be useful?  Check your post with these checkpoints - what is it [i]you[/i] missed:
[list=1]
- What's wrong with my code?
- Why doesn't this work?
- Anything else that does not give us useful information.
[*]Post your code.  If we don't know what you did, how can we possibly help?
- Use [b]PROPER FORMATTING[/b] -- see this
- Use CODE Tags so your formatting is preserved.
If we can't follow your code, it's difficult to help. We don't care that you're still working on it. If you want us to read it, it must be readable
[*]Explain what the code is supposed to do.  If we don't know where the target is, how can we help you hit it?
[*]Explain what actually happened! If we don't know where the arrow went when you shot it, how can we tell what went wrong and how far from the target you are?
[*]If you have errors, post them! We can't see your screen.  We can't read your mind. You need to tell us what happened.
If anyone posts working code for you, they are a cheater.
If you use that code [i]you[/i] are a cheater.
[*]Do [b]not[/b] bore us with how new you are. We can tell by your code.
- Do not apologize. We were all new, and unless you are completely
brain dead you will get better.
- Do not ask us to "take it easy on you."
- Do not say "I don't know what's going on." That's obvious since
you posted for help. Use that time wisely by [b]explaining[/b] as best
you can so we can help.
[*]Do not apologize for posting 'late'. We don't have any expectations on when you should be posting - 10 minutes or 10 days. We aren't timing your responses.
[*][b]Do not post your requirements and nothing else. [/b]We view that as a lazy do-nothing student that wants us to do their work for them. That's cheating and we [i]will[/i] be hard on you.
[*]Do not attach files except when absolutely necessary. Most of us are not going to download files.  Add the information to your post.
[*][b]Do not tell us how urgent it is.[/b] Seriously, for us there is no urgency at all. Many that can help will ignore any URGENT or ASAP requests.
[/list]
Think more about your next post so we don't have to play 20 questions to get the info we need to help you.``````

[/boilerplate_help_info]

Nevermind~

When you use a variable without passing it by reference to the function doesn't give it a new value when you return to main

for example:

``printf("The new salary is %.2f\n",sum);``

You never assigned a value to sum at main just because you assign a value to it from a function it doesn't mean it will retain the value when it returns to the main function since you did not pass it by reference

``ns=pay*percent;``

same can be said here, percent has no value at float get_new_salary function

try to pass the variables percent and sum to the functions you use them in order to assign them a value

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.