I am making a programe based on socket programing in which client can download one of the listed books from server. I have come up with this code but the problems with it are:
1) It doesnt downloads pdf file greater than 1MB.
2) It allows client to download 1 file only and then the connection is closed.
I want the client to be able to download as many files as he/she wants.
Please suggest improvements.


int filesize=10223860;
int bytesRead;
int currentTot = 0;
Socket socket = new Socket("",15123);
BufferedReader inFromUser = new BufferedReader(new InputStreamReader(System.in));
DataOutputStream outToServer = new DataOutputStream(socket.getOutputStream());

byte [] bytearray  = new byte [filesize];
InputStream is = socket.getInputStream();
System.out.println("Select one book to download: ");
System.out.println("1) 1.pdf ");
System.out.println("2) 2.pdf ");
String opt;
opt = inFromUser.readLine();
outToServer.writeBytes(opt + '\n');

FileOutputStream fos = new FileOutputStream("copy"+opt);
BufferedOutputStream bos = new BufferedOutputStream(fos);
bytesRead = is.read(bytearray,0,bytearray.length);
currentTot = bytesRead;

bytesRead = is.read(bytearray, currentTot, (bytearray.length-currentTot));
if(bytesRead >= 0) 
currentTot += bytesRead;
while(bytesRead > -1);

bos.write(bytearray, 0 , currentTot);


ServerSocket serverSocket = new ServerSocket(15123);
Socket socket = serverSocket.accept();
System.out.println("Connection created successfully!");

BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream()));
String n;
n = in.readLine();

File transferFile = new File (n);
byte [] bytearray  = new byte [(int)transferFile.length()];
FileInputStream fin = new FileInputStream(transferFile);
BufferedInputStream bin = new BufferedInputStream(fin);
OutputStream os = socket.getOutputStream();
System.out.println("Sending File \""+n+"\"...");
System.out.println("File transfer complete");

Recommended Answers

All 3 Replies

Rather than have one big buffer - which limits the file size, you can have smaller buffers (eg 4k) and write/read the file one buffer at a time for unlimited file sizes. Eg for the server...

        byte[] data = new byte[4096];
        int count;
        while ((count = file.read(data)) != -1) {
            outbound.write(data, 0, count);

and similarly for the client, but reading from the socket and writing to the file.

For multiple files you can have the client send a positive int to request a file and -1 to say "finished". Then at athe server you loop sending the requested files until you get a -1

can you please tell me what changes would be required in Client code??

I'm not here to write your code for you ;)
I gave you a short version, so give it a try - it's not difficult. If you do get stuck post what you have done and we'll take it from there.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, learning, and sharing knowledge.