Ok, I'm a newbie. I've been reading through the www.cplusplus.com tutorials and now I've turned to doing simple exercises that I've found in free online resources and also ones that I've devised for myself. One of my first programs was a program that discovered prime numbers using nested [inline code]for[/inline code] loops. But now that I've been reading about vectors, I think I see a better way to do it. I've set myself the task of developing a faster program to factor numbers and discover primes. Here is the program with comments. Conceptually, I think it looks sound. It compiles. But it keeps giving me runtime errors. I've stuck in a bunch of printouts so that I can see where it fails. It doesn't even print one prime number before failing. I don't really know how to debug yet, this is the first program I've had that will compile but not run. I guess I need to learn debugging. But if anyone can take a quick peak and tell me what's wrong, I'd just feel more satisfied and able to move on to the next lesson :).

EDIT: Well, I got it to run. I guess had intialized iter before I put anything into the vector, so when I used *iter it was pointing to a null value. But now the code just does an infinite loop. This is something I think I can fix, but I'll just leave this up here anyway. I updated with the latest code.

#include <cstdlib>
#include <iostream>
#include <sstream>
#include <vector>
using namespace std;
int main() {
    cout<<"Now displaying the first 20 prime numbers\n ";
vector <int> factors;
vector <int>::iterator iter;    
int num=0, a=1;
while (factors.size()<20){ //while there are <20 primes in the vector
   num =(factors.back()+(2*a));/*the num is the last prime we've found 
                           + 2*the number of wrong numbers we've found since the last prime*/
           if (*iter == factors.back()){  /*if the current prime is the last one in the list,
                                       that means the current num is a prime, add it to the list, then print it */
            cout << factors.back() << ", ";
            iter=factors.begin();  //start the while loop with a fresh iterator
            a=1; //start cycling nums again, starting at 2+the current prime in the list (should be the new prime we just pushed back)
        else if (!(num % *iter) ) { //if the num under consideration divides into the current prime in the list with no remainder, start on the next num
            iter=factors.begin(); //reset to the first prime in the list
            a++;//so the program knows we found a wrong number and to try the next odd number
       iter++; //if neither of these two conditions are met, repeat the while loop with the next prime in the list
cout << "\n.  Finished!  Found " << factors.size() <<" factors";
return 0;
9 Years
Discussion Span
Last Post by ~s.o.s~

You are overly complicating things. Just use a simple counter which would be incremented each time a prime number is found and break out of the while loop when the counter exceeds 20.

No need for iterators. Also querying the size fo a vector in each iteration would not be such a good idea. Keep a simple counter and you would be good to go.


You're probably right, I'm sure I'm complicating things. I'd bet there are a ton of more elegant solutions. One of the goals though was to explore the use of iterators, which is why I chose to try it this way. Thank you though, I think you might be right, this project might be a scrapper.


Being innovative and enterprising is a good thing, but you must know where to invest your time in. This page hosts a number of ways of finding out prime numbers. Pick up a tough one and go for it. Maybe then you would really be in a position to come up with the real thing. ;-)

This article has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.