C++ error////

#include<iostream.h>
#include<conio.h>
class twonum
{
private :
    int x,y;

public:
void getvalues()
{
    cout<<"enter any two numbers";
    cin>>x>>y;
}
void putvalues()
{
    cout<<"\n\n"<<x<<","<<y;
}
int add(int x,int y)
{
    return(x+y);
}
int multiply(int x,int y)
{
    return(x*y);
}
void swap(int x,int y)
{
    int c;
    c=x;
    x=y;
    y=c;
    cout<<x<<","<<y;
};
void main()
{
    clrscr();
    int k,j,l;
    twonum s;
    s.getvalues();
    s.putvalues();
    k=s.add(x,y);
    cout<<"addition:"<<k;
    j=s.multiply(x,y);
    cout<<"multiplication:"<<j;
    s.swap(x,y);
    getch();
}

c c++

Contributors

Replies

Views

9 Months

Discussion Span

9 Months Ago

Last Post by tinstaafl

Take a moment to read https://www.daniweb.com/programming/web-development/threads/435023/read-this-before-posting-a-question then add some details. You dumped code and while I see something in your title, it's like you expected folk to guess what this does and fix it.

I see some mixup of your tags too. This looks like a mashup of c and c++.

Edited 9 Months Ago by rproffitt: Clarifying

Regarding conio.h, getch, clrscr, not everyone has conio.h. You might try changing iostream.h to iostream. "void main" should probably be "int main" and your main function should return 0.

Those "problems" might allow it to compile on your machine and not on others, but the actual errors are below.

You are using cout without either the "using namespace std;" line at the top or putting std:: in front of cout.
x and y are data members of your class and they are private too. If x and y were public, your program would compile if you replaced x with s.x and y with s.y However, since they are private, even that won't work.

Edited 9 Months Ago by AssertNull

Whoops, sorry RP, didn't see your post before posting. Good points.

Votes + Comments

rproffitt: You made good points as well. The code, well, it's just a code dump and run with many dangling unspoken questions.

Another thought, it looks to me like you're attempting to use the variables inside the class for your functions. In that case you can leave out the parameters and make the calculations based on the variables inside the class directly. This way they can stay private.

int add()
{
    return(x + y);
}

Edited 9 Months Ago by tinstaafl

c c++