Hey, I am trying to recursively retrieve the directory listing of a given directory that is, print out all files and folders (and sub folders) of a given directory. My function #1 does not work, however the function someone else has written #2 does. Why is this?

My Function #1:

<?php
function showDirectory( $directory )
{
echo("<BR>TESTING: ARG=". $directory);
   $dir = opendir( $directory );
   if ( $dir )
   {
echo("<BR>TESTING: dir has been opened");
      while ( false !== ( $file = readdir( $dir ) ) )
      {
echo("<BR>TESTING: file=" . $file);
         if ( $file != "." && $file != ".." )
         {
echo("<BR>TESTING: file IS NOT . or ..");
            if (is_dir($directory . "/" . $file))
            {
echo("<BR>TESTING: " . $directory . "/" . $file . "is a directory");
               showDirectory( $directory . "/" . $file );
            }
            else
            {
echo("<BR>TESTING: " . $directory . "/" . $file . "is NOT a directory");
               echo( "<B>" . $directory . "/" . $file . "</B><BR>\n" );
            }
         }
         else
         {
echo("<BR>TESTING: file=. OR ..");
         }
         closedir( $dir );
      }
   }
   else
   {
echo("TESTING: $dir = null");
   }
}
?>

Someone else's function #2

<?php

function getDirectory( $path = '.', $level = 0 ){

    $ignore = array( 'cgi-bin', '.', '..' );
    // Directories to ignore when listing output. Many hosts
    // will deny PHP access to the cgi-bin.

    $dh = @opendir( $path );
    // Open the directory to the handle $dh
    
    while( false !== ( $file = readdir( $dh ) ) ){
    // Loop through the directory
    
        if( !in_array( $file, $ignore ) ){
        // Check that this file is not to be ignored
            
            $spaces = str_repeat( '&nbsp;', ( $level * 4 ) );
            // Just to add spacing to the list, to better
            // show the directory tree.
            
            if( is_dir( "$path/$file" ) ){
            // Its a directory, so we need to keep reading down...
            
                echo "<strong>$spaces $file</strong><br />";
                getDirectory( "$path/$file", ($level+1) );
                // Re-call this same function but on a new directory.
                // this is what makes function recursive.
            
            } else {
            
                echo "$spaces $file<br />";
                // Just print out the filename
            
            }
        
        }
    
    }
    
    closedir( $dh );
    // Close the directory handle

}

?>

sorry about that, the only error I get is:

Warning: readdir(): 41 is not a valid Directory resource in C:\Program Files\Apache Group\Apache2\htdocs\index.php on line 24

The only thing I can tell is that the second function is suppressing warnings/errors when it opens a directory with the @ $dh = @opendir( $path ); as opposed to $dir = opendir( $directory ); .

I have tried the @ to suppress warnings on all the functions I am using, I don't get any messages from PHP but now all my function displays are the testing echos..

TESTING: ARG=..
TESTING: dir has been opened
TESTING: file=.
TESTING: file=. OR ..

Nevermind, I have found the mistake.. I was using closedir() inside the loop where I should have been using it outside the loop.

This article has been dead for over six months. Start a new discussion instead.