-1

Need help with my registration code for my site.

Read through it if you may and tell me if there are any errors.
(And where do I place this in the page?)

<?php
// Connects to your Database
mysql_connect("database.accdb", "", "") or die(mysql_error());
mysql_select_db("users") or die(mysql_error());

//This code runs if the form has been submitted
if (isset($_POST['submit'])) {

//This makes sure they did not leave any fields blank
if (!$_POST['username'] | !$_POST['pass'] | !$_POST['email'] ) {
die('You did not complete all of the required fields');
}

// checks if the username is in use
if (!get_magic_quotes_gpc()) {
$_POST['username'] = addslashes($_POST['username']);
}
$usercheck = $_POST['username'];
$check = mysql_query("SELECT username FROM users WHERE username = '$usercheck'")
or die(mysql_error());
$check2 = mysql_num_rows($check);

//if the name exists it gives an error
if ($check2 != 0) {
die('The username '.$_POST['username'].' is already in use. Please choose another.');
}

// this makes sure both passwords entered match
if ($_POST['pass'] != $_POST['pass']) {
die('Error! Contact an administrator. ');
}

// here we encrypt the password and add slashes if needed
$_POST['pass'] = md5($_POST['pass']);
if (!get_magic_quotes_gpc()) {
$_POST['pass'] = addslashes($_POST['pass']);
$_POST['username'] = addslashes($_POST['username']);
$_POST['email'] = addslashes($_POST['email']);
}

// now we insert it into the database
$insert = "INSERT INTO users (username, password)
VALUES ('".$_POST['username']."', '".$_POST['pass']."', '".$_POST['email']."')";
$add_member = mysql_query($insert);
?>


<h1>Registered</h1>
<p>Thank you, you have registered - you may now login</a>.</p>

<?php
}
else
{
?>


<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<table border="0">
<tr><td>Username:</td><td>
<input type="text" name="username" maxlength="60">
</td></tr>
<tr><td>Password:</td><td>
<input type="password" name="pass" maxlength="10">
</td></tr>
<tr><td>Email Address:</td><td>
<input type="text" name="email" maxlength="70">
</td></tr>
<tr><th colspan=2><input type="submit" name="submit" value="Register"></th></tr> </table>
</form>

<?php
}
?>
2
Contributors
2
Replies
3
Views
7 Years
Discussion Span
Last Post by stanfordftw
1

A) Fix your identation
B) You don't need addslashes on the password, you're MD5ing it, there will never be slashes
C) Where do you place what on your page?

0

A) Fix your identation
B) You don't need addslashes on the password, you're MD5ing it, there will never be slashes
C) Where do you place what on your page?

C.) Is there a certain place I need to put the whole code into my page. Like body or before html or something.

Thanks for replying. Is there a way this can work locally instead of using an online database?

This topic has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.