Recall

Question

Kniggles 0 Light Poster

13 Years Ago

can anyone see where i am not reciving the results I am looking for ?
please,

?><META name=GENERATOR content="MSHTML 8.00.7600.16722"><?session_start();if(!session_is_registered(myusername)){header("location:main_login.php");
   }
   ?>
   <P>

    <? echo "PLAYER:" .'($myusername)';?>

this code is spose to echo out the players login name from the check_login.php page from before.
thanks.

echo header php

4 Contributors
16 Replies
201 Views
1 Day Discussion Span
Latest Post 13 Years Ago Latest Post by Kniggles

All 16 Replies

dietdew12z 8 Junior Poster

13 Years Ago

What output are you actually getting? Some of that code is deprecated but what stood out to my eye was '($myusername)' which given the username of 'Bob':

What you expect:
PLAYER: (Bob)

What you'd get:
PLAYER: ($myusername)

Reason being that using single quotes prevents PHP from substituting the variable's contents in the output, using double quotes there would fix that.

The other thing is that I'd probably replace !session_is_registered(myusername) with !$_SESSION[myusername] just for yucks.

Edited 13 Years Ago by dietdew12z because: n/a

jrotunda85 9 Junior Poster

13 Years Ago

Give this a try:

echo "Player: (".$myusername.") Login Successful"

dietdew12z 8 Junior Poster

13 Years Ago

?>

<META name=GENERATOR content="MSHTML 8.00.7600.16722">

<?php
session_start();
if(!SESSION[myusername])
  {
  header("location:main_login.php");
  }
?>
   <p>

<?php

 echo "PLAYER: $myusername ";

?>

  </p>

See if this doesn't work a little better.

diafol

13 Years Ago

As diet says: $_SESSION(myusername) should be $_SESSION['myusername'] When you were using session_is_registered[myusername] should have been session_is_registered("myusername") As for getting bits from all over and not knowing what you're doing. PLEASE, get a downloadable copy of the php manual from the php.net site. It'll save you (and possibly others) a lot of time. Most of the errors can be checked directly in the manual when using certain functions.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

Kniggles 0 Light Poster · Answer 1 · 2011-03-22T00:26:35+00:00

What output are you actually getting? Some of that code is deprecated but what stood out to my eye was '($myusername)' which given the username of 'Bob':
What you expect:
PLAYER: (Bob)
What you'd get:
PLAYER: ($myusername)
Reason being that using single quotes prevents PHP from substituting the variable's contents in the output, using double quotes there would fix that.
The other thing is that I'd probably replace !session_is_registered(myusername) with !$_SESSION[myusername] just for yucks.

Hi dietdew12z, thanks for helpping,

the output i am getting with the above code,

echo "Player: ".($myusernam) Login Successful

the output I am looking for is

Player Bob Login Successful.

Kniggles 0 Light Poster · Answer 2 · 2011-03-22T00:47:00+00:00

<HTML><HEAD><TITLE></TITLE>
<META name=GENERATOR content="MSHTML 8.00.7600.16722">
<?session_start();if(!session_is_registered[myusername]){header("location:main_login.php");}?><P>
 
<? echo "Player: "."($myusername)"  
Login Successful</P><P>&nbsp;</P><P><A href="../logout.php" target=_self>Log out </A>

this code gives me the output

Parse error: syntax error, unexpected '[' in /home/abc123/public_html/login_success.php on line 1

dietdew12z 8 Junior Poster · Answer 3 · 2011-03-22T00:55:12+00:00

<html><head><title></title>
<meta name=GENERATOR content="MSHTML 8.00.7600.16722">
<?php session_start();if(!$_SESSION[myusername]){header("location:main_login.php");} ?><p>
 
<?php echo "Player: "."($myusername)"; ?>
Login Successful</p><p>&nbsp;</p><p><a href="../logout.php" target=_self>Log out </a>

Okay, try this. :)

The error you saw above was because I substituted a system global variable $_SESSION[] for your PHP function session_is_registered() and one wants brackets, the other wants parenthesis.

I still think, though, that you should close your <head> before echoing the player login to the page. So maybe:

<html><head><title></title>
<meta name=GENERATOR content="MSHTML 8.00.7600.16722">
<?php session_start();if(!$_SESSION[myusername]){header("location:main_login.php");} ?>
</head><body>
<p>
 
<?php echo "Player: "."($myusername)"; ?>
Login Successful</p><p>&nbsp;</p><p><a href="../logout.php" target=_self>Log out </a>
</body>

This might work better in the long run.

diafol · Answer 4 · 2011-03-22T00:56:13+00:00

Place session_start() right at the top of the page. header() won't work once you output html or anything else to the page.
Use long tags (<?php instead of <?).
Your HTML looks a little dated. Are you using Word or something?
Where is $myusername being initialised? It doesn't seem to exist, but you're echoing it out.

session_is_registered[myusername]

That's suspect. It waffles on about '['. Looks like your culprit. You should use normal brackets. Perhaps you shouldn't use session_is_registered anyway:

http://php.net/manual/en/function.session-is-registered.php

Sorry Kniggles, but this is a bit of a mess.

Kniggles 0 Light Poster · Answer 5 · 2011-03-22T00:56:44+00:00

?>

<META name=GENERATOR content="MSHTML 8.00.7600.16722">

<?php
session_start();
if(!SESSION[myusername])
  {
  header("location:main_login.php");
  }
?>
   <p>

<?php

 echo "PLAYER: $myusername ";

?>

  </p>

See if this doesn't work a little better.

Parse error: syntax error, unexpected '[' in /home/a4393300/public_html/login_success.php on line 5

:(

Kniggles 0 Light Poster · Answer 6 · 2011-03-22T01:02:50+00:00

Give this a try:

echo "Player: (".$myusername.") Login Successful"

Hi jrotunda85,
thanks for helping your code give me the output

?>

echo "Player: (".$myusername.") Login Successful" Login Successful

:(

Kniggles 0 Light Poster · Answer 7 · 2011-03-22T01:08:27+00:00

<html><head><title></title>
<meta name=GENERATOR content="MSHTML 8.00.7600.16722">
<?php session_start();if(!$_SESSION[myusername]){header("location:main_login.php");} ?>
 
<?php echo "Player: "."($myusername)"; ?>
Login Successful&nbsp;<a href="../logout.php" target=_self>Log out </a>
Okay, try this. :)
The error you saw above was because I substituted a system global variable $_SESSION[] for your PHP function session_is_registered() and one wants brackets, the other wants parenthesis.
I still think, though, that you should close your <head> before echoing the player login to the page. So maybe:
<html><head><title></title>
<meta name=GENERATOR content="MSHTML 8.00.7600.16722">
<?php session_start();if(!$_SESSION[myusername]){header("location:main_login.php");} ?>
</head><body>

 
<?php echo "Player: "."($myusername)"; ?>
Login Successful&nbsp;<a href="../logout.php" target=_self>Log out </a>
</body>
This might work better in the long run.

Player: ()Login Successful

 

Log out

used the 2nd eg. thanks for the close heads tag :)

Kniggles 0 Light Poster · Answer 8 · 2011-03-22T01:20:14+00:00

Place session_start() right at the top of the page. header() won't work once you output html or anything else to the page.
Use long tags (<?php instead of <?).
Your HTML looks a little dated. Are you using Word or something?
Where is $myusername being initialised? It doesn't seem to exist, but you're echoing it out.
session_is_registered[myusername]
That's suspect. It waffles on about '['. Looks like your culprit. You should use normal brackets. Perhaps you shouldn't use session_is_registered anyway:
http://php.net/manual/en/function.session-is-registered.php
Sorry Kniggles, but this is a bit of a mess.

ardav, thanks for your pointers, am finding bits of code all over the net , dont realy quite no what i am doing , just know its fun to play about with computers.
the place where i am at is that players turn up to screen1 and enter name password, then it gos to check_login.php and if right they turn up in login_success.php with there players namebadge.

Kniggles 0 Light Poster · Answer 9 · 2011-03-22T02:02:57+00:00

am now upto

<?php session_start();
$myusername = ($_SESSION(myusername);
if(!$_SESSION(myusername)){header("location:main_login.php");} ?>
  <html><head><title></title>
<meta name=GENERATOR content="MSHTML 8.00.7600.16722">
</head><body>
<p>
 
<?php echo "Player: "."($myusername)"; ?>
Login Successful</p><p>&nbsp;</p><p><a href="../logout.php" target=_self>Log out </a>

with ouput:

Parse error: syntax error, unexpected ';' in /home/a4393300/public_html/login_success.php on line 2

dietdew12z 8 Junior Poster · Answer 10 · 2011-03-22T02:27:17+00:00

First, instead of going to different places on the web and gleaning bits of code you'd be better served going to www.w3schools.com, if you haven't already, and going through their PHP tutorial. It's easy, quick and will give you a good basic understanding of PHP. You'll find very few people here who haven't used w3schools at one time or another.

$_SESSION is a variable array that holds your session data, since it's an array use use [ and ] to specify which value you are wanting. In this case it's myusername so you access the session variable by using $_SESSION[myusername]. In PHP functions you use parenthesis so if you wanted to unset that variable you'd use the function unset($_SESSION[myusername]);

So a function uses ( and ) but a variable array uses [ and ].

Also in line 2, which you probably caught already, you have an extra parenthesis right after the equals. Parentheses always come in pairs so if you count the number of parenthesis it should always be an even number. The number one problem I have when coding is lop-sided parentheses and lop-sided braces.

David

Kniggles 0 Light Poster · Answer 11 · 2011-03-23T06:46:15+00:00

First, instead of going to different places on the web and gleaning bits of code you'd be better served going to www.w3schools.com, if you haven't already, and going through their PHP tutorial. It's easy, quick and will give you a good basic understanding of PHP. You'll find very few people here who haven't used w3schools at one time or another.
$_SESSION is a variable array that holds your session data, since it's an array use use [ and ] to specify which value you are wanting. In this case it's myusername so you access the session variable by using $_SESSION[myusername]. In PHP functions you use parenthesis so if you wanted to unset that variable you'd use the function unset($_SESSION[myusername]);
So a function uses ( and ) but a variable array uses [ and ].
Also in line 2, which you probably caught already, you have an extra parenthesis right after the equals. Parentheses always come in pairs so if you count the number of parenthesis it should always be an even number. The number one problem I have when coding is lop-sided parentheses and lop-sided braces.
David

thanks David, very helpfull, found the bits i was looking for at via www.w3schools.com .

Kniggles 0 Light Poster · Answer 12 · 2011-03-23T06:58:42+00:00

As diet says: $_SESSION(myusername) should be $_SESSION['myusername'] When you were using session_is_registered[myusername] should have been session_is_registered("myusername") As for getting bits from all over and not knowing what you're doing. PLEASE, get a downloadable copy of the php manual from the php.net site. It'll save you (and possibly others) a lot of time. Most of the errors can be checked directly in the manual when using certain functions.

as much as i enjoy trying to read i find it very hard to understand what i have read, i find it easier to play about learning by trial n error bitzing together diffrent code into easy to solve problems that ($X) , this is producing a libary of code that i hope will help others with learning annykey :icon_idea:

Recall

Recommended Answers Collapse Answers

All 16 Replies

Recommended Answers