save error

[davy_yg]

input_berita_static.php

$id = isset($_POST['id']) ? $_POST['id'] : '';  
	$confirmation = isset($_POST['confirmation']) ? $_POST['confirmation'] : '';  
	$kategori = isset($_POST['kategori']) ? $_POST['kategori'] : ''; 
	$news = isset($_POST['isi_berita']) ? $_POST['isi_berita'] : '';
	$judul = isset($_POST['judul']) ? $_POST['judul'] : ''; 
	$page = isset($_POST['page']) ? $_POST['page'] : '';
	
	//Load berita
	if (!empty($_REQUEST['id'])){
		$result = mysql_query("SELECT * FROM static_page WHERE id =".$_REQUEST['id']) or die(mysql_error());
		$data = mysql_fetch_array($result);
		$id = $data['id'];
		$page = $data['page'];
		$judul = $data['judul'];
		$news = $data['isi_berita'];
	}
	
	//Simpan berita dan konfirmasi kepada subscriber
	if (isset($_REQUEST['ok'])){
		$page = $_REQUEST['page'];
		$judul = $_REQUEST['judul'];
		$news = $_REQUEST['isi_berita'];
		if (empty($_REQUEST['id']))
			$sqlstr = "INSERT INTO static_page(page, judul, isi_berita)VALUES('".$page."','".$judul."','".$news."')";
		else
			$sqlstr = "UPDATE berita SET page='".$page."', judul='".$judul."', isi_berita='".$news."' WHERE id=".$_REQUEST['id'];
		$result = mysql_query($sqlstr) or die(mysql_error());
		
		//Jika mode edit, maka tidak akan dikirimkan konfirmasi kepada subscriber
		//if (empty($_REQUEST['id']))	kirimEmail($idKategori, $judul, $news);
		$confirmation = ($result) ? "Data telah tersimpan." : "Gagal menyimpan data.";	
	}
	?>
	<div align="center">
		<div style="width:800px;text-align:left;">
		<script type="text/javascript" src="ckeditor/ckeditor.js"></script>
		<link href="ckeditor/content.css" rel="stylesheet" type="text/css"/>
		<?php echo $confirmation;?>
		<form method="post" action="<?php $_SERVER['PHP_SELF']?>">
			<input type="hidden" name="id" value="<?php echo $id; ?>"/>
			<table>
				<tr>
                    <td>Page</td>				
					<td><input size="50px" type="text" name="page" value="<?php echo $page; ?>"/></td>
				</tr>
                <tr>
                    <td>Judul</td>				
					<td><input size="50px" type="text" name="judul" value="<?php echo $judul; ?>"/></td>
				</tr>
				<tr>
					<td valign="top">Isi berita</td>				
					<td>
						<textarea cols="60" rows="10" id="news" name="news"><?php echo $news;?></textarea>
						<script type="text/javascript">
							var editor = CKEDITOR.replace('news');
						</script>					</td>
				</tr>
				<tr>				
					<td><input type="submit" name="ok" value="Simpan"/></td>
			  </tr>
			</table>
		</form>
		</div>
	</div>

Notice: Undefined index: isi_berita in C:\xampp\htdocs\php_template2\input_berita_static.php on line 23
Unknown column 'page' in 'field list'

I receive the above error after I press "Simpan" (translate: save button).
Why is it?

[cwarn23]

Note the $_REQUEST array should never be used due to security problems such as injections. Instead use the $_GET or $_POST arrays/tags.

$news = (isset($_REQUEST['isi_berita']))?$_REQUEST['isi_berita']:'';

[davy_yg]

I did it correctly in my PHP syntax, didn't I ?

[cwarn23]

Actually lines 21 to 23 can be deleted because those variables are assigned the same values at the start of the script.

[davy_yg]

Well, if I delete those script, the following error appears:

Notice: Undefined variable: idKategori in C:\xampp\htdocs\Masterlink\cgoods\input_berita.php on line 120

Notice: Undefined variable: news in C:\xampp\htdocs\Masterlink\cgoods\input_berita.php on line 120

[ko ko]

What is it on line 120 ? Post that line.

[davy_yg]

Nevermind, it works for the above code (input_berita_static.php). I get it alter with my other page script (input_berita.php) which may be a similar case:

input_berita.php

$id = isset($_POST['id']) ? $_POST['id'] : '';  
	$confirmation = isset($_POST['confirmation']) ? $_POST['confirmation'] : '';  
	$kategori = isset($_POST['kategori']) ? $_POST['kategori'] : ''; 
	$isiBerita = isset($_POST['isiBerita']) ? $_POST['isiBerita'] : '';
	$judul = isset($_POST['judul']) ? $_POST['judul'] : ''; 
	
	
	//Load berita
	if (!empty($_REQUEST['id'])){
		$result = mysql_query("SELECT * FROM berita WHERE id =".$_REQUEST['id']) or die(mysql_error());
		$data = mysql_fetch_array($result);
		$id = $data['id'];
		$judul = $data['judul'];
		$isiBerita = $data['isi_berita'];
	}
	
	//Simpan berita dan konfirmasi kepada subscriber
	if (isset($_REQUEST['ok'])){
		//$judul = $_REQUEST['judul'];
		//$news = $_REQUEST['news'];
		//$idKategori = $_REQUEST['kategori'];
		$tanggal = date('Y-m-d');
		if (empty($_REQUEST['id']))
			$sqlstr = "INSERT INTO berita(id_kategori, judul, isi_berita, tanggal)VALUES('".$idKategori."','".$judul."','".$news."','".$tanggal."')";
		else
			$sqlstr = "UPDATE berita SET judul='".$judul."', isi_berita='".$news."' WHERE id=".$_REQUEST['id'];
		$result = mysql_query($sqlstr) or die(mysql_error());
		
		//Jika mode edit, maka tidak akan dikirimkan konfirmasi kepada subscriber
		//if (empty($_REQUEST['id']))	kirimEmail($idKategori, $judul, $news);
		$confirmation = ($result) ? "Data telah tersimpan." : "Gagal menyimpan data.";	
	}

See, if I take off the

//$judul = $_REQUEST;
//$news = $_REQUEST;
//$idKategori = $_REQUEST;

there will be error on line 26 (for the above code) / 120 (for my page)

$sqlstr = "INSERT INTO berita(id_kategori, judul, isi_berita, tanggal)VALUES('".$idKategori."','".$judul."','".$news."','".$tanggal."')";

Notice: Undefined variable: idKategori in C:\xampp\htdocs\Masterlink\cgoods\input_berita.php on line 120

Notice: Undefined variable: news in C:\xampp\htdocs\Masterlink\cgoods\input_berita.php on line 120