LightGallery count wrong number of images

Question

0

LightGallery is counting wrong number of images.. here is jsfiddle code... In this jsfiddle i am append dynamical element with a div that is in html file.. Please check manually ... Why lightgallery is count wrong images ?

encoding error javascript jquery script

2

Contributors

8

Replies

36

Views

2 Years

Discussion Span

2 Years Ago

Last Post by mintu_2

This Question has been Answered

0

here go..

encoding error javascript jquery script

rproffitt 1,126 · Answer 1 · 2015-12-18T00:00:52+00:00

for(var i =0;i<=imagesarray.length-1;i++){

Changed line 12?

mintu_2 · Answer 2 · 2015-12-18T12:42:32+00:00

why i should do that ?

rproffitt 1,126 · Answer 3 · 2015-12-18T14:33:15+00:00

If you have 5 items and then loop 0 to 5. That's one too many.

Your choice of -1 or change i<= to i< whichever you can wrap your head around. The right way would be to drop the = sign but the key item is for you to think of the array count is one number and arrays start at zero so think about that.

mintu_2 · Answer 4 · 2015-12-18T17:27:46+00:00

https://github.com/sachinchoolur/lightGallery/issues/261

rproffitt 1,126 · Answer 5 · 2015-12-18T17:57:37+00:00

That's the same code as above. Sorry but you need to think about your for loop harder.

An array of 5 items is indexed from 0 to 4. You have it from 0 to 5 so that's not 5 but 6. Keep thinking, you'll get it soon.

mintu_2 · Answer 6 · 2015-12-18T17:59:07+00:00

yes i understand that but the problem is here https://github.com/sachinchoolur/lightGallery/issues/261#issuecomment-165817258 Please read this comment.

rproffitt 1,126 · Answer 7 · 2015-12-18T19:41:15+00:00

So is this a new issue? Your topic is "i have 5 imges and lightgallery shows 6 images." If you have a new issue, state it in a new thread so we can tackle that.