my program text file do not display properly. Please help...

Question

bobei89 4 Light Poster

16 Years Ago

Please help me... after the execution of the program. It write the new information to it.
However, the .txt file do not display the new information properly. (The index number stick with the name...). It is a half work program. Please help me solve this problem or else i cannot continue to finish whole program. :(

#include<stdio.h>
#define size 99

void maintenance();

struct newI{
	char iN[9];
	char name[50];
	char gender;
};

void main()
{
	FILE *buffer1;
	buffer1 = fopen("students.txt", "w+");

	fprintf(buffer1,"Index Number          Name                         Gender");
	fprintf(buffer1,"\n11228ADIA             Alice Lim                       F  ");
	fprintf(buffer1,"\n12233ADIB             Mike Chan                       M  ");
	fprintf(buffer1,"\n13244BASD             Bobby                           M  ");
	fprintf(buffer1,"\n43134QWER             Cheh Yen Lun                    M  ");
	fprintf(buffer1,"\n56354VBFG             Choong Wen Loong                M  ");
	fprintf(buffer1,"\n47344FGKJ             Chin Pau Soon                   M  ");
	
	fclose(buffer1);
	printf("File students.txt created!!!\n");
	maintenance();
}

void maintenance()
{
	struct newI newS[size];
	int i=0;
	char response;
	char response2;

	printf("To add new information key \'Y\' else press any key to skip>>>");
	response=getchar();
	if(response == 'Y' || response == 'y');
	{
		FILE *buffer2;
		buffer2 = fopen("students.txt", "a+");

		do
		{
			i++;
			printf("\nFor student #%d",i);
			printf("\nEnter student's index number>>>");
			fflush(stdin);
			gets(newS[i].iN);
			printf("\nEnter student's name>>>");
			fflush(stdin);
			gets(newS[i].name);
			printf("\nEnter student's gender(either *M* for male or *F* for female only)!!!>>>");
			fflush(stdin);
			scanf("%c",&newS[i].gender);
			while(newS[i].gender!='M' && newS[i].gender!='F')
			{
				printf("\nInvalid input for gender.\nPlease reenter a proper gender as shown>>>");
				fflush(stdin);
				scanf("%c",&newS[i].gender);
			}

			printf("\nDo you still wish to add more student's information");
			printf("\nTo add new information key \'Y\' else press any key to skip>>>");
			fflush(stdin);
			response2=getchar();
			fprintf(buffer2,"\n");
			fprintf(buffer2,"%s", newS[i].iN);
			fprintf(buffer2,"                              %s", newS[i].name);
			fprintf(buffer2,"                                                             %c", newS[i].gender);
		}while(response2=='y' || response2=='Y');
		fclose(buffer2);
	}
}

c

5 Contributors
23 Replies
658 Views
1 Day Discussion Span
Latest Post 16 Years Ago Latest Post by bobei89

All 23 Replies

iamthwee

16 Years Ago

Put some printf(s) in strategic places to help you find out where you are going wrong.

Using fllush(stdin) and gets() probably doesn't help matters... And void main http://faq.cprogramming.com/cgi-bin/smartfaq.cgi?answer=1052863818&id=1043284351
http://faq.cprogramming.com/cgi-bin/smartfaq.cgi?answer=1049157810&id=1043284351
http://faq.cprogramming.com/cgi-bin/smartfaq.cgi?answer=1044841143&id=1043284376

Salem commented: A FAQ bonanza (Mr Cartwright) +14

Ancient Dragon 5,243 Achieved Level 70

16 Years Ago

line 39: remove the semicolon at the end

Ancient Dragon 5,243 Achieved Level 70

16 Years Ago

This is the contents of the file that I got after correcting the program

Index Number          Name                         Gender
11228ADIA             Alice Lim                       F  
12233ADIB             Mike Chan                       M  
13244BASD             Bobby                           M  
43134QWER             Cheh Yen Lun                    M  
56354VBFG             Choong Wen Loong                M  
47344FGKJ             Chin Pau Soon                   M  

                              Melvin
                                                             M

                              Sandra
                                                             F

#include<stdio.h>
#include <ctype.h>
#define size 99

void maintenance();

struct newI{
	char iN[9];
	char name[50];
	char gender;
};

int main()
{
	FILE *buffer1;
	buffer1 = fopen("students.txt", "w+");

	fprintf(buffer1,"Index Number          Name                         Gender");
	fprintf(buffer1,"\n11228ADIA             Alice Lim                       F  ");
	fprintf(buffer1,"\n12233ADIB             Mike Chan                       M  ");
	fprintf(buffer1,"\n13244BASD             Bobby                           M  ");
	fprintf(buffer1,"\n43134QWER             Cheh Yen Lun                    M  ");
	fprintf(buffer1,"\n56354VBFG             Choong Wen Loong                M  ");
	fprintf(buffer1,"\n47344FGKJ             Chin Pau Soon                   M  ");
	
	fclose(buffer1);
	printf("File students.txt created!!!\n");
	maintenance();
             return 0;
}

void maintenance()
{
	struct newI newS[size];
	int i=0;
	char response;
	char response2;

	printf("To add new information key \'Y\' else press any key to skip>>>");
	response=getchar();
	if(response == 'Y' || response == 'y')
	{
		FILE *buffer2;
		buffer2 = fopen("students.txt", "a+");

		do
		{
			i++;
			printf("\nFor student #%d",i);
			printf("\nEnter student's index number>>>");
			fflush(stdout);
			fgets(newS[i].iN, sizeof(newS[i].iN), stdin);
			printf("\nEnter student's name>>>");
			fflush(stdout);
			fgets(newS[i].name, sizeof(newS[i].name), stdin);
			printf("\nEnter student's gender(either *M* for male or *F* for female only)!!!>>>");
			fflush(stdout);
			scanf("%c",&newS[i].gender);
			getchar(); // flush stdin of the '\n' character
			newS[i].gender = toupper(newS[i].gender);
			while(newS[i].gender!='M' && newS[i].gender!='F')
			{
				printf("\nInvalid input for gender.\nPlease reenter a proper gender as shown>>>");
				fflush(stdout);
				scanf("%c",&newS[i].gender);
			}

			printf("\nDo you still wish to add more student's information");
			printf("\nTo add new information key \'Y\' else press any key to skip>>>");
			fflush(stdout);
			response2=getchar();
			fprintf(buffer2,"\n");
			fprintf(buffer2,"%s", newS[i].iN);
			fprintf(buffer2,"                              %s", newS[i].name);
			fprintf(buffer2,"                                                             %c", newS[i].gender);
		}while(response2=='y' || response2=='Y');
		fclose(buffer2);
	}
}

Aia commented: Must report you as a hard worker. ;) Hopefully poster will understand what are the changes. +4

Ancient Dragon 5,243 Achieved Level 70

16 Years Ago

see lines 71 and 72 -- you have way too many spaces there. Remove all those spaces and I'll bet the gender will appear on the same line as the name. Its only a display thing -- the lines are too long so the os wraps them around.

If you want to create fixed length fields for the data then use the field-width specifiers in the print statement. printf("%15s", name); will print the name in a field of 15 characters left padded with spaces. use "%-15s" and it will be right padded with spaces.

Ancient Dragon 5,243 Achieved Level 70

16 Years Ago

line 45: remove the semicolon at the end

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

Must report you as a hard worker. ;) Hopefully poster will understand what are the changes.

bobei89 4 Light Poster · Answer 1 · 2007-12-29T23:34:37+00:00

sigh~ i really got no idea where is the problem... :(

bobei89 4 Light Poster · Answer 2 · 2007-12-29T23:56:40+00:00

now i think that index number have accept the name as a part of it....but why??? since i put different variable.

bobei89 4 Light Poster · Answer 3 · 2007-12-30T12:50:27+00:00

Okay, thankyou Ancient Dragon...it finally work but another problem occurred...:(
Here is my new code:

#include<stdio.h>
#define size 99

void maintenance();

struct newI{
	char iN[10];
	char name[50];
	char gender;
};

void main()
{
	FILE *buffer1;
	buffer1 = fopen("students.txt", "w+");

	fprintf(buffer1,"Index Number          Name                         Gender");
	fprintf(buffer1,"\n11228ADIA             Alice Lim                       F  ");
	fprintf(buffer1,"\n12233ADIB             Mike Chan                       M  ");
	fprintf(buffer1,"\n13244BASD             Bobby                           M  ");
	fprintf(buffer1,"\n43134QWER             Cheh Yen Lun                    M  ");
	fprintf(buffer1,"\n56354VBFG             Choong Wen Loong                M  ");
	fprintf(buffer1,"\n47344FGKJ             Chin Pau Soon                   M  ");
	
	fclose(buffer1);
	printf("File students.txt created!!!\n");
	maintenance();
}

void maintenance()
{
	struct newI newS[size];
	int i=0;
	char response;
	char response2;

	printf("To add new information key \'Y\' else press any key to skip>>>");
	response=getchar();
	if(response == 'Y' || response == 'y');
	{
		FILE *buffer2;
		buffer2 = fopen("students.txt", "a");

		do
		{
			i++;
			printf("\nFor student #%d",i);
			printf("\nEnter student's index number>>>");
			fflush(stdin);
			fgets(newS[i].iN,(sizeof newS[i].iN),stdin);
			printf("\nEnter student's name>>>");
			fflush(stdin);
			fgets(newS[i].name,(sizeof newS[i].iN),stdin);
			printf("\nEnter student's gender(either *M* for male or *F* for female only)!!!>>>");
			fflush(stdin);
			newS[i].gender=getchar();
			while(newS[i].gender!='M' && newS[i].gender!='F')
			{
				printf("\nInvalid input for gender.\nPlease reenter a proper gender as shown>>>");
				fflush(stdin);
				newS[i].gender=getchar();
			}

			printf("\nDo you still wish to add more student's information");
			printf("\nTo add new information key \'Y\' else press any key to skip>>>");
			fflush(stdin);
			response2=getchar();
			fflush(stdin);
			fprintf(buffer2,"\n");
			fprintf(buffer2,"%s", newS[i].iN);
			fprintf(buffer2,"             %s", newS[i].name);
			fprintf(buffer2,"                       %c", newS[i].gender);
		}while(response2=='y' || response2=='Y');
		fclose(buffer2);
	}
}

Another frustration~~:(

The output of .txt file is:

Index Number Name Gender
11228ADIA Alice Lim F
12233ADIB Mike Chan M
13244BASD Bobby M
43134QWER Cheh Yen Lun M
56354VBFG Choong Wen Loong M
47344FGKJ Chin Pau Soon M
1234ASDFA bobby
M
1234ASDFA sifa fu
F

Why the gender will display in another newline...is not what i want. :(

bobei89 4 Light Poster · Answer 4 · 2007-12-30T20:06:43+00:00

Okay i try it out, but it messed up also... :(

Here what i change:

#include<stdio.h>
#define size 99

void maintenance();

struct newI{
	char iN[10];
	char name[50];
	char gender;
};

void main()
{
	FILE *buffer1;
	buffer1 = fopen("students.txt", "w");

	fprintf(buffer1,"Index Number          Name                         Gender");
	fprintf(buffer1,"\n11228ADIA             Alice Lim                       F  ");
	fprintf(buffer1,"\n12233ADIB             Mike Chan                       M  ");
	fprintf(buffer1,"\n13244BASD             Bobby                           M  ");
	fprintf(buffer1,"\n43134QWER             Cheh Yen Lun                    M  ");
	fprintf(buffer1,"\n56354VBFG             Choong Wen Loong                M  ");
	fprintf(buffer1,"\n47344FGKJ             Chin Pau Soon                   M  ");
	fprintf(buffer1,"\n");
	
	fclose(buffer1);
	printf("File students.txt created!!!\n");
	maintenance();
}

void maintenance()
{
	struct newI newS[size];
	int i=0;
	char response;
	char response2;
	
	fflush(stdout);
	fflush(stdin);
	printf("To add new information key \'Y\' else press any key to skip>>>");
	response=getchar();
	if(response == 'Y' || response == 'y');
	{
		FILE *buffer2;
		buffer2 = fopen("students.txt", "a+");

		do
		{
			i++;
			printf("\nFor student #%d",i);
			printf("\nEnter student's index number>>>");
			fflush(stdin);
			fgets(newS[i].iN,(sizeof newS[i].iN),stdin);
			printf("\nEnter student's name>>>");
			fflush(stdin);
			fgets(newS[i].name,(sizeof newS[i].name),stdin);
			printf("\nEnter student's gender(either *M* for male or *F* for female only)!!!>>>");
			fflush(stdin);
			newS[i].gender = getchar();
			while(newS[i].gender!='M' && newS[i].gender!='F')
			{
				fflush(stdin);
				printf("\nInvalid input for gender.\nPlease reenter a proper gender as shown>>>");
				newS[i].gender = getchar();
			}

			printf("\nDo you still wish to add more student's information");
			printf("\nTo add new information key \'Y\' else press any key to skip>>>");
			fflush(stdin);
			response2=getchar();
			fflush(stdin);
			fprintf(buffer2,"%s",newS[i].iN);
			fprintf(buffer2,"%17s",newS[i].name);
			fprintf(buffer2,"%25c",newS[i].gender);
		}while(response2=='y' || response2=='Y');
		fclose(buffer2);
	}
}

output more worst::::
Index Number Name Gender
11228ADIA Alice Lim F
12233ADIB Mike Chan M
13244BASD Bobby M
43134QWER Cheh Yen Lun M
56354VBFG Choong Wen Loong M
47344FGKJ Chin Pau Soon M
ASDFA1234 Siu Choong
MASDFA1234 Wendy
F

bobei89 4 Light Poster · Answer 5 · 2007-12-30T20:16:48+00:00

bobei89 4 Light Poster

16 Years Ago

got error after remove it the ';' semicolon...

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 6 · 2007-12-30T20:25:42+00:00

The reason for the wierd behavior is because fgets() appends the '\n' from keyboard input to the end of the string, so you need to remove it. Here is one way to do it

void fixup(char *s)
{
	if(s[strlen(s)-1] == '\n')
		s[strlen(s)-1] = 0;
}

...
			fgets(newS[i].iN,(sizeof newS[i].iN),stdin);
			fixup(newS[i].iN);

Just call fixup() after each fgets() to strip out the '\n' character.

void main()
That is a big no-no. main() always returns an int so it should be declared int main() . Just because your compiler may accept void doesn't mean it is correct.

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 7 · 2007-12-30T20:26:28+00:00

got error after remove it the ';' semicolon...

sorry, wrong line number. should be line 42.

bobei89 4 Light Poster · Answer 8 · 2007-12-30T20:27:53+00:00

line45: buffer2 = fopen("students.txt", "a+");

the semicolon after remove have error. :(

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 9 · 2007-12-30T20:33:24+00:00

line45: buffer2 = fopen("students.txt", "a+");
the semicolon after remove have error. :(

see my post #13 above

bobei89 4 Light Poster · Answer 10 · 2007-12-30T20:43:49+00:00

Sorry for double posting the same thing..i miss your post #13. About the fixup() function you written, i thought the fflush(stdin) will work the same thing, clear input.

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 11 · 2007-12-30T20:50:39+00:00

fflush(stdin) is non standard -- the fflush() function is only intended for output streams, not input streams, although some compilers use non-standard extension. In any event, fflush() does not affect the input by fgets() function because fgets() removes everything up to and including the '\n' character assuming there is room for the characters in the input buffer.

bobei89 4 Light Poster · Answer 12 · 2007-12-30T20:59:29+00:00

erm, i don't know if i right, if the fgets() will removes everything up, then why would the program still append the '\n'?

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 13 · 2007-12-30T21:15:22+00:00

fgets() adds the '\n' to the string because its in the keyboard buffer along with all the other keys that you type.

bobei89 4 Light Poster · Answer 14 · 2007-12-30T21:21:22+00:00

okay, i try to understand your fixup funtion first. Hope it work... :)

bobei89 4 Light Poster · Answer 15 · 2007-12-30T22:05:39+00:00

OMG this is the problem i get while use the functions
warning C4013: 'strlen' undefined; assuming extern returning int

Narue 5,707 Bad Cop Team Colleague · Answer 16 · 2007-12-30T22:11:48+00:00

>warning C4013: 'strlen' undefined; assuming extern returning int
Make sure to add #include <string.h> to your code.

Aia 1,977 Nearly a Posting Maven · Answer 17 · 2007-12-30T22:12:17+00:00

OMG this is the problem i get while use the functions
warning C4013: 'strlen' undefined; assuming extern returning int

strlen() is defined in the header file string.h. #include <string.h>

bobei89 4 Light Poster · Answer 18 · 2007-12-30T23:58:45+00:00

bobei89 4 Light Poster

16 Years Ago

oh yeah. It work. ThankYou all

my program text file do not display properly. Please help...

Recommended Answers Collapse Answers

All 23 Replies

Recommended Answers