Help with what should be a very simple code task.

Question

Grimshad 0 Newbie Poster

15 Years Ago

I'm looking for some help with some C++ code. I have working knowledge and understanding of code and coding in general, but don't actually program myself.

I have 2 files

TFGame

and

TFMenuConsole

In TFGame I put

var config bool ToggleWarhead;

and later put

PlayInfo.AddSetting(default.GameGroup, "ToggleWarhead",    default.SIGPropsDisplayText[i++], 0,  1, "Check",        ,,     , true);

To my knowledge, this will create the variable ToggleWarhead and then add a check box to the settings menu to toggle this variable true or false (default being true) and also display the string value that is set for SIGPropsDisplayText for the setting name.

In TFMenuConsole I put

case SMS_Construction:
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
            		SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
	            if(tfgame.ToggleWarhead == True)
			        {
			            SMNameArray[6] = "Warhead (3000/180)";
			            SMIndexArray[6] = 7;
			        }
			SMArraySize=7;
			break;

Which should Check if the variable ToggleWarhead in the File TFGame is true, if it is then it will execute array number 6, if not then it should skip it and Warhead should be left out of the Array.

When I try to compile I get this

"Error, Bad or Missing Expression in 'if'

So I have 2 questions
1. Should my code for the if statement on the array include the difference in array size like so?:

case SMS_Construction:
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
            		SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
	            if(tfgame.ToggleWarhead == True)
			        {
			            SMNameArray[6] = "Warhead (3000/180)";
			            SMIndexArray[6] = 7;
                                    SMArraySize=7;
			        }
			SMArraySize=6;
			break;

and 2. What am I doing wrong? why is it not working?

I'm sure it is because of the format I put the if statement in, I am not used to C++ and I only understand code, I don't actually know how to code.

Any help would be greatly appreciated.
I can also provide the source files if your willing to help me solve this.

Thanks,
Grim

c++

7 Contributors
15 Replies
180 Views
23 Hours Discussion Span
Latest Post 15 Years Ago Latest Post by Grimshad

All 15 Replies

Ancient Dragon 5,243 Achieved Level 70

15 Years Ago

If you want any responoses you need to state the compiler and operating system you are working with.

ddanbe 2,724 Professional Procrastinator

15 Years Ago

It seems weird to me that a method called AddSettings would create a global variable you declared earlier.

u8sand 68 Junior Poster

15 Years Ago

dono what this does really but who knows its worth a try

if(tfgame.ToggleWarhead == True)
			        {
			            SMNameArray[6] = "Warhead (3000/180)";
			            SMIndexArray[6] = 7;
                                    SMArraySize=7;
			        }

maybe replace True with true?

just to be safe just make it:

if(tfgame.ToggleWarhead)
			        {
			            SMNameArray[6] = "Warhead (3000/180)";
			            SMIndexArray[6] = 7;
                                    SMArraySize=7;
			        }

maybe that works?

ddanbe commented: Nice! True is not always true. +3

Bench 212 Posting Pro

15 Years Ago

In the latest code you posted, you're using the case keyword after an if statement. case is intended to be used in conjunction with switch, and is meaningless on its own.

Perhaps you could also show the declaration of your tfgame object, and the declaration for ToggleWarhead

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

Grimshad 0 Newbie Poster · Answer 1 · 2009-01-04T03:59:58+00:00

Thanks for the responses.

OS: V Extreme
Compiler: UCC

I tried running with the True uncapitalized

Same Error

I tried with the new array size in the if statement

Same Error

I tried without the == true

Same Error

I also tried putting the whole array into the if

    if(tfgame.ToggleWarhead == true)
           {
     case SMS_Construction:
        SMNameArray[0] = "Shield (50/30)";
        SMIndexArray[0] = 1;
                SMNameArray[1] = "Protector (200/30)";
        SMIndexArray[1] = 2;
        SMNameArray[2] = "Portal (200/30)";
        SMIndexArray[2] = 3;
        SMNameArray[3] = "Armory (200/60)";
        SMIndexArray[3] = 4;
        SMNameArray[4] = "Generator (300/60)";
        SMIndexArray[4] = 5;
        SMNameArray[5] = "Outpost (600/90)";
        SMIndexArray[5] = 6;
        SMArraySize=6;
    else
     case SMS_Construction:
        SMNameArray[0] = "Shield (50/30)";
        SMIndexArray[0] = 1;
                SMNameArray[1] = "Protector (200/30)";
        SMIndexArray[1] = 2;
        SMNameArray[2] = "Portal (200/30)";
        SMIndexArray[2] = 3;
        SMNameArray[3] = "Armory (200/60)";
        SMIndexArray[3] = 4;
        SMNameArray[4] = "Generator (300/60)";
        SMIndexArray[4] = 5;
        SMNameArray[5] = "Outpost (600/90)";
        SMIndexArray[5] = 6;
        SMNameArray[6] = "Warhead (3000/180)";
        SMIndexArray[6] = 7;
        SMArraySize=7;
         }

I added

var string ToggleWarhead;

to the beginning of the TFMenuConsole file to test if the error is when the variable is being called from the other file and when I tried to compile it returned

Error, Type mismatch in 'if'

Just found out that Bool meant True or False so I changed it to

var bool ToggleWarhead;

and i get

Error, class is not allowed here

It has to be the code itself, if someone could just lo ok at it for me and tell me what im doing wrong

Grimshad 0 Newbie Poster · Answer 2 · 2009-01-04T04:28:53+00:00

I've attached the 2 files

In TFGame the Variable ToggleWarhead is added on line 15

In TFMenuConsole the variable needs to be used on line 1068

In TFGame the variable is created and used in Pre game settings menu where a check box toggles it true/false

In TFMenuConsole the If statement I am trying to impliment will remove the Warhead entry from the in game menu if ToggleWarhead is true, and will leave it there if it is false.

I noticed you said "tfgame object" I exported all objects from my file and there is a tfgame object and tfgame.ToggleWarhead object, they say:

Begin Object Class=Class Name=TFGame
End Object

and

Begin Object Class=BoolProperty Name=ToggleWarhead
End Object

I don't think this has anything to do with my problem though.

I appreciate the help Bench

Grimshad 0 Newbie Poster · Answer 3 · 2009-01-04T05:53:40+00:00

This was quoted by someone who knows C++

"you are trying to use a class without firstly implementig it's creation, or loading it from somewhere"

but to my knowledge its creation is in the file TFGame

he also said

"you can't just put filename.variable and expect the compiler to know what your talking about"

Comatose 290 Taboo Programmer Team Colleague · Answer 4 · 2009-01-04T07:39:33+00:00

Sure, but your if statement is looking for if(tfgame.ToggleWarhead == True) which from what I can tell is not the name of your class. Unless I've been living in *nix too long, and case doesn't matter any more: class TFGame extends xTeamGame;

Grimshad 0 Newbie Poster · Answer 5 · 2009-01-04T08:06:49+00:00

I changed it to

if(TFGame.ToggleWarhead == true)
               {
		 case SMS_Construction:
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
            		SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
			SMArraySize=6;
	    else
		 case SMS_Construction:
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
		        SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
			SMNameArray[6] = "Warhead (3000/180)";
			SMIndexArray[6] = 7;
			SMArraySize=7;
             }

Still gives me the same error, Bad or Missing Expression in 'if'

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 6 · 2009-01-04T08:14:55+00:00

The case statements are irrelevent -- they do absolutely nothing, so you should just delete them.

if(TFGame.ToggleWarhead == true)
               {
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
            		SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
			SMArraySize=6;
           }
	    else
          {
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
		        SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
			SMNameArray[6] = "Warhead (3000/180)";
			SMIndexArray[6] = 7;
			SMArraySize=7;
             }

Grimshad 0 Newbie Poster · Answer 7 · 2009-01-04T08:48:29+00:00

AncientDragon, im sure theres a lot of sloppy code here.

But your comment didn't really help me get closer to my goal, of making the variable ToggleWarhead global so that i can use it in the file i need to use it in as an if statement

Thanks Though

Murtan 317 Practically a Master Poster · Answer 8 · 2009-01-04T11:14:44+00:00

The if and else need to be 'inside' the case, and the if block and else block need their own set of braces { }. if (test) { // code } else { // more code }

case SMS_Construction:
			if(tfgame.ToggleWarhead == true)
			{
				SMNameArray[0] = "Shield (50/30)";
				SMIndexArray[0] = 1;
				SMNameArray[1] = "Protector (200/30)";
				SMIndexArray[1] = 2;
				SMNameArray[2] = "Portal (200/30)";
				SMIndexArray[2] = 3;
				SMNameArray[3] = "Armory (200/60)";
				SMIndexArray[3] = 4;
				SMNameArray[4] = "Generator (300/60)";
				SMIndexArray[4] = 5;
				SMNameArray[5] = "Outpost (600/90)";
				SMIndexArray[5] = 6;
				SMArraySize=6;
			}
			else
			{
				SMNameArray[0] = "Shield (50/30)";
				SMIndexArray[0] = 1;
				SMNameArray[1] = "Protector (200/30)";
				SMIndexArray[1] = 2;
				SMNameArray[2] = "Portal (200/30)";
				SMIndexArray[2] = 3;
				SMNameArray[3] = "Armory (200/60)";
				SMIndexArray[3] = 4;
				SMNameArray[4] = "Generator (300/60)";
				SMIndexArray[4] = 5;
				SMNameArray[5] = "Outpost (600/90)";
				SMIndexArray[5] = 6;
				SMNameArray[6] = "Warhead (3000/180)";
				SMIndexArray[6] = 7;
				SMArraySize=7;
			}

But this should work too and be a lot smaller:

case SMS_Construction:
			SMNameArray[0] = "Shield (50/30)";
			SMIndexArray[0] = 1;
			SMNameArray[1] = "Protector (200/30)";
			SMIndexArray[1] = 2;
			SMNameArray[2] = "Portal (200/30)";
			SMIndexArray[2] = 3;
			SMNameArray[3] = "Armory (200/60)";
			SMIndexArray[3] = 4;
			SMNameArray[4] = "Generator (300/60)";
			SMIndexArray[4] = 5;
			SMNameArray[5] = "Outpost (600/90)";
			SMIndexArray[5] = 6;
			SMArraySize=6;
			if(tfgame.ToggleWarhead == true)
			{
				SMNameArray[6] = "Warhead (3000/180)";
				SMIndexArray[6] = 7;
				SMArraySize=7;
			}

PS- please use c++ language code tags when posting c++ source
[code=c++] // your code here

[/code]

Murtan 317 Practically a Master Poster · Answer 9 · 2009-01-04T11:27:02+00:00

After a little further searching, I don't see that any of the 'config' values from TFGame.uc (other than the one you are trying to add) are being used in TFMenuConsole anywhere.

Grimshad 0 Newbie Poster · Answer 10 · 2009-01-04T11:52:02+00:00

Ok I found out some more info.

All of the other variables listed at the top of TFGame are in this format when being pulled by other files

if(tfgame(level.Game).variable == true)

When i use

if(tfgame(level.Game).ToggleWarhead == true)

the compiler returns

Error, Bad or Missing Expression in 'if'

If i add

local tfgame warhead

to the rest of the locals in TFMenuConsole

and then use

if(warhead.ToggleWarhead == true)

then the code compiles fine, but it doesn't actually do anything in the game. I'm assuming this is because the local object I just created is blank.

Grimshad 0 Newbie Poster · Answer 11 · 2009-01-04T12:45:37+00:00

Ok, first ide like to thank everyone here
second, ide like to say im sorry because I didn't know what i was talking about

third, its fixed

if(class 'TFGame'.default.ToggleWarhead == True)

that worked, cuz there are no global variables in this script :)

Help with what should be a very simple code task.

Recommended Answers Collapse Answers

All 15 Replies

Recommended Answers