I am taking an intermediate programming class, after a somewhat long hiatus. One of the first projects is a somewhat simple assignment that takes a date from the user, and checks to see if it is valid, using classes. I have been working on it for a while, and i seem to be making no progress lately. My current problem is that as soon as i start the program, the program halts, saying that "variable month1 is being used without being defined". I cannot figure out what my problem is, but i suspect that it is something simple. I understand how to create the program, i just get tripped up on the syntax and the implementation of it. Any help is appreciated


Program, the commented out portions are things i am having trouble with, and that i have removed for testing purposes

//a C++ program that accepts a day and month from the user (2005 as the year), checks that they are valid, 
//displays the date entered in MM/DD/CCYY format and displays the date

#include "stdafx.h"
using namespace std;


class dateReport

{

    private:

           int day;

           int month;

           int year;

    public:

			 dateReport(); // constructor

     bool    CheckDate(int day1, int month1);

};
bool CheckDate( int day1, int month1)
{
	int day1, month1 = 0;


		if (month1 > 12 || month1 < 1)
			{
				cout << "Enter A  Valid Month" << endl;
				return false;
			}
// Supposed to check whether or not the day entered is valid.
//Commented out due to it causing errors

if (month1 == 1 || month1 == 3 || month1 == 5 || month1 ==7 || month1 == 8 || month1 ==10 || month1 ==12 && day1 > 31
			|| day1 < 1)
			{
				cout << "Enter A Valid day" << endl;
	
				return false;
			}
/*else if (month1 == 4 month1 == 6 || month1 == 9 || month1 == 11 && day1 < 1  || day1 > 30)
			{
				cout << "Enter A Valid Day" << endl;
				return false;
			}*/
else
			{
				return true;
			}
}




	// MAIN
int _tmain(int argc, _TCHAR* argv[])
{
	int day1, month1;
	CheckDate(day1, month1);
    while(CheckDate(day1, month1)) // loops until valid input is detected 
	{

		cout << "Enter A Day" << endl;
		cin >> day1;

		cout << "Enter A Month" << endl;
		cin >> month1;


	return 0;
}

This is just a quick guess, but you might want to use a constructor...

oh, well i haven't even started to use that yet. I just included the class because it is going to be part of the final program.

...
bool CheckDate( int day1, int month1)
{
	int day1, month1 = 0;
...

Two things I see wrong there. First, if you want CheckDate to be a method of class dateReport then you need to add dateReport:: before the method name, like...

...
bool dateReport::CheckDate( int day1, int month1)
{
	int day1, month1 = 0;
...

The next thing is that you're declaring day1, and month1 locally in that method, but you have day1 and month1 as arguments already. I haven't read into your method to know the intent of those two variables but I have a feeling that you didn't want to make them have the same name as day1, and month1.. So you should probably change their names, or get rid of them.

Hope that helps a bit..

-Fredric

while defining the class is on the right track, you still need to create an object of that class (an instance of class dateReport)
your constructor for your class should initialize all data members of your class so that the object is ready for work.
so in your constructor (and like Daishi said, when you define the methods of your class, you need to use the scope resolution operator ( :: ) to define the methods for the compiler

dateReport::dateReport() // notice the parameters are empty
{
   //  setting all members of the object to 0
   day = 0;
   month = 0;
   year = 2005; // given from requirements
}

in your main, you need to create the object of the class (instantiate it)

int _tmain(int argc, _TCHAR* argv[])
{
	int day1, month1;
            [B]dateReport myObject = new dateReport();[/B]
	//CheckDate(day1, month1);   your day1, month1 are not initialized to anything
            // so if you call the method with these 2 variables, its garbage
            // same below, try looking up a do-while statement for below
            //while(CheckDate(day1, month1)) // loops until valid input is detected 
	{

		cout << "Enter A Day" << endl;
		cin >> day1;

		cout << "Enter A Month" << endl;
		cin >> month1;


	return 0;
}

and to format your data, youll prolly need a method to set the data members to = the input and then have another function to print the output

void dateReport::setDate(int day, int year)
{
    //set your data members
}

void dateReport::print()
{
    //print the formatted date
}

that should get you started (dont forget to include the sigs for these functions in yer class

This article has been dead for over six months. Start a new discussion instead.