Why Key events are not working?

Question

sharathg.satya -10 Posting Whiz in Training

12 Years Ago

hi all
i am facing a problem with the below code
i used keylistener so that when i click letter 'v' the program has to exit.
But the following code is not working.
Help me please..
i think we should add listener to the code but how to add listener in the below code ??

import java.awt.*;
import java.awt.event.*;
import  sun.audio.*;
import java.io.*;
public class Games extends Frame implements KeyListener
{
  int x=250,y=460;
  int points=0;
  boolean istop=false;
Thread t=new Thread();
   Games()
  {
   setVisible(true);
   setSize(500,500);
  }
  public void repeat() 
  {
      
    if(istop)
    {
     y+=1; 
    }
    if(!istop)
    {
      y-=1;
    }
     if(y==30)
       {
        points++;

        
       System.out.println("Points are : "+points );   
       istop=true;    
       }
     if(y==460)
     {
       istop=false;
     }
    try
     {
      Thread.sleep(3);
      
     }
    catch(InterruptedException e)
    {
      repaint(); 
    }
   
  }

public void paint(Graphics g)
{
  while(true)
   {
    
    g.clearRect(0,0,500,500);   
    g.fillOval(x,y,30,30);
   
   
    repeat();  
  }

}


public void keyPressed(KeyEvent ke)
{
  
   
 if(ke.getKeyCode()== KeyEvent.VK_V)
  {
    setVisible(false);
  }
  

}

public void keyTyped(KeyEvent ke)
{
  
 if(ke.getKeyCode()== KeyEvent.VK_V)
  {
   System.exit(0);
  }

}
public void keyReleased(KeyEvent ke)
{
  
  

}
public static void main(String args[])
{
 new Games();
 
}
}

thanks in advance

java

Edited 12 Years Ago by sharathg.satya because: n/a

4 Contributors
14 Replies
178 Views
1 Day Discussion Span
Latest Post 12 Years Ago Latest Post by stultuske

All 14 Replies

stultuske 1,116 Posting Maven

12 Years Ago

while(true)

the chance of this expression ever returning false is ... well, zero :)

DavidKroukamp 105 Master Poster

12 Years Ago

hi all
i am facing a problem with the below code
i used keylistener so that when i click letter 'v' the program has to exit.
But the following code is not working.
Help me please..
i think we should add listener to the code but how to add listener in the below code ??

import java.awt.*;
import java.awt.event.*;
import  sun.audio.*;
import java.io.*;
public class Games extends Frame implements KeyListener
{
  int x=250,y=460;
  int points=0;
  boolean istop=false;
Thread t=new Thread();
   Games()
  {
   setVisible(true);
   setSize(500,500);
  }
  public void repeat() 
  {
      
    if(istop)
    {
     y+=1; 
    }
    if(!istop)
    {
      y-=1;
    }
     if(y==30)
       {
        points++;

        
       System.out.println("Points are : "+points );   
       istop=true;    
       }
     if(y==460)
     {
       istop=false;
     }
    try
     {
      Thread.sleep(3);
      
     }
    catch(InterruptedException e)
    {
      repaint(); 
    }
   
  }

public void paint(Graphics g)
{
  while(true)
   {
    
    g.clearRect(0,0,500,500);   
    g.fillOval(x,y,30,30);
   
   
    repeat();  
  }

}


public void keyPressed(KeyEvent ke)
{
  
   
 if(ke.getKeyCode()== KeyEvent.VK_V)
  {
    setVisible(false);
  }
  

}

public void keyTyped(KeyEvent ke)
{
  
 if(ke.getKeyCode()== KeyEvent.VK_V)
  {
   System.exit(0);
  }

}
public void keyReleased(KeyEvent ke)
{
  
  

}
public static void main(String args[])
{
 new Games();
 
}
}

thanks in advance

check this for some help java docs are the best:http://docs.oracle.com/javase/tutorial/uiswing/events/keylistener.html

stultuske 1,116 Posting Maven

12 Years Ago

Yes
But as a keyevent occured the control should be handed over to the function..
Isnt it?

just because you call your method 'keyPressed' doesn't mean they're run when you press a key. you'll have to trigger it.
cOrRuPtG3n3t!x 's link should help you out on that part.

stultuske 1,116 Posting Maven

12 Years Ago

you implemented KeyListener, you didn't really use it.
@mKorbel: you've got me there, but I was merely continuing on cOrRuPtG3n3t!x's post, since, it could also work.

mKorbel commented: :-) +11

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

sharathg.satya -10 Posting Whiz in Training · Answer 1 · 2012-01-17T16:51:29+00:00

while(true)
the chance of this expression ever returning false is ... well, zero :)

Yes
But as a keyevent occured the control should be handed over to the function..
Isnt it?

sharathg.satya -10 Posting Whiz in Training · Answer 2 · 2012-01-17T19:06:54+00:00

just because you call your method 'keyPressed' doesn't mean they're run when you press a key. you'll have to trigger it.
cOrRuPtG3n3t!x 's link should help you out on that part.

Yes
but when key event is triggered, the code for the triggered event is mentioned....

stultuske 1,116 Posting Maven Featured Poster · Answer 3 · 2012-01-17T19:15:09+00:00

Yes
but when key event is triggered, the code for the triggered event is mentioned....

true, but without the use of a KeyListener, it's just a plain method.

take a look at this code, which is part of the oracle tutorial about this subject.

mKorbel 274 Veteran Poster · Answer 4 · 2012-01-17T19:57:35+00:00

@stultuske I think that no, never ..., Swing GUI isn't designated for listening of KeyListener, especially JTextComponents, because required some Woodoo for correct Focus / FocusSubsystem and required override method setFocusable()

use KeyBindings,

1) no required override Focus behavior

2) can possible replace/overrive built-in key_shortcuts from BasicXxxUI

3) with same/similair long of written code

EDIT

and for JTextComponents is there Document/DocumentListener

sharathg.satya -10 Posting Whiz in Training · Answer 5 · 2012-01-17T22:14:47+00:00

@stultuske I think that no, never ..., Swing GUI isn't designated for listening of KeyListener, especially JTextComponents, because required some Woodoo for correct Focus / FocusSubsystem and required override method setFocusable()
use KeyBindings,
1) no required override Focus behavior
2) can possible replace/overrive built-in key_shortcuts from BasicXxxUI
3) with same/similair long of written code

EDIT
and for JTextComponents is there Document/DocumentListener

I didnt get u korbel

sharathg.satya -10 Posting Whiz in Training · Answer 6 · 2012-01-17T22:15:44+00:00

true, but without the use of a KeyListener, it's just a plain method.
take a look at this code, which is part of the oracle tutorial about this subject.

:-O
I used the keylistener
i saw the code and the only point i found is that there is a seperate function that is called on every function that is to be used in the keylistener

sharathg.satya -10 Posting Whiz in Training · Answer 7 · 2012-01-18T06:52:23+00:00

you implemented KeyListener, you didn't really use it.
@mKorbel: you've got me there, but I was merely continuing on cOrRuPtG3n3t!x's post, since, it could also work.

Ok then how should i use it?:?:

stultuske 1,116 Posting Maven Featured Poster · Answer 8 · 2012-01-18T12:28:53+00:00

check the code to which I provided a link for the
addKeyListener method.

sharathg.satya -10 Posting Whiz in Training · Answer 9 · 2012-01-18T12:54:30+00:00

check the code to which I provided a link for the
addKeyListener method.

Why to use actionlistener to perform a keylistener?

stultuske 1,116 Posting Maven Featured Poster · Answer 10 · 2012-01-18T13:55:25+00:00

cOrRuPtG3n3t!x and mKorbel provided you with information about two alternate ways to tackle this problem.

have you actually tried, step by step, to implement one of these?

Why Key events are not working?

Recommended Answers Collapse Answers

All 14 Replies

Recommended Answers