Member Avatar for cassyjack

Can someone please take a look at this for me. I have to create a program that models a simple card game. I have to shuffle the card and deal 1 card at a time and display the card that I have dealt. Not sure how to do this. The code I have is returning 00. I also have to declair a winner. I guess I need to do a nested for loop to check against suit and face of card right.(havent tried it yet). Looking for suggestions or directions in the correct place.
Thanks.

/**
 * Write a description of class Card here.
 * 
 * @author () 
 * @version (test)
 */
public class Card
{
    // instance variables - replace the example below with your own
    public static final int SPADE = 0;
    public static final int HEART = 1;
    public static final int DIAMOND = 2;
    public static final int CLUB = 3;
    public static int suit;//should be private
    public static int face;// should be private cards number 2-10 Ace = 1, jack = 11, queen = 12, king = 13
    
    /**
     * Constructor for objects of class Card
     */
    public Card(int f, int s)
    {
        // initialise instance variables
        face = f;
        suit =  SPADE;
    }
    //No Arg Constructor
    public Card()
    {
        // initialise instance variables
        face = 1;
        suit =  0;
    }
    /**
     * Allows changes to suit and value
     * 
     * @param  newS Suit and param newV new value
     * @return   return suit and value
     */
    public int getSuit()
    {
        // put your code here
        return suit;
    }
    public int getFace()
    {
        // put your code here
        return face;
    }
    public void setSuit(int newS)
    {
        
        suit = newS;
    }
    public void setFace(int newF)
    {
       face = newF;
    }
     /**
     * toString method
     * 
     */
    public String toString()
    {
       String suitAsString = "Spade";
       if (suit == HEART)
            suitAsString = "Heart";
            else if (suit == DIAMOND)
                suitAsString = "Diamond";
                else if (suit == CLUB)
                    suitAsString ="Club";
                return ("Card " + face + suit);
    }
     /**
     * Checks to see if cards are equasl
     * cards are equal when face and suit are the same.
     */
  // public boolean equals(Card yourCard)
   //{
    //   if your 
    //   return 
    //}
    
}
import java.util.*;
/**
 * Write a description of class Deck here.
 * 
 * @author () 
 * @version (test)
 */
public class Deck
{
    private Card[] myDeck;//mabe 51 since counting starts at 0
    private int dealt;//card that is dealt
    // private int numOfFace;
  //  private int numOfSuits;
    /**
     * Constructor for objects of class Card
     */
    public Deck(int size)
    {
        // initialise instance variables
        myDeck = new Card[size];
     //   numOfFace = 13;
     //   numOfSuits = 4;
        
       // numOfCards = 0;
      
       
    }
    //No Arg Constructor
    public Deck()
    {
        // initialise instance variablesCard[] myDeck = new Card[52];
       myDeck = new Card[52];
        int numCard =0;
      for (int suit = 0; suit <=3; suit++){
            for (int face = 1; face <=12; face++){
                myDeck[numCard] = new Card(face, suit);
                numCard++;
            }
        }
            dealt = 0;
      
     
        }
        
    /**
     * Methods to Deal, Shuffle and Equals method to determine if two decks 
     * are equal
     */
   
  public Card deal(){
    if(dealt == 52)
        shuffle();
        dealt++;
        return myDeck[dealt -1];
  
    }

   public  void shuffle()
   {
     
      Collections.shuffle(Arrays.asList(myDeck));

   }
  /** public boolean equals(Deck yourDeck)
    {
        return (suit = yourDeck.getSuit() && face= yourDeck.getFace());
    }
    */
}
import javax.swing.*;
import java.util.*;
/**
 * Write a description of class Driver here.
 * 
 * @author () 
 * @version (test)
 */
public class Driver
{
    //Variables for Driver class
    private static Deck inDeck;
    /**
     * The main method of the program. This program 
     */
    public static void main(String[]arg)
    { 
        inDeck = new Deck(52);
       
     
 
        
        
        JOptionPane.showMessageDialog(null, "Lets Play Some Cards", "Card Game", JOptionPane.PLAIN_MESSAGE);
        //instantiate the deck of cards
        playCards();
        //if statement that calls a task on the choice
        System.exit(0);   
       }
       private static void playCards()
       {
        Object[] choices = {"Shuffle", "Deal 1st", "Deal 2nd","Quit"};
        Object selected = JOptionPane.showInputDialog(null, "Please Select Shuffle to Start Game, Then Deal 1st and 2nd Cards", 
        "Lets Play",JOptionPane.QUESTION_MESSAGE, null, choices, choices[0]);
            if 
            (choices[0].equals((String) selected)){
            inDeck.shuffle();
            playCards();}
            else if 
            (choices[1].equals((String) selected))
            {
            inDeck.deal();
            int card = Card.suit + Card.face;
            JOptionPane.showMessageDialog(null, "Your Card: " + Card.face + Card.suit, "Card Game", JOptionPane.PLAIN_MESSAGE);
            playCards();
         
        }
            else if
            (choices[2].equals((String) selected)){
            inDeck.deal();
            JOptionPane.showMessageDialog(null, "Your Card: " + Card.face + Card.suit, "Card Game", JOptionPane.PLAIN_MESSAGE);}
          //  winner();
            else if
            (choices[3].equals((String) selected))
            System.exit(0);
    }
       
          // private void winner()
         //  {}
               
}
  • 2 Contributors
  • 5 Replies
  • 318 Views
  • 21 Hours Discussion Span
  • Latest Post Latest Post by peter_budo

Dani AI

Generated

Quick diagnosis: getting "00" or the same pair like "12 3" repeatedly usually means one of three things is wrong — the Card objects never get the right face/suit values, the same Card instance was placed into every deck slot, or the index that tracks the next card is being reset every time you deal. was on the right track about the constructor; if face/suit stay at their default value the printed result will look like zeros. ’s note about moving initialization into the deal method points to the other common pitfall: reinitializing the pointer each deal.

Concrete checklist to fix the logic

  • Populate the deck with 52 distinct new Card(...) objects (one per array/list slot).
  • Call the population method once, then shuffle. Don’t repopulate before every deal.
  • Keep a Deck field (e.g. nextIndex or top) that starts at 0 and is incremented by the deal method; do not declare or reset it inside the deal method.
  • Use a correct shuffle (Fisher–Yates or Collections.shuffle) so cards are permuted, not deterministic.

Example snippets (minimal)

// Fisher–Yates shuffle (in Deck)
Random rnd = new Random();
for (int i = cards.length - 1; i > 0; i--) {
  int j = rnd.nextInt(i + 1);
  Card tmp = cards[i]; cards[i] = cards[j]; cards[j] = tmp;
}
// deal one card (Deck field: private int next = 0;)
public Card dealOne() {
  if (next >= cards.length) return null;
  return cards[next++]; // persistent pointer, not reset each call
}

Final troubleshooting tips: add short debug prints when constructing the deck (index and new Card identity) to detect reuse of one object, confirm toString() maps face/suit indexes to readable names (watch off-by-one), and test using a List with Collections.shuffle() + remove(0) if mutation semantics are acceptable.

Recommended Answers

All 5 Replies

Member Avatar for peter_budo

I did few small changes to your files

CARDS change in card constructor

public Card(int f, int s)
{
    // initialise instance variables
    face = f;
    suit = s;        //you had suit = SPADE
}

DECK change your constructor public Deck() (with 2 for loops) to a method to initialize cards, I call it public void setCards()

DRIVER use the new method setCards() before you suffle cards

if (choices[0].equals((String) selected))
{
            inDeck.setCards();
            inDeck.shuffle();
            System.out.println("card mixed");
            playCards();}

I would create random function to get my set of cards and check if these cards hasn't been dealt. So dealt cards should be store somewhere :?:

Member Avatar for cassyjack

I'm now able to see the card. But it will not display different cards. I keep getting 12 3

Member Avatar for peter_budo

Did you tried a random function as I sugested???

Member Avatar for cassyjack

Not sure what you mean by creating a random fucntion. I moved the intialization of dealt to the deal method. Is it because I needs some kind of equals function?

Member Avatar for peter_budo

I think I poineted you in wrong direction, you don't need random function that is useful dice games. Sorry my mistake. ;)
But you may want to create another array of type card to store data about cards which been used and should not be dealth again

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.