i have a jsp it has two fileds..mobileno and password..when i enterd values its storing in DB.But when iam retriving its retriving and comparing only with newly inserted values only.. it is comparing only last inserted values in Db only ..here is my code..

package com;
import java.io.*;
import java.util.*;
import java.sql.*;
import javax.servlet.*;
import javax.servlet.http.*;

public class SearchServlet extends HttpServlet

 private ServletConfig config;
  public void init(ServletConfig config)
    throws ServletException{
  public void service(HttpServletRequest request, HttpServletResponse response) 
              throws ServletException,IOException{
    PrintWriter out = response.getWriter();
    String connectionURL = "jdbc:mysql://localhost/test";
    Connection connection=null;
    ResultSet rs;
    String mobileno=request.getParameter("mobileno");
    String password=request.getParameter("password");
    HttpSession ses=request.getSession(true);
try {
       // Load the database driver
      // Get a Connection to the database
      connection = DriverManager.getConnection(connectionURL, "root", "password"); 
      //Add the data into the database
      String sql = "select mobileno,password from newuser";
      Statement s = connection.createStatement();
      s.executeQuery (sql);
      rs = s.getResultSet();
      while (rs.next ()){
      rs.close ();
      s.close ();
      }catch(Exception e){
      System.out.println("Exception is ;"+e);
          && password.equals(request.getParameter("password")))
    //    ses.setAttribute("MOBILENO",mobileno);
     //   ses.setAttribute("PASSWORD",password);
  //    mobileno = (String)ses.getAttribute("MOBILENO");
      out.print("<h1>You are Already Registerd </h1>");
            out.println("<h1>You are not a Valid User Please Register</h1>");
            out.println("<a href='newregister.jsp'><br>Register Here!!</a>");

  public void destroy()

  1. Direct connection from JSP to DB is very bad thing to do check this post
  2. You will get only one set of user data because you collect only one and discard whatever DB is still passing to you
    while (rs.next ()){
          rs.close ();
          s.close ();

    so some sort of Collection (Array, ArrayList, List or Vector) would be appropriate to use

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.