PHP and Href display problem

[jmercola]

I am trying to use PHP in an HTML page to change Login to Logout and reference my login page. Instead of printing 'Login' and 'Logout' I get the following: Logout" ; } else { echo" Login" ; } ?>

The IF function seems to get confused and starts echoing Logout when it should not start until Login. My code is for the last selection on an html line

<?PHP
if ("$login_successful" == "1") {
echo"<a href='http://www.icselect.com/login.php?logout=1'> Logout</a>" ;
}
else { 
echo"<a href='http://www.icselect.com/login.php'> Login</a>" ;
}
?>

Any suggestions are welcome.

[Slammer]

try changing "$login_successful" == "1" to $login_successful == 1

if ("$login_successful" == "1") {

[jmercola]

Slammer,

Sorry but that did not work.

[harry_watson]

what about something like

if ($logged_in == 'true') {?>

[almostbob]

<?php if($login_successful == "1") { echo "<a href='http://www.icselect.com/login.php?logout=1'> Logout</a>"; }
else { echo "<a href='http://www.icselect.com/login.php'> Login</a>"; } ?>

no quotes around variable name, quotes indicate quoted text.
xxxxxbla bla bla <> 1
text is never equal to one

[harry_watson]

ok not sure what else you've done. I was thinking of 'true' rather than '1'

[almostbob]

op has searched for a literal 1 (number) not for a true boolean

[harry_watson]

op has searched for a literal 1 (number) not for a true boolean

that's true

op might want to try this the meta eqiv = is a much faster and nicer way too, depending on what's
required and if it's a php server self.

<?php if($login_successful == "true") { echo "<a href='http://www.icselect.com/login.php?logout=1'> Logout</a>"; }

      else { echo '<meta http-equiv="refresh" content="2;url=login.php">'; }
?>

[jmercola]

Sorry everyone. I still get
Logout"; } else { echo " Login"; } ?>
except for harry's suggestion which doesn't print Login.
You can see this at http://www.icselect.com/ics2_design.html

[rajabhaskar525]

$login_successful="1";
     if ("$login_successful" == "1") {
   echo"<a href='http://www.icselect.com/login.php?logout=1'> Logout</a>" ;
      }
   else {
      echo"<a href='http://www.icselect.com/login.php'> Login</a>" ;
      }

i tried like above i got correctly in my localhost. it prints 1 for logout o for login.

[nav33n]

As simple as it sounds, Your code [what you have at the moment on the page] is correct, but you should name your script from ics2_design.html to ics2_design.php OR you should make your apache parse html files as php.
If you view the source of the page, you will see that the php code in the page isn't parsed.

:) Cheers!

[harry_watson]

your php is ending and becoming text here > Logout< you could try this...

<?php if($login_successful == "true") { echo "<a href='http://www.icselect.com/login.php'>"?>Logout</a>

<?php;}
else { echo "<a href='http://www.icselect.com/login.php'> Login</a>"; }?>

And Nav33 is right. give your file a .php extension. Maybe that's all you need to do.

[saiprem]

Sorry everyone. I still get
Logout"; } else { echo " Login"; } ?>
except for harry's suggestion which doesn't print Login.
You can see this at http://www.icselect.com/ics2_design.html

If the user is logged in successfully then set the variable login_successful to 1 as I shown in the below code

$login_successful = 1;
if ($login_successful == 1) {
echo"<a href='http://www.icselect.com/login.php?logout=1'> Logout</a>" ;
}
else { 
echo"<a href='http://www.icselect.com/login.php'> Login</a>" ;
}

[vaultdweller123]

there's no problem with the code... i don't think the problem came there... it might be the code before that. Try reviewing your code.

[jmercola]

The problem was no in the ($login_successful == 1) test but in the faulty printing to the screen. I will just use two different templates.

Thanks everyone

[vaultdweller123]

one way of saying thanks is marking this thread solved.