Guys, I am trying to learn asp, but I am stuck on this error forever... I managed to display and create new, but I can't delete and update. I was told I had to remove the ' around cid, but it still gave me another erro. can someone please provide me with a quick solution.


<h2>Update Record</h2>
set conn=Server.CreateObject("ADODB.Connection")
conn.Open "c:/webdata/northwind.mdb"


if Request.form("companyname")="" then
  set rs=Server.CreateObject("ADODB.Recordset")
  rs.open "SELECT * FROM customers WHERE customerID='" & cid & "'",conn
  <form method="post" action="demo_update.asp">
  <%for each x in rs.Fields%>
  <td><input name="<%=x.name%>" value="<%=x.value%>"></td>
  <input type="submit" value="Update record">
  sql="UPDATE customers SET "
  sql=sql & "companyname='" & Request.Form("companyname") & "',"
  sql=sql & "contactname='" & Request.Form("contactname") & "',"
  sql=sql & "address='" & Request.Form("address") & "',"
  sql=sql & "city='" & Request.Form("city") & "',"
  sql=sql & "postalcode='" & Request.Form("postalcode") & "',"
  sql=sql & "country='" & Request.Form("country") & "'"
  sql=sql & " WHERE customerID='" & cid & "'"
  on error resume next
  conn.Execute sql
  if err<>0 then
    response.write("No update permissions!")
    response.write("Record " & cid & " was updated!")
  end if
end if

3 Years
Discussion Span
Last Post by Blueie

Compare what data type the cid column in the database is to what the cid variable holds after the line: cid = Request.Form("customerID").
Data type erros normally mean you are passing in the wrong type against what is expected (string vs int for example).


On a related note, you should consider using parameterized queries instead so that your parameters are passed as literal text. This prevents errors and is good for security.

A simple example regarding why you should use parameterized queries.. say any of the variables you are using in your SQL query contains an apostrophe... the appostophe will cause your application to fail.

Here is an example online on how to use parameterized queries in Classic ASP.



You would need to open northwind.mdb, double-click on the 'customers' table, and select 'Design View'. That will show you the Data Type for each field. The data you are passing into that field needs to correspond to the 'data type' for that field. So you wouldn't, for instance, have a 'Text' data type if you were updating a currency field.

This topic has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.