Member Avatar for Luigi_4

I have a script that uses grep to extract data from a file. It works but I am now trying to modify the script for pipeline use. If I use the commands: cat file | myScript.sh there is an error because the data reaches myScript.sh as it was collected by an echo command (grep: LINE: No such file or directory).

Is there a way to pass 'file' as an argument to myScript.sh so that grep can work as it was originally meant?

  • 2 Contributors
  • 1 Reply
  • 449 Views
  • 2 Days Discussion Span
  • Latest Post Latest Post by JasonHippy

Dani AI

Generated

Short answer: yes — you can keep using a pipeline and still give the script the original filename. The error you saw ("grep: LINE: No such file or directory") usually means the script is passing text from stdin into grep as if it were a filename (often due to unquoted expansions or a for/command-substitution loop). is right that making the script accept a filename is clean; below are a few practical ways to support both piped content and a filename argument.

Make the script accept either a filename or stdin by using - as the stdin token. This keeps the call simple and avoids special-casing the caller:

#!/usr/bin/env bash
pattern='your_regex_here'        # set or get from args
infile="${1:--}"                 # if $1 is empty, use '-' (stdin)
grep -- "$pattern" "$infile"

If you want to keep piping the file contents but also let the script know the original filename (for reporting, logging, etc.), export or set an environment variable for the script in the same command line:

FNAME="file.txt"
cat "$FNAME" | FNAME="$FNAME" ./myScript.sh

Inside myScript.sh read "$FNAME" when you need the name and read from stdin for content.

Quick debugging tips: enable set -x to trace what variables/args are passed; avoid for f in $(cat file) (it splits on whitespace); prefer while IFS= read -r line; do ...; done or xargs -0 for NUL-delimited filenames. Quoting variable expansions ("$var") is often all that prevents grep from treating content as filenames.

Member Avatar for JasonHippy

Depending on the actual content of myScript.sh, you might be able to use input redirection to use the file as input to the script:
./myScript.sh < /path/to/file

Or if file contains a list of file-names to search - you might be able to use xargs:
cat file | xargs ./myScript.sh
But again, xargs usage would depend on what myScript.sh actually does. We don't really know anything about your script, what parameters it is set up to take etc etc.

Or you could just set up your script to explicitly take the path to a file as a parameter:
e.g.

#!/usr/bin/env bash

# if number of parameters to script is 1 AND the parameter is the path to a file
if [ $# -eq 1 ] && [ -f $1 ] ; then
    grep -iHn --color "regex" $1         # Search the file
else
    echo "ERROR - Script takes 1 parameter which must be the path to an existing file"
    exit 1                                    # Exit with error status
fi

And then you would run your script like this:
./myScript.sh /path/to/file

Obviously the above example was completley contrived. I don't know what your actual script does. But my example should give you an idea on how to modify your script to take a file-name as a parameter, if that is what you want to do.....

Edited by JasonHippy
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.