Can't insert record into mySQL database

[keira23]

Hi there

Completely stumped on the simplest of things...

Here is my PHP code:

<?php

//includes the connection parameters from external file

require_once('connection.php');

// Receive the variables
$fname = $_POST['fname'];
$lname = $_POST['lname'];
$email = $_POST['email'];
$ip = gethostbyname($_SERVER['REMOTE_ADDR']);

// Establish connection with database
$connect = mysql_connect($hostname, $username, $password) or die("Could not connect to localhost");

// Select database
$select = mysql_select_db($database, $connect) or die("Could not find database.");

// Insert data to database
$sql = mysql_query("INSERT INTO tc_mailist ('fname', 'lname', 'email', 'ip') VALUES ('Joe', 'Bloggs', '[e-mail]', $ip)");

if(!$sql) {
	die("Nope");
} else {
	echo "1 record added";
}

mysql_close($connect);
?>

$sql step doesn't seem to work no matter how I change the formatting.

No literature I've read seems to help. Any ideas?

Thanks!

[mwasif]

Do not use quotes around column names.

$sql = mysql_query("INSERT INTO tc_mailist (fname, lname, email, ip) VALUES ('Joe', 'Bloggs', '[e-mail]', $ip)");

[keira23]

Thanks for your reply mwasif!!

Ok, I've removed the quotes and at first it still didn't work.

When I tried reducing the fields, I realised the ip address field was stopping the code working. When I just use fname, lname, email ... it works. With ip field, it doesn't.

Not sure why this is, even when I use:
$ip = $_SERVER;

I even changed the field type to INT (unsigned) in the database from VARCHAR (150) but this also doesn't make a difference.

Probably not that important but it would be good to know how to pass ip address to database. :)

Thanks again!

[mwasif]

If ip field is varchar then use quotes around $ip in the query. But if you want to insert in INT format then use INET_ATON() to insert and to retrieve INET_NTOA().