Array problem

Question

shinnie 0 Newbie Poster

15 Years Ago

I'm writing a program about words game.
The program is working fine but i'm having trouble in reduce the array to size 5.that mean the user only can input 5 times then the program shut down
Anyone have any ideas?

java

4 Contributors
8 Replies
300 Views
1 Day Discussion Span
Latest Post 15 Years Ago Latest Post by jon.kiparsky

Dani AI

Generated 9 Months Ago

The code posted by grows the stored-word array every time a valid word is added, so there is no fixed ceiling — that explains the "unlimited input" behavior. Both (use a loop) and (check the index) point toward the right fixes. Two simple, safe options:

Keep an array but stop accepting input when the counter reaches 5 (simplest change).
Use an ArrayList and check its size before adding (cleaner and less error-prone).

Example (array-based, minimal change):

String[] wordList = new String[5];
while (wordSize < 5) {
    String w = JOptionPane.showInputDialog(null, "Enter a word:");
    if (w == null || w.isEmpty() || w.equalsIgnoreCase("stop")) break;
    if (isValidWord(w)) {
        wordList[wordSize++] = w.toLowerCase();
        JOptionPane.showMessageDialog(null, "Word added.");
    }
}
printTotalScore();
System.exit(0);

Example (ArrayList):

List<String> words = new ArrayList<>(5);
if (isValidWord(w)) {
    words.add(w.toLowerCase());
    if (words.size() >= 5) {
        printTotalScore();
        System.exit(0);
    }
}

Other quick corrections and cautions: the current isValidWord returns from inside a character loop — move any return true to after the loop so every character is checked. The tmpArray = new String[wordSize]; tmpArray = wordList; sequence is redundant; prefer direct indexing, System.arraycopy, or Arrays.copyOf if resizing is needed. Use equalsIgnoreCase("stop") to simplify stop checks, and avoid calling System.exit(0) from deep utility methods — let main control program termination for easier testing and clearer flow.

All 8 Replies

NormR1 580 Posting Sage

15 Years Ago

the user only can input 5 times

There are many ways to count what happens.
The most common one is to use a loop.

jon.kiparsky 326 Posting Virtuoso

15 Years Ago

Not sure I understand the problem. Your user is entering input, and it's getting stored in an array - that much I've got. You're running out of space in the array, I think, and the program crashes with an ArrayIndexOutOfBounds - I'm guessing on that part. Why is the array an array of five? Where does that number come from, and would another number be better?
If you give a little more detail on the nature of the game, and how you're implementing it, it might be easier to answer this.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

Xufyan -4 Posting Whiz · Answer 1 · 2010-10-10T21:26:36+00:00

you simply need to apply If condition to shut the program if array index equals to 5.

Please provide little more details about the program and a piece of code so we can understand a little more what you wanted to do...!

shinnie 0 Newbie Poster · Answer 2 · 2010-10-11T03:05:38+00:00

i'm sorry.Here is the code i'm working on.

package com.project1.wordgame;

import javax.swing.JOptionPane;

public class Project1 {
    static String word;
    static String[] wordList;
    static int wordSize = 0;
    static int i = 0;

    public static void main(String[] args) {
        wordList = new String[10];
        inputWord();        
    }

    public static String inputWord() {
        while (true) {
            String word;
            word = (JOptionPane.showInputDialog(null, "Enter 10 letters: "));
            if (word == null || "".equals(word)) {
                if (isValidList(wordList)) {
                    printTotalScore();
                }
                return "";
            }
            else if (word.equals("stop") || (word.equals("STOP"))) {
                System.exit(0);// end program if stop is typed.
            } else if (isValidWord(word))
            {
                storeWord(word);
            } 
        }
    }

    public static boolean isValidWord(String w) {
        
        if (w.length() > 10) {
            JOptionPane.showMessageDialog(null, "Too much letters.");
            return false;
        }
        for (int i = 0; i < w.length(); i++)
            if (Character.isDigit(w.charAt(i))) {
                JOptionPane.showMessageDialog(null, "Enter only letters.");
                return false;
            }
        for (int i = 0; i < w.length(); i++) {
            if (w.charAt(i) == 'a' || w.charAt(i) == 'i' || w.charAt(i) == 'u'
                    || w.charAt(i) == 'e' || w.charAt(i) == 'o'
                    || w.charAt(i) == 'z' || w.charAt(i) == 'q'
                    || w.charAt(i) == 'k' || w.charAt(i) == 'v'
                    || w.charAt(i) == 'f' || w.charAt(i) == 'w') {                
            }            
            return (true);
        }
        return (false);
    }

    public static boolean isValidList(String[] list) {
        if (list == null || wordSize == 0) {
            System.out.println("Array is blank");
            System.exit(0);
        }
        return true;
    }

    public static void storeWord(String w) {
        
        String[] tmpArray = new String[wordSize];
        tmpArray = wordList;
        
        wordList = new String[wordSize + 1];
        
        for (int i = 0; i < wordSize; i++) {
            wordList[i] = tmpArray[i];
        }
        
        wordList[wordSize] = w.toLowerCase();
        
        wordSize++;
        
        JOptionPane.showMessageDialog(null, "Word added.");
    }

    public static int wordScore(String w) {
        int Cntr = 0;
        for (int i = 0; i < w.length(); i++) {
            if (w.charAt(i) == 'a' || w.charAt(i) == 'i' || w.charAt(i) == 'u'
                    || w.charAt(i) == 'e' || w.charAt(i) == 'o') {
                Cntr = Cntr + 0;
            } else if (w.charAt(i) == 'z' || w.charAt(i) == 'q') {
                Cntr = Cntr + 10;
            } else if (w.charAt(i) == 'k' || w.charAt(i) == 'v'
                    || w.charAt(i) == 'f' || w.charAt(i) == 'w') {
                Cntr = Cntr + 5;
            } else if (!(Character.isDigit(w.charAt(i))))
                Cntr = Cntr + 1;
        }
        return Cntr;
    }

    public static void printTotalScore() {
        int totalScore = 0;
        for (int k = 0; k < wordSize; k++) {
            int score = wordScore(wordList[k]);
            totalScore += score;
            System.out.println("Word : " +wordList[k] + "\t\t-\tScore : " +score);
        }
        System.out.println("---------------------------------------------------");
        System.out.println("Total Score : " + totalScore);
    }
}

NormR1 580 Posting Sage Team Colleague · Answer 3 · 2010-10-11T03:23:58+00:00

Is the program working now? I don't see any comments in the code saying there is a *** PROBLEM HERE ***.

shinnie 0 Newbie Poster · Answer 4 · 2010-10-11T03:32:08+00:00

yes the problem is working and now it's unlimited input.but but i'm having trouble in reduce the array to size 5.that mean the user only can input 5 times then the program shut down.

NormR1 580 Posting Sage Team Colleague · Answer 5 · 2010-10-11T03:43:40+00:00

i'm having trouble in reduce the array to size 5

Please explain.
How are you counting the number of times the user inputs something?
Can you detect when the limit has been reached and do something?

jon.kiparsky 326 Posting Virtuoso · Answer 6 · 2010-10-11T07:02:25+00:00

Again, why the number five? Why do you want the array size to be five?

Array problem

Dani AI

Recommended Answers Collapse Answers

All 8 Replies

Recommended Answers