I am working to take c code from an academic paper and edit. I am studying cryptographic algorithms. I have ran the following code, but I am having a little difficulty understanding two things. First, the program uses unsigned long ints. When they are added or subtracted, I don't get the values I would expect. For example:

P, Q, My sum by hand, sum using c
01100011010100011110000110110111
10111001011110010011011110011110
00011100110010110001100101010101
00011100110010110001100001010110

I understand that unsigned long int is 32 bit and that the addition is mod 2^32, but I thought the last carry bit when you add to the left by hand would be lost. Is it somehow added back on the right side?

Second, when I run the code, the output should include 5 examples in hex, but when I run it, the results have a lot of 0's mixed into the results. If you remove the 0's, the results are correct. Is this something I have done?

Thanks,
Chris

Attachments
#include <stdio.h>
typedef unsigned long int WORD;
#define w	32
#define r	12
#define b	16
#define c	4
#define t	26
WORD S[t];
WORD P = 0xb7e15163, Q = 0x9e3779b9;
#define ROTL(x,y) (((x)<<(y&(w-1))) | ((x)>>(w-(y&(w-1)))))
#define ROTR(x,y) (((x)>>(y&(w-1))) | ((x)<<(w-(y&(w-1)))))

void RC5_ENCRYPT(WORD *pt, WORD *ct) {
	WORD i, A = pt[0]+S[0], B = pt[1]+S[1];
	for(i=1; i<=r; i++) {
		A = ROTL(A^B,B)+S[2*i];
		B = ROTL(B^A,A)+S[2*i+1];
	}
	ct[0] = A; ct[1] = B;
}

void RC5_DECRYPT(WORD *ct, WORD *pt) {
	WORD i, B = ct[1], A = ct[0];
	for(i=r; i>0; i--) {
		B = ROTR(B-S[2*i+1],A)^A;
		A = ROTR(A-S[2*i],B)^B;
	}
	pt[1] = B-S[1]; pt[0] = A-S[0];
}

void RC5_SETUP(unsigned char *K) {
	WORD i, j, k, u = w/8, A, B, L[c];
	for (i=b-1,L[c-1]=0; i!=-1; i--) L[i/u] = (L[i/u]<<8)+K[i];
	for (S[0]=P,i=1; i<t; i++) S[i] = S[i-1]+Q;
	for (A=B=i=j=k=0; k<3*t; k++,i=(i+1)%t,j=(j+1)%c) {
		A = S[i] = ROTL(S[i]+(A+B),3);
		B = L[j] = ROTL(L[j]+(A+B),(A+B));
	}
}

void printword(WORD A) {
	WORD k;
	for (k=0; k<w; k+=8) printf("%02.21X",(A>>k)&0xFF);
}

void main() {
	WORD i, j, pt1[2], pt2[2], ct[2] = {0,0};
	unsigned char key[b];
	if (sizeof(WORD)!=4)
		printf("RC5 error: WORD has %d bytes.\n",sizeof(WORD));
	printf("RC5-32/12/16 examples\n");
	for (i=1; i<6; i++) {
		pt1[0]=ct[0]; pt1[1]=ct[1];
		for (j=0; j<b; j++) key[j] = ct[0]%(255-j);
		RC5_SETUP(key);
		RC5_ENCRYPT(pt1, ct);
		RC5_DECRYPT(ct, pt2);
		printf("\n%d. key = ", i);
		for (j=0; j<b; j++) printf("%02.2X",key[j]);
		printf("\n  plaintext "); printword(pt1[0]); printword(pt1[1]);
		printf(" ---> ciphertext "); printword(ct[0]); printword(ct[1]);
		printf("\n");
		if (pt1[0]!= pt2[0] || pt1[1]!= pt2[1])
			printf("Decryption Error!");
		}
}

Your printword() function is making the results look different from the paper. Try this instead:

void printword(WORD A) {
    printf("%08X ", A);
}

That did the trick! Thanks!

Any ideas regarding the addition (and subtraction)?

I didn't understand that question. Could you elaborate and possibly provide a simple example outside of the encryption algorithm of what you're confused about?

Sorry. In trying to reproduce this, I realized it was my own math mistake.

This question has already been answered. Start a new discussion instead.