Hey guys, I've been trying to create a simple calculator interface in Python, with a display, a set of buttons which can input the digits 0-9, buttons for addition and subtraction, a button to clear the display, and an equals button. Code so far:

from tkinter import *
import tkinter.messagebox as mb

class NumberButton(Button):
    def __init__(self, parent, number, display):
        Button.__init__(self, parent, text=number, command=self.fillDisplay)
        self.value = number
        self.display = display

    def fillDisplay(self):
        curr_value = self.display.get()
        if curr_value == '0':
            new_value = str(self.value)
        elif curr_value == '+':
            new_value = ''.join([curr_value, str(self.value)])
            new_value = ''.join([curr_value, str(self.value)])
        self.display.delete(0, END)
        self.display.insert(0, new_value)

class ArithmeticButton(Button):
    def __init__(self, parent, value, display):
        Button.__init__(self, parent, text=value, command=self.doArithmetic)
        self.display = display
        self.value = value

    def doArithmetic(self):
        old_value = self.display.get()
        if len(old_value) > 3:
            mb.showinfo("Warning!", "This calculator cannot deal with numbers over 3 digits!")
            self.display.delete(0, END)
            self.display.insert(0, self.value)

def explain():
    mb.showinfo("About", "This is a simple calculator interface which can add and subtract values \nup to 999.")

def clearDisplay():
    EntryBox.delete(0, END)
    EntryBox.insert(0, '0')

root = Tk()

menubar = Menu(root)
menubar.add_command(label="About", command=explain)

EntryBox = Entry(root, width=7)
EntryBox.grid(row=0, columnspan=3)
EntryBox.insert(0, '0')

number = dict()
number[0] = NumberButton(root, 0, EntryBox).grid(row=4, sticky=W)
for x in range(7, 10):
    number[x] = NumberButton(root, x, EntryBox).grid(row=1, column=(x-7), sticky=W)

for x in range(4, 7):
    number[x] = NumberButton(root, x, EntryBox).grid(row=2, column=(x-4), sticky=W)

for x in range(1, 4):
    number[x] = NumberButton(root, x, EntryBox).grid(row=3, column=(x-1), sticky=W)

ArithmeticButton(root, "+", EntryBox).grid(row=4, column=2, sticky=W)
ArithmeticButton(root, "-", EntryBox).grid(row=4, column=1, sticky=W) 
Button(root, text="=").grid(row=0, column=5, rowspan=2, columnspan=2, stick=S)
Button(root, text="Clear", height=2, command=clearDisplay).grid(row=2, column=5, rowspan=2, columnspan=2, stick=N)



So, that's that. The buttons all work fine, but I'm stuck on how to figure out my equals button. Basically, what I thought of doing is having the arithmetic button (plus or minus) store the first number (old_value), clear the display and insert a plus or minus in the display. After another number has been inputted, the equals button retrieves the old_value, does the required arithmetic, and then outputs the result to the display. Problem is, I have no idea how to code the class for the equals button to retrieve the old_value of the ArithmeticButton class.

Help, please! :(

5 Years
Discussion Span
Last Post by edward.miller.921

You must save the instances of the ArithmeticButtons like you do for numbers, now you only create them without saving.


Thanks for the reply, Tony; by "saving the instances" do you mean using this:

AddButton = ArithmeticButton(root, "+", EntryBox)
AddButton.grid(row=4, column=2, sticky=W)

instead of what I have now, and then using AddButton.old_value?


Basically something like that, but do not use the capitalized camel case names used by convention for class names for instance variables.

add_button = ArithmeticButton(root, "+", entry_box)
add_button.grid(row=4, column=2, sticky=W)

Edited by pyTony

This topic has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.