0

i signed up to daniweb a few weeks ago when i was having problems with visual basic which after a lot of searching on google i managed to solve for myself. i am now having a go at building a website and have been using dreamweaver which makes things very simple to achieve while i'm still learning how to html works.
i have put some of my photos on one of the pages and i have been trying to go from clicking on a thumbnail to opening a new small window containing a bigger picture. i realised from studying the source code of other websites that do this that i needed to use javascript but i have been having trouble finding something that works properly in firefox and ie (i am using ie7 if it matters). when you click on one of the thumbnails eg: the picture of a lorry on http://www.fieryidris.co.uk/Pictures/InterestingLorry.htm the new window opens with the bigger picture but then continues 'thinking' even when all of the picture is loaded.
i lifted the javascript code from another website so i don't completely understand it ,i can see that it is controlling the size and appearance of the new window , but there is also a random math bit i'm not sure what that does?
is there something i need to add to the javascript code to make the new window stop saying 'transferring data from www.fieryidris.co.uk ' or have i used some rubbish javascript and need to use a different javascript?

2
Contributors
6
Replies
7
Views
11 Years
Discussion Span
Last Post by fieryidris
0

Your function needs a "document.close()" statement.

thankyou for your reply.
i had found a mention of document.close() somewhere else yesterday evening but i can't work out where i should add it to the javascript?

0

Add it to the end of the function that writes the HTML into the new window. It can be the next statement after the final document.write().

0

i know your probably going to think i'm a right idiot but i keep adding the document.close() to different places at or near the end of the javascript and i still can't get it right, it seems to work fine inside my computer but once it is uploaded to the server it still says 'transferring data from [url]www.fieryidris.co.uk[/url] ' all the time. could you please edit the script below so i can see what it should be?

function imgOpen(imgS, width, height) {
    rand_id='image'+(Math.round(Math.random()*100000));
    outf="<html><head><style>body{margin:0px;}</style></head><body leftmargin=0 topmargin=0><img src=\""+imgS+"\"></body></html>";
    iopen="iwin=self.open('"+imgS+"', '"+rand_id+"', 'width="+width+", height="+height+",toolbar=0,resizable=0');"+
        "iwin.document.write('"+outf+"');"+"iwin.focus();";
    eval(iopen);
}

Edited by pyTony: fixed formatting

0

function imgOpen(imgS, width, height) {
rand_id='image'+(Math.round(Math.random()*100000));
outf="<html><head><style>body{margin:0px;}</style></head><body leftmargin=0 topmargin=0><img src=\""+imgS+"\"></body></html>";
iopen="iwin=self.open('"+imgS+"', '"+rand_id+"', 'width="+width+", height="+height+",toolbar=0,resizable=0');"+
"iwin.document.write('"+outf+"');iwin.document.close();"+"iwin.focus();";
eval(iopen);
}

0

thankyou it is working nicely now.

it was the iwin bit that i had missed out.

This article has been dead for over six months. Start a new discussion instead.
Be sure to adhere to our posting rules.