read binary file problem

[real_castilla]

hi all,
I have a binary file, then I try to read them and show the value to the screen, but what I got is always -13108. I don't know why. Here is my code

#include <iostream>
#include <fstream>
using namespace std;

void main()
{
	std::fstream f_in, f_out;
	short speech, value[1000];
	

	f_in.open ("myfile.pcm", std::ios::in | std::ios::binary);
	f_out.open ("test2.org", ios::out | ios::binary);

	int i = 0;
	while (i < 100) {
		f_in.read((char *)&speech, 2);
		value[i] = speech;
		cout << value[i] << std::endl;
		f_out.write((char *)&speech, 2);

		i++;
	}
}

Thks for your help

[NathanOliver]

are you getting the same number for every value?
are you sure that the size of each element is 2?

[real_castilla]

yes, I always get -13108 for every value.
And yes, because my binary file is actually a raw pcm file, with short 16-bit for each value.
thks

[NathanOliver]

have you tried adding a cout statement before you assign the value to the array to make sure you are getting an assignment.

f_in.read((char *)&speech, 2);
cout << value[i] << "\t";  // show the value before assignment
value[i] = speech;
cout << value[i] << std::endl;
f_out.write((char *)&speech, 2);

[Dave Sinkula]

Is the input file opened? Is the read successful? Some error checking might help.

[real_castilla]

you're right, they are -13108 too.
I wonder what's wrong with my code :-(
thks for ur help.

[real_castilla]

Is the input file opened? Is the read successful? Some error checking might help.

thks, it haven't been opened yet. now the problem is solved.
thks again!